From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: MPS: unable to build due to assertion violation in igc_dump_check_object_starts Date: Tue, 23 Jul 2024 20:42:56 +0200 Message-ID: References: <861q3k9sfb.fsf@gnu.org> <86zfq889re.fsf@gnu.org> <86y15s893y.fsf@gnu.org> <86ttgg867k.fsf@gnu.org> <86ikww7zvf.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15573"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: pipcet@protonmail.com, eller.helmut@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jul 23 20:43:38 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sWKU6-0003qK-Lk for ged-emacs-devel@m.gmane-mx.org; Tue, 23 Jul 2024 20:43:38 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sWKTY-0007TF-Rn; Tue, 23 Jul 2024 14:43:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sWKTW-0007Qq-1A for emacs-devel@gnu.org; Tue, 23 Jul 2024 14:43:02 -0400 Original-Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sWKTU-0007Rh-9L; Tue, 23 Jul 2024 14:43:01 -0400 Original-Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-4266fd395eeso42343735e9.3; Tue, 23 Jul 2024 11:42:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721760178; x=1722364978; darn=gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=U6qrvc/BA9pW99sUg9VmWc3SnC0l5AUpBSovLFAwzxw=; b=OfxrydljNfnBQvMZbcb1COnu3Y0mCr5E6UMXBhEcWwgYVNOjq4CSUiMOzw/DBuwisD G65FHenv8CpcInszHn93+Um2TOEe6vwFAlxa1j6aPWCP5fbsE9tACWc8b1JY0ZOKdV21 OgIgzUEKvDMX934uOWlsHHj3XMT6Y9pmDKe/4h6BvrayADiFAugBtNAfzCM57kpmEaJ7 EYYQLRuzhrB0TdHnW+C8IvLjSf2estlk2PGZl1wbFUWn7rnmXGqsohhd1DK3O8WcHA10 q6eG3ZmuwoJn4vJw3oNF2usEwwbOfogPzYG5o1o4LEQzqyuTbtmZ9DhUObHlewg4X1Xb SUpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721760178; x=1722364978; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=U6qrvc/BA9pW99sUg9VmWc3SnC0l5AUpBSovLFAwzxw=; b=V33IYGh+CKfMeBf9QqpsyHl1EH7dIS7mZvQ0QSwY6/+4xJ4U2oeYUd14Lp86uYe/na IsoTtC8mpHsRyo6L0jQyz7qCHVh/9+P2asWAyZD++ooHdmnaXABUAG5J+Dt8YzTe8wR+ uiknZD2CwpuL4ki189QaB1I4exPC2Q/lqXJuk2uMN2/XPoTsdtl/35uW4UWod+gEundM QpBWDMXXDPFtuY7J3oUDI0AW9LuTjCdfO93KYg3YMW3DXZ49h9TFEhiE1tSVaCd/xUjO eiY3VuYMddGqjYmE9SLhYfbRHGq2pEyFMhci5BFxr5H3pY3Yz3swZRTAVN2cp5KwFjd9 L/GQ== X-Forwarded-Encrypted: i=1; AJvYcCXakvhHXWivvVU4u3zvI+XK+bsfncdgwOjpUgXFk0tZzpWPTvKXI8aDGUfr6JVoqKLzbJn+/Btd79drkHfp8eU791Ew X-Gm-Message-State: AOJu0YzKa0A8nfdECdqywNFCSv0eKfiSYNY+pf7AhEqYB9gzF8vQgzaw ujh6pHno5uTqM7wvFNYiJlgGA8VTr5ghR5CRxATjAJkAM7WIMHqBweOyWA== X-Google-Smtp-Source: AGHT+IEzVrJct8+m2DfXW1ycQO00sXoVuOAtKgIZFZr8jK2hldjsOgvq4dpGtgvJR3F7ijwNQaE+vw== X-Received: by 2002:a05:600c:3511:b0:427:eb0e:54be with SMTP id 5b1f17b1804b1-427eb0e56f7mr31473095e9.16.1721760177813; Tue, 23 Jul 2024 11:42:57 -0700 (PDT) Original-Received: from pro2.fritz.box (pd9e3603f.dip0.t-ipconnect.de. [217.227.96.63]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-427d2a7218esm205587765e9.25.2024.07.23.11.42.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jul 2024 11:42:57 -0700 (PDT) In-Reply-To: <86ikww7zvf.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 23 Jul 2024 21:00:04 +0300") Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=gerd.moellmann@gmail.com; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:322008 Archived-At: Eli Zaretskii writes: > So instead I added a source-level condition: > > if (ctx->igc_base_offset == THAT_SPECIFIC_VALUE) > emacs_abort (); > > and ran with a breakpoint in emacs_abort. That did the trick. Yeah, conditional breakpoints can be pretty slow. I sometimes put an igc_break () call somewhere instead of the abort, so that I can continue debugging from there on. With a breakpoint on igc_break of course. > >> We could then go up the stack and see which dump_xy function that >> is. > > Here, let me know what more you want to see: > > Thread 1 hit Breakpoint 1, emacs_abort () at w32fns.c:11335 > 11335 { > (gdb) up > #1 0x00c9febf in dump_igc_finish_obj (ctx=0x777eb38, ctx@entry=0x777eb3c) > at pdumper.c:935 > 935 emacs_abort (); > (gdb) bt > #0 emacs_abort () at w32fns.c:11335 > #1 0x00c9febf in dump_igc_finish_obj (ctx=0x777eb38, ctx@entry=0x777eb3c) > at pdumper.c:935 > #2 0x00ca5a3f in dump_cold_string (string=, ctx=0x777eb3c) > at pdumper.c:3560 Looks to me like dump_cold_string is the culprit, somehow. That's static void dump_cold_string (struct dump_context *ctx, Lisp_Object string) { /* Dump string contents. */ dump_off string_offset = dump_recall_object (ctx, string); eassert (string_offset > 0); if (SBYTES (string) > DUMP_OFF_MAX - 1) error ("string too large"); dump_off total_size = ptrdiff_t_to_dump_off (SBYTES (string) + 1); eassert (total_size > 0); # ifdef HAVE_MPS struct Lisp_String_Data *data = (struct Lisp_String_Data *) (XSTRING (string)->u.s.data - sizeof (*data)); dump_align_output (ctx, DUMP_ALIGNMENT); dump_igc_start_obj (ctx, IGC_OBJ_STRING_DATA, data); dump_remember_fixup_ptr_raw (ctx, string_offset + dump_offsetof (struct Lisp_String, u.s.data), ctx->offset + sizeof (*data)); dump_write (ctx, data, sizeof (*data) + total_size); # else dump_remember_fixup_ptr_raw (ctx, string_offset + dump_offsetof (struct Lisp_String, u.s.data), ctx->offset); dump_write (ctx, XSTRING (string)->u.s.data, total_size); # endif # ifdef HAVE_MPS dump_igc_finish_obj (ctx); # endif } We are inside of the dump_igc_finish_obj. I see nothing immediately suspicious there, hm. Can you try to look at that header? It is at offset ctx->igc_base_offset from ctx->buf. Something like p header_type ((char *) ctx->buf + ctx->igc_base_offset) Is it already broken? Depending on where exactly you emacs_abort it either should still be zeroed or contain something valid like type IGC_OBJ_STRING_DATA.