unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Should we have a commit size guideline? (was: builds are getting slower?)
@ 2015-12-15 13:48 Artur Malabarba
  2015-12-15 14:23 ` Should we have a commit size guideline? David Kastrup
  2015-12-15 16:16 ` Should we have a commit size guideline? (was: builds are getting slower?) Eli Zaretskii
  0 siblings, 2 replies; 9+ messages in thread
From: Artur Malabarba @ 2015-12-15 13:48 UTC (permalink / raw)
  To: David Kastrup; +Cc: emacs-devel

2015-12-15 12:49 GMT+00:00 David Kastrup <dak@gnu.org>:
> [Regarding commit 2e84888]
>
> This is a very, very large commit.  It should have been split into
> multiple commits addressing separate issues.

When commiting changes, I usually group them into the smallest
possible commits while still leaving everything in a consistent state
(i.e., not defining a function that's only used in later commits, not
changing a function without making the necessary changes in other
places that call this function). I find that this helps with both
git-bisect and git-revert.

If we have a different policy (maybe we should) I'm happy to adhere.


Cheers,
Artur



^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2015-12-16 11:12 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-15 13:48 Should we have a commit size guideline? (was: builds are getting slower?) Artur Malabarba
2015-12-15 14:23 ` Should we have a commit size guideline? David Kastrup
2015-12-16 11:12   ` Artur Malabarba
2015-12-15 16:16 ` Should we have a commit size guideline? (was: builds are getting slower?) Eli Zaretskii
2015-12-15 17:56   ` Should we have a commit size guideline? John Wiegley
2015-12-16  0:13     ` Paul Eggert
2015-12-16  0:23       ` Dmitry Gutov
2015-12-16  1:00         ` Paul Eggert
2015-12-16  1:19           ` indent-tabs-mode setting in Emacs's dir-locals.el Dmitry Gutov

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).