unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: charles@aurox.ch (Charles A. Roelli)
To: Alan Third <alan@idiocy.org>
Cc: emacs-devel@gnu.org
Subject: Re: Change to NS drawing routines
Date: Wed, 15 Aug 2018 21:20:17 +0200	[thread overview]
Message-ID: <m2in4b4etq.fsf@aurox.ch> (raw)
In-Reply-To: <20180813184659.GA2258@breton.holly.idiocy.org> (message from Alan Third on Mon, 13 Aug 2018 19:46:59 +0100)

> Date: Mon, 13 Aug 2018 19:46:59 +0100
> From: Alan Third <alan@idiocy.org>
> 
> from http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00435.html
> 
> I can understand the argument to an extent, but I don’t have another
> solution.

Thanks for the pointer.

By the way, I noticed that one of the problems YAMAMOTO Mitsuharu
discovered with the current way of drawing is fixed in your branch:

> Link:		https://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00440.html
>
> (Another problem with drawing outside the "expose" handler can be
> observed with the NS port on Mac OS X 10.6 and earlier: the resize
> handle at the right bottom corner gets overwritten.)

It's a small detail, but neat nevertheless.

> > > My experience so far is that performance is not noticeably slower than
> > > master, however if someone with a slower Mac could try it that would
> > > be helpful.
> > 
> > I don't notice a speed difference compared to master on my slow box
> > running macOS 10.6.  Do we have any benchmarks that we could use to
> > check?
> 
> Unfortunately I’m not aware of any. I’m tempted to say that if there
> is no clear performance penalty, then it’s not a problem.

I tried M-x benchmark RET (redisplay) RET in master and in
scratch/ns-drawing, with scratch/ns-drawing often being faster in the
middle of big files like xdisp.c.  But I don't remember if I messed
with compiler options recently, so it would be good if somebody else
could check.



  parent reply	other threads:[~2018-08-15 19:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-11 14:06 Change to NS drawing routines Alan Third
2018-08-12 10:47 ` Charles A. Roelli
2018-08-13 18:46   ` Alan Third
2018-08-13 19:10     ` Eli Zaretskii
2018-08-13 19:36       ` Alan Third
2018-08-14 14:50         ` Eli Zaretskii
2018-08-15 20:43           ` Alan Third
2018-08-15 19:20     ` Charles A. Roelli [this message]
2018-08-15 20:42       ` Alan Third
2018-08-13  8:24 ` Nick Helm
2018-08-13  9:15 ` Van L

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2in4b4etq.fsf@aurox.ch \
    --to=charles@aurox.ch \
    --cc=alan@idiocy.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).