From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Roman Rudakov Newsgroups: gmane.emacs.devel Subject: Re: Call for volunteers: add tree-sitter support to major modes Date: Mon, 10 Oct 2022 09:34:51 +0200 Message-ID: References: <83czb1jrm3.fsf@gnu.org> <878rlo7on0.fsf@thornhill.no> Reply-To: rrudakov@fastmail.com Mime-Version: 1.0 Content-Type: text/plain; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21616"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.8.10; emacs 29.0.50 Cc: Eli Zaretskii , emacs-devel@gnu.org To: Theodor Thornhill Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Oct 10 09:44:44 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ohnSs-0005NS-QD for ged-emacs-devel@m.gmane-mx.org; Mon, 10 Oct 2022 09:44:44 +0200 Original-Received: from localhost ([::1]:57752 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ohnSr-0006Le-MQ for ged-emacs-devel@m.gmane-mx.org; Mon, 10 Oct 2022 03:44:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41240) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohnNJ-0002mF-SA for emacs-devel@gnu.org; Mon, 10 Oct 2022 03:38:57 -0400 Original-Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:36387) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohnNG-0002pv-Ru; Mon, 10 Oct 2022 03:38:57 -0400 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 5A72B320082A; Mon, 10 Oct 2022 03:38:51 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 10 Oct 2022 03:38:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:reply-to:sender :subject:subject:to:to; s=fm3; t=1665387530; x=1665473930; bh=b4 eCcfhnuWZTFKGzpVcUTnaT/zK60UZ3RbJRsMXk9so=; b=syB8CGS2vmHnzT5UNv Kby7gHkjSGQG/bwxRTFzivw/wkpZpMoJ+rZ2F2YNPZnqHh11nmlPKktOmYvXvhZX 3B00dDfpuA7O2UCDQZ5s/mYSSX1fuuTU/dtJZPLRwP4ynxPaci8lBitAhyT1oOer kKxraVbHThQK4tbgdThiSYgkb4FXIb0+3NVKL3NpGgWeMfskc5p1gTeHuj68m3t2 +45syiFT556w0WqptBg0a22fPddwYHGU3pb9UxLuIewKmgd3dR7klisOV6ctW930 epRb7xzXPwSwYY+x3p1VqEFZiWEwgfd575cxzFhDasH2Rx5+vsrufn3Dkaxtk1kH 4gug== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1665387530; x=1665473930; bh=b4eCcfhnuWZTF KGzpVcUTnaT/zK60UZ3RbJRsMXk9so=; b=gqTXJEWVm3AnpczBqDbmD0Fkp3187 rSePwBAEOQjsgV7zzAeo8RUF//AGJMhntwVPMNzzTaDf0O+7Jo1MDMPmDgMDXcU1 v5RaKNRDKm0LbAA57nRPz82+9qnCZcOx0KW6OGXet0GZ6zWMLbRpPEB966B32G/7 7Md8KNrOf/N/hqkENrupGmCrqTHXMYOSkfbbFuRdd7dhS9OvyNWRyRfDj5U2FxNO FWnG3qJ12sZlpVFNDAmoSFJIMcD/Y8gcXbbX8AcBodhu6MhdRWPRXOojqs/OxF0r am23nXDVxUtyaxGpOLYluyBUie0Mddq6xbgEkc4LixTJEGXEi6AA4uU8g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeejfedgtdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfhgfhffvvefuffhrjgfkgggtsehttdertddtredtnecuhfhrohhmpeftohhm rghnucftuhgurghkohhvuceorhhruhgurghkohhvsehfrghsthhmrghilhdrtghomheqne cuggftrfgrthhtvghrnhepkefhkedtkedtkeduheekfeejkeeiteevgfehleegjedtheeu ffffheeihfehuefhnecuffhomhgrihhnpehsrhdrhhhtpdgvmhgrtghsrdhorhhgnecuve hluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprhhruhgurghk ohhvsehfrghsthhmrghilhdrtghomh X-ME-Proxy: Feedback-ID: i1c714620:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 10 Oct 2022 03:38:50 -0400 (EDT) In-reply-to: <878rlo7on0.fsf@thornhill.no> Received-SPF: pass client-ip=64.147.123.25; envelope-from=rrudakov@fastmail.com; helo=wout2-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297328 Archived-At: Theodor Thornhill writes: > Eli Zaretskii writes: > >> >> Some of the popular major modes for which we would like to see >> tree-sitter support in Emacs 29 are: >> >> c-mode >> c++-mode >> emacs-lisp-mode >> js-mode >> js-json-mode >> ruby-mode >> shell-script-mode >> > > I'd like to add in Java support here as well. But since java is part > of > cc-mode.el, maybe it'd be best if it got its own mode, say > java-treesitter-mode.el, so that we don't add a dependency into > cc-mode? > If you agree, I can create such a major-mode as well. > > Also, how should we mandate what modes get the new tree-sitter > support? > It is pretty fast to add new modes, and adding support for languages > not > already supported in core, such as say, golang, should be very > feasible. > But maybe that is something that should live in elpa? > > Theo Hi! I had an idea to work on tree-sitter support for Java, but I don't have a lot of experience with Emacs-lisp and I haven't signed a copyright assignment. Though I used emacs for java development for a while with tree-sitter and I have some queries in my config which might be useful. https://git.sr.ht/~rrudakov/dotfiles/tree/master/item/emacs.d/emacs.org#L2453-2623 Feel free to use it. -- Best regards, Roman