* Re: master d8a00879309: Cease preloading touch-screen.el outside X and Android
[not found] ` <20231206023526.8C80FC38EA3@vcs2.savannah.gnu.org>
@ 2023-12-06 22:12 ` Arash Esbati
2023-12-07 5:14 ` Po Lu
2023-12-07 6:35 ` Eli Zaretskii
0 siblings, 2 replies; 4+ messages in thread
From: Arash Esbati @ 2023-12-06 22:12 UTC (permalink / raw)
To: emacs-devel; +Cc: Po Lu
Po Lu via Mailing list for Emacs changes <emacs-diffs@gnu.org> writes:
> branch: master
> commit d8a00879309a3bf62f6ffcae103aa3bdba776ee9
> Author: Po Lu <luangruo@yahoo.com>
> Commit: Po Lu <luangruo@yahoo.com>
>
> Cease preloading touch-screen.el outside X and Android
>
> * lisp/calc/calc.el (touch-screen-display-keyboard):
>
> * lisp/minibuffer.el (clear-minibuffer-message):
>
> * lisp/term.el (touch-screen-display-keyboard): Declare
> touch-screen-display-keyboard before binding or setting it.
>
> * lisp/loadup.el: Don't autoload touch-screen.el outside X and
> Android.
>
> * lisp/touch-screen.el: Autoload functions called from commands
> responding to touch screen events.
I think this change produces these warnings:
In end of data:
button.el:498:26: Warning: the function ‘touch-screen-track-tap’ is not
known to be defined.
In clear-minibuffer-message:
minibuffer.el:979:23: Warning: reference to free variable
‘touch-screen-current-tool’
In tab-bar-touchscreen-begin:
tab-bar.el:440:55: Warning: reference to free variable
‘touch-screen-delay’
In end of data:
dired.el:5185:8: Warning: the function ‘touch-screen-hold’ is not known
to be defined.
In tab-line-track-tap:
tab-line.el:978:50: Warning: reference to free variable
‘touch-screen-delay’
This is with Emacs from master (d8a0087930) on macOS, built with:
git clean -fdx
./autogen
./configure ...
make
Best, Arash
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: master d8a00879309: Cease preloading touch-screen.el outside X and Android
2023-12-06 22:12 ` master d8a00879309: Cease preloading touch-screen.el outside X and Android Arash Esbati
@ 2023-12-07 5:14 ` Po Lu
2023-12-07 7:31 ` Arash Esbati
2023-12-07 6:35 ` Eli Zaretskii
1 sibling, 1 reply; 4+ messages in thread
From: Po Lu @ 2023-12-07 5:14 UTC (permalink / raw)
To: Arash Esbati; +Cc: emacs-devel
Arash Esbati <arash@gnu.org> writes:
> I think this change produces these warnings:
>
> In end of data:
> button.el:498:26: Warning: the function ‘touch-screen-track-tap’ is not
> known to be defined.
>
> In clear-minibuffer-message:
> minibuffer.el:979:23: Warning: reference to free variable
> ‘touch-screen-current-tool’
>
> In tab-bar-touchscreen-begin:
> tab-bar.el:440:55: Warning: reference to free variable
> ‘touch-screen-delay’
>
> In end of data:
> dired.el:5185:8: Warning: the function ‘touch-screen-hold’ is not known
> to be defined.
>
> In tab-line-track-tap:
> tab-line.el:978:50: Warning: reference to free variable
> ‘touch-screen-delay’
>
> This is with Emacs from master (d8a0087930) on macOS, built with:
>
> git clean -fdx
> ./autogen
> ./configure ...
> make
>
> Best, Arash
I fixed three of these, and the remainder should resolve themselves once
autoloads are generated. Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: master d8a00879309: Cease preloading touch-screen.el outside X and Android
2023-12-07 5:14 ` Po Lu
@ 2023-12-07 7:31 ` Arash Esbati
0 siblings, 0 replies; 4+ messages in thread
From: Arash Esbati @ 2023-12-07 7:31 UTC (permalink / raw)
To: Po Lu; +Cc: emacs-devel
Po Lu <luangruo@yahoo.com> writes:
> I fixed three of these, and the remainder should resolve themselves once
> autoloads are generated. Thanks.
Thanks. Updating to e4e1e268c8 and building again, I get:
In clear-minibuffer-message:
minibuffer.el:979:23: Warning: reference to free variable
‘touch-screen-current-tool’
Not sure if I missed that with my last message.
Best, Arash
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: master d8a00879309: Cease preloading touch-screen.el outside X and Android
2023-12-06 22:12 ` master d8a00879309: Cease preloading touch-screen.el outside X and Android Arash Esbati
2023-12-07 5:14 ` Po Lu
@ 2023-12-07 6:35 ` Eli Zaretskii
1 sibling, 0 replies; 4+ messages in thread
From: Eli Zaretskii @ 2023-12-07 6:35 UTC (permalink / raw)
To: Arash Esbati; +Cc: emacs-devel, luangruo
> From: Arash Esbati <arash@gnu.org>
> Cc: Po Lu <luangruo@yahoo.com>
> Date: Wed, 06 Dec 2023 23:12:21 +0100
>
> Po Lu via Mailing list for Emacs changes <emacs-diffs@gnu.org> writes:
>
> > branch: master
> > commit d8a00879309a3bf62f6ffcae103aa3bdba776ee9
> > Author: Po Lu <luangruo@yahoo.com>
> > Commit: Po Lu <luangruo@yahoo.com>
> >
> > Cease preloading touch-screen.el outside X and Android
> >
> > * lisp/calc/calc.el (touch-screen-display-keyboard):
> >
> > * lisp/minibuffer.el (clear-minibuffer-message):
> >
> > * lisp/term.el (touch-screen-display-keyboard): Declare
> > touch-screen-display-keyboard before binding or setting it.
> >
> > * lisp/loadup.el: Don't autoload touch-screen.el outside X and
> > Android.
> >
> > * lisp/touch-screen.el: Autoload functions called from commands
> > responding to touch screen events.
>
> I think this change produces these warnings:
>
> In end of data:
> button.el:498:26: Warning: the function ‘touch-screen-track-tap’ is not
> known to be defined.
>
> In clear-minibuffer-message:
> minibuffer.el:979:23: Warning: reference to free variable
> ‘touch-screen-current-tool’
>
> In tab-bar-touchscreen-begin:
> tab-bar.el:440:55: Warning: reference to free variable
> ‘touch-screen-delay’
>
> In end of data:
> dired.el:5185:8: Warning: the function ‘touch-screen-hold’ is not known
> to be defined.
>
> In tab-line-track-tap:
> tab-line.el:978:50: Warning: reference to free variable
> ‘touch-screen-delay’
>
> This is with Emacs from master (d8a0087930) on macOS, built with:
>
> git clean -fdx
> ./autogen
> ./configure ...
> make
The two functions are autoloaded, so I'm guessing that the warnings go
away once loaddefs.el is generated.
The variables indeed need a defvar, I think.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-07 7:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <170183012607.20763.1485814684546086922@vcs2.savannah.gnu.org>
[not found] ` <20231206023526.8C80FC38EA3@vcs2.savannah.gnu.org>
2023-12-06 22:12 ` master d8a00879309: Cease preloading touch-screen.el outside X and Android Arash Esbati
2023-12-07 5:14 ` Po Lu
2023-12-07 7:31 ` Arash Esbati
2023-12-07 6:35 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).