From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: MPS codegen Date: Fri, 14 Jun 2024 16:05:03 +0200 Message-ID: References: <87le3b43qi.fsf@gmail.com> <86r0d21tqj.fsf@gnu.org> <877cetgqiz.fsf_-_@gmail.com> <87wmmsg2e4.fsf@gmail.com> <878qz8ezn4.fsf@gmail.com> <8734pfgb51.fsf@gmail.com> <86ikybyd2h.fsf@gnu.org> <86bk43y8tr.fsf@gnu.org> <868qz7y6vj.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10943"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: eller.helmut@gmail.com, acorallo@gnu.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 14 16:05:48 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sI7Yo-0002ZH-JG for ged-emacs-devel@m.gmane-mx.org; Fri, 14 Jun 2024 16:05:46 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sI7YG-0003rc-OU; Fri, 14 Jun 2024 10:05:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sI7YF-0003po-1v for emacs-devel@gnu.org; Fri, 14 Jun 2024 10:05:11 -0400 Original-Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sI7YC-0000Xn-KN; Fri, 14 Jun 2024 10:05:10 -0400 Original-Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-a6e349c0f2bso310285966b.2; Fri, 14 Jun 2024 07:05:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718373906; x=1718978706; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fqrDOtNI5YgOwOqT1YLnoIcvearbft97CYxIp62rhkY=; b=FX7pI26Qmn6I8Y/iDHUH8exLJ2Kvj+FrRTmTxEMYPQmFpcwzC1zvOVbDVPSKfASH6B PsD8Ypue3slp4XdxH6szb+TQvOi+8HufVPUSJkfbsqk5J5HYdgnxpnpYzEVs4AR5sewP WrLBXYd9XYcgNkk4LXPW9a2cd1iKJqlEN6a9eKV4BPdcCmgYT14ohzKGpbMOFiWYvAEO Q2n/DUcT3C/dchnhjcptHTo3vZFN21hMuNNqGqYmwci0SeEC/HBQDEvfPvGLO3YvDY+8 HT5sqx83essjpSLUNW8io0FEkv40CAIr7HRkogr9v/nv52NY6/t0AfFpfzJtu3HEl6B0 KiYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718373906; x=1718978706; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=fqrDOtNI5YgOwOqT1YLnoIcvearbft97CYxIp62rhkY=; b=qB2Xyi781VQgbeGjCA/OiII3LFBMK1Oru1W42in3FNYmFfyssdJDa14+ZNU2edZLBB GMEBy+VI4YbuZoYXgOxRtBvJwXOhUCDLhqqn8fqEmiV7stkP3G/limzE7YTbb6p+Dw3Q uMjvmSjQ2tVF2xU5qh86LztMYA8/sTYTUs3mPBOLofaSON56Kr7jvM2lCuc0d0P519ab wIu3GNXENp3hq2RoKm9NDH6kmwye3rjqhbi9dombQUbG8hbRdAOCSF9/5nNLlc+JXje1 sP6XHBRrI1WiLlr62J7KSWt0v2nMtjhC7q3huDTckjVXHm3Cfs7UAzQsbahwPTmUTWPi FZtQ== X-Forwarded-Encrypted: i=1; AJvYcCU4PWdylozvY3IWt69OVl+qQ2TN0KiH6yM9L2vIkdaGJT1EPvTjRV/wHnLat1FC3bI7FEEnngc69X87wJCFJmnIv+382pDppNCTL5U+gR55jT59INFr X-Gm-Message-State: AOJu0Yx2SRcf0Bqtxl2iZSparWaYb2ztOnnyFpzgH/QpIXMR/s0v/Ijc /T2S/JNAsf5sw0EuvIlGsBZ4IomLOrsOJU+tJ9k7Iw2JpFl5IelsSx2tPQ== X-Google-Smtp-Source: AGHT+IHNYy9DUEM0Z1WE0M5vZCUf0W6m5Ca9jLPzL34slSaGBeMRWmNvAyyScHPr+eWwnZCt6zBsRw== X-Received: by 2002:a17:906:ae89:b0:a6f:e1a:3ee0 with SMTP id a640c23a62f3a-a6f60d29549mr194866466b.30.1718373905281; Fri, 14 Jun 2024 07:05:05 -0700 (PDT) Original-Received: from pro2.fritz.box (pd9e367ea.dip0.t-ipconnect.de. [217.227.103.234]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a6f56da336fsm186498966b.41.2024.06.14.07.05.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Jun 2024 07:05:04 -0700 (PDT) In-Reply-To: <868qz7y6vj.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 14 Jun 2024 16:46:24 +0300") Received-SPF: pass client-ip=2a00:1450:4864:20::62b; envelope-from=gerd.moellmann@gmail.com; helo=mail-ej1-x62b.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320074 Archived-At: Eli Zaretskii writes: >> From: Gerd M=C3=B6llmann >> Cc: eller.helmut@gmail.com, acorallo@gnu.org, emacs-devel@gnu.org >> Date: Fri, 14 Jun 2024 15:17:03 +0200 >>=20 >> Eli Zaretskii writes: >>=20 >> >> For SYMBO:_FORWARDED, I think sym->u.val.fwd should be used. So I thi= nk >> >> maybe it is somwhere in that direction. Perhaps function mirror_fwd? >> > >> > Sorry, I don't understand: all those values are identical, so how does >> > it matter which one we use? Or what am I missing? >>=20 >> What I was trying to convey is kust that in this case mirror_fwd is used. > > Is or should be? Is. > I see mirror_fwd used only in igc.c, and it's a static function there. > > I guess what I'm saying is that I don't understand what you suggest to > do or check to try to fix these segfaults. One big difference to before is that the object graph in the loaded dump is copied top MPS (see igc_on_pdump_loaded). This proceeds in steps. 1. iterate over objects in the dump and copy them. Record for each object in dump what its copy is (igc_mirror::dump_to_mps). 2. iterate over objects in the copy, and "mirror" references, i.e. replace references to the old graph with references in the copy. Here, mirror_fwd comes into play, as subroutine of mirror_symbol. 3. Fix roots in a similar way. 4. Discard the dump. I'd probably put a breakpoitn in mirror_fwd and look around if something there is not right for IA32, or Windows, don't know. It's just a guess, though.