Re: CC Mode 5.31.3

[Sean O'Rourke <sorourke@cs.ucsd.edu>]

[-- Attachment #1: Type: text/plain, Size: 862 bytes --]

Alan Mackenzie <acm@muc.de> writes:
> As agreed with RMS, C-M-[ae] should be be bound to
> c-\(beginning\|end\)-of-defun by default, rather than the standard
> commands \(beginning\|end\)-of-defun.  These two CC Mode commands could
> do with some optimisation, but this seems optional rather than necessary.
> This is still to do.  However, it is trivial, involving only drudge work,
> mostly in the manual.  It should be there in 5.31.4.

Have you thought instead of mode-locally setting
{beginning,end}-of-defun-function?  This way, other commands like
mark-defun that operate on functions automatically pick up the
language-specific versions.  I have been using this setting for
about a year without any problems after making the attached
trivial patch, which prevents infinite recursion when
beginning-of-defun-function itself calls beginning-of-defun.

/s


[-- Attachment #2: Type: text/plain, Size: 1620 bytes --]

Index: lisp.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/emacs-lisp/lisp.el,v
retrieving revision 1.74
diff -p -u -w -u -r1.74 lisp.el
--- lisp.el	6 Feb 2006 12:20:06 -0000	1.74
+++ lisp.el	24 Feb 2006 18:44:26 -0000
@@ -210,12 +210,14 @@ If variable `beginning-of-defun-function
 is called as a function to find the defun's beginning."
   (interactive "p")
   (if beginning-of-defun-function
+      (let ((bodf beginning-of-defun-function)
+            (beginning-of-defun-function nil))
       (if (> (setq arg (or arg 1)) 0)
 	  (dotimes (i arg)
-	    (funcall beginning-of-defun-function))
+              (funcall bodf))
 	;; Better not call end-of-defun-function directly, in case
 	;; it's not defined.
-	(end-of-defun (- arg)))
+            (end-of-defun (- arg))))
     (and arg (< arg 0) (not (eobp)) (forward-char 1))
     (and (re-search-backward (if defun-prompt-regexp
 				 (concat (if open-paren-in-column-0-is-defun-start
@@ -255,12 +257,14 @@ is called as a function to find the defu
       (push-mark))
   (if (or (null arg) (= arg 0)) (setq arg 1))
   (if end-of-defun-function
+      (let ((eodf end-of-defun-function)
+            (end-of-defun-function nil))
       (if (> arg 0)
 	  (dotimes (i arg)
-	    (funcall end-of-defun-function))
+              (funcall eodf))
 	;; Better not call beginning-of-defun-function
 	;; directly, in case it's not defined.
-	(beginning-of-defun (- arg)))
+            (beginning-of-defun (- arg))))
     (let ((first t))
       (while (and (> arg 0) (< (point) (point-max)))
 	(let ((pos (point)))