ps-print-buffer-with-faces chokes on face attribute property lists

ps-print-buffer-with-faces chokes on face attribute property lists

[Nikolaj Schumacher]

Hello,

this bug was reported to me, but I think ps-print is at fault.

When printing a buffer with overlays that specify the 'face property
using a property list, `ps-print-buffer-with-faces' fails.


For instance, the following snippet will throw an error.

(let ((ov (make-overlay (point-min) (point-max) nil)))
  (overlay-put ov 'face '(:foreground "gray"))
  (ps-print-buffer-with-faces))


The reason appears to be `ps-face-attribute-list':

(ps-face-attribute-list '(foreground-color . "gray"))  ; ok
(ps-face-attribute-list '(:foreground "gray"))         ; fails



The original report:

> Hi Nikolaj,
>
>
> Symptoms:
> ps-print-buffer-with-faces returns an error if
> highlight-parentheses-mode is enabled and point is located inside a pair
> of parentheses.  Mini-buffer contains the following error message:
>
> ps-face-attribute-list: Wrong type argument: listp, "firebrick1"
>
>
> Recipe:
> 1.  emacs -q
> 2.  M-x load-file highlight-parentheses.el RET
> 3.  M-x highlight-parentheses-mode RET
> 4.  Now, type: (abc)
> 5.  C-b
> 6.  M-x ps-print-buffer-with-faces
>
>
> I'm using highlight-parentheses v1.0 with Emacs 22.1:
>
>> In GNU Emacs 22.1.50.1 (i386-mingw-nt5.1.2600)
>>  of 2007-07-07 on NEUTRINO
>> Windowing system distributor `Microsoft Corp.', version 5.1.2600
>> configured using `configure --with-gcc (3.4) --cflags -Ic:/Programme/GnuWin32/include'
>
>
> Thanks,
> Stephan Hennig

The package in question can be found at
http://nschum.de/src/emacs/highlight-parentheses/


regards,
Nikolaj Schumacher

Re: ps-print-buffer-with-faces chokes on face attribute property lists

[Vinicius Jose Latorre]

Hi Nikolaj,


Sorry for the delay.  I've just fixed this problem in Emacs CVS trunk, 
emacs-unicode and EMACS-22-BRANCH.


Thanks for your report,


Vinicius



Nikolaj Schumacher wrote:
> Hello,
>
> this bug was reported to me, but I think ps-print is at fault.
>
> When printing a buffer with overlays that specify the 'face property
> using a property list, `ps-print-buffer-with-faces' fails.
>
>
> For instance, the following snippet will throw an error.
>
> (let ((ov (make-overlay (point-min) (point-max) nil)))
>   (overlay-put ov 'face '(:foreground "gray"))
>   (ps-print-buffer-with-faces))
>
>
> The reason appears to be `ps-face-attribute-list':
>
> (ps-face-attribute-list '(foreground-color . "gray"))  ; ok
> (ps-face-attribute-list '(:foreground "gray"))         ; fails
>
>
>
> The original report:
>
>   
>> Hi Nikolaj,
>>
>>
>> Symptoms:
>> ps-print-buffer-with-faces returns an error if
>> highlight-parentheses-mode is enabled and point is located inside a pair
>> of parentheses.  Mini-buffer contains the following error message:
>>
>> ps-face-attribute-list: Wrong type argument: listp, "firebrick1"
>>
>>
>> Recipe:
>> 1.  emacs -q
>> 2.  M-x load-file highlight-parentheses.el RET
>> 3.  M-x highlight-parentheses-mode RET
>> 4.  Now, type: (abc)
>> 5.  C-b
>> 6.  M-x ps-print-buffer-with-faces
>>
>>
>> I'm using highlight-parentheses v1.0 with Emacs 22.1:
>>
>>     
>>> In GNU Emacs 22.1.50.1 (i386-mingw-nt5.1.2600)
>>>  of 2007-07-07 on NEUTRINO
>>> Windowing system distributor `Microsoft Corp.', version 5.1.2600
>>> configured using `configure --with-gcc (3.4) --cflags -Ic:/Programme/GnuWin32/include'
>>>       
>> Thanks,
>> Stephan Hennig
>>     
>
> The package in question can be found at
> http://nschum.de/src/emacs/highlight-parentheses/
>
>
> regards,
> Nikolaj Schumacher
>