Re: [Emacs-diffs] emacs-25 0a0144a: Delete environment variables in Tramp when needed

Re: [Emacs-diffs] emacs-25 0a0144a: Delete environment variables in Tramp when needed

[John Wiegley]

>>>>> "MA" == Michael Albinus <Michael.Albinus@gmx.de> writes:

MA> branch: emacs-25
MA> commit 0a0144a2e15a00b5c3272ad95e62d1d489b453c4
MA> Author: Michael Albinus <michael.albinus@gmx.de>
MA> Commit: Michael Albinus <michael.albinus@gmx.ed>

Hi Michael,

MA>     Delete environment variables in Tramp when needed

MA>     * lisp/net/tramp-sh.el (tramp-get-env-with-u-option): New defun.
MA> (tramp-sh-handle-start-file-process) (tramp-sh-handle-process-file, ): Use
MA> it. (Bug#23952)

I cannot find this bug on the release blockers list. Can you tell me why it
was pushed to emacs-25?  I've looked around my e-mail box, but maybe this was
OK'd by Eli in another thread on emacs-devel?

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

Re: [Emacs-diffs] emacs-25 0a0144a: Delete environment variables in Tramp when needed

[Eli Zaretskii]

> From: John Wiegley <jwiegley@gmail.com>
> Date: Tue, 12 Jul 2016 15:39:36 -0700
> Cc: Eli Zaretskii <eliz@gnu.org>, Michael Albinus <michael.albinus@gmx.de>
> 
> >>>>> "MA" == Michael Albinus <Michael.Albinus@gmx.de> writes:
> 
> MA> branch: emacs-25
> MA> commit 0a0144a2e15a00b5c3272ad95e62d1d489b453c4
> MA> Author: Michael Albinus <michael.albinus@gmx.de>
> MA> Commit: Michael Albinus <michael.albinus@gmx.ed>
> 
> Hi Michael,
> 
> MA>     Delete environment variables in Tramp when needed
> 
> MA>     * lisp/net/tramp-sh.el (tramp-get-env-with-u-option): New defun.
> MA> (tramp-sh-handle-start-file-process) (tramp-sh-handle-process-file, ): Use
> MA> it. (Bug#23952)
> 
> I cannot find this bug on the release blockers list. Can you tell me why it
> was pushed to emacs-25?  I've looked around my e-mail box, but maybe this was
> OK'd by Eli in another thread on emacs-devel?

Yes, I okayed it.  It's a bad regression due to some recent change in
emacs-25, and Michael says it's safe enough for the release branch.

Re: [Emacs-diffs] emacs-25 0a0144a: Delete environment variables in Tramp when needed

[Michael Albinus]

John Wiegley <jwiegley@gmail.com> writes:

> Hi Michael,

Hi John,

> I cannot find this bug on the release blockers list. Can you tell me why it
> was pushed to emacs-25?  I've looked around my e-mail box, but maybe this was
> OK'd by Eli in another thread on emacs-devel?

As said already by Eli, this was agreed. I've promised also a new test
case in tramp-tests.el later today. If this shouldn't go into the
emacs-25 branch, somebody shall stop me.

Best regards, Michael.