* emacs 26.0.50.1 - add DNS keywords and remove duplications
@ 2017-01-06 7:51 Alexander Kuleshov
2017-01-10 13:48 ` Simon Leinen
0 siblings, 1 reply; 7+ messages in thread
From: Alexander Kuleshov @ 2017-01-06 7:51 UTC (permalink / raw)
To: emacs-devel
[-- Attachment #1: Type: text/plain, Size: 205 bytes --]
Hello everyone,
I've attached the patch which adds TLSA (RFC 6698) and NSEC3
(RFC 5155) to dns-mode-types.
Additioanlly these RFCs were added to comments and duplication
of NSAP was removed.
Thank you.
[-- Attachment #2: 0001-Add-DNS-keywords-and-remove-duplications.patch --]
[-- Type: text/plain, Size: 1685 bytes --]
From f241e2f0e424d43ebce14d8d4a7bc29b9fafd029 Mon Sep 17 00:00:00 2001
From: Alexander Kuleshov <kuleshovmail@gmail.com>
Date: Fri, 23 Dec 2016 16:53:41 +0600
Subject: emacs 26.0.50.1 - add DNS keywords and remove duplications
* lisp/textmodes/dns-mode.el (dns-mode-types): Add two TLSA and
NSEC" DNS related keywords and remove duplication of "NSAP".
---
lisp/textmodes/dns-mode.el | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/lisp/textmodes/dns-mode.el b/lisp/textmodes/dns-mode.el
index 521b1f3..7159c71 100644
--- a/lisp/textmodes/dns-mode.el
+++ b/lisp/textmodes/dns-mode.el
@@ -32,6 +32,9 @@
;; RFC 1034, "DOMAIN NAMES - CONCEPTS AND FACILITIES", P. Mockapetris.
;; RFC 1035, "DOMAIN NAMES - IMPLEMENTATION AND SPECIFICATION", P. Mockapetris.
+;; RFC 5155, "DNS Security (DNSSEC) Hashed Authenticated Denial of Existence"
+;; RFC 6698, "The DNS-Based Authentication of Named Entities (DANE)
+;; Transport Layer Security (TLS) Protocol: TLSA"
;;; Release history:
@@ -50,13 +53,13 @@ dns-mode-classes
(defconst dns-mode-types '("A" "NS" "MD" "MF" "CNAME" "SOA" "MB" "MG" "MR"
"NULL" "WKS" "PTR" "HINFO" "MINFO" "MX" "TXT"
- "RP" "AFSDB" "X25" "ISDN" "RT" "NSAP" "NSAP"
+ "RP" "AFSDB" "X25" "ISDN" "RT" "NSAP"
"SIG" "KEY" "PX" "GPOS" "AAAA" "LOC" "NXT"
"EID" "NIMLOC" "SRV" "ATMA" "NAPTR" "KX" "CERT"
"A6" "DNAME" "SINK" "OPT" "APL" "DS" "SSHFP"
"RRSIG" "NSEC" "DNSKEY" "UINFO" "UID" "GID"
"UNSPEC" "TKEY" "TSIG" "IXFR" "AXFR" "MAILB"
- "MAILA")
+ "MAILA" "TLSA" "NSEC3" )
"List of strings with known DNS types.")
;; Font lock.
--
2.8.0.rc3.1353.gea9bdc0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: emacs 26.0.50.1 - add DNS keywords and remove duplications
2017-01-06 7:51 emacs 26.0.50.1 - add DNS keywords and remove duplications Alexander Kuleshov
@ 2017-01-10 13:48 ` Simon Leinen
2017-01-11 11:12 ` Alexander Kuleshov
0 siblings, 1 reply; 7+ messages in thread
From: Simon Leinen @ 2017-01-10 13:48 UTC (permalink / raw)
To: Alexander Kuleshov; +Cc: emacs-devel
> I've attached the patch which adds TLSA (RFC 6698) and NSEC3
> (RFC 5155) to dns-mode-types.
Cool, that looks correct and useful - we use both these record types,
though NSEC3 records are usually in machine-generated include files.
My only (cosmetic) suggestion for improvement would be to delete the
space between "NSEC3" and the closing parenthesis.
> Additioanlly these RFCs were added to comments and duplication
> of NSAP was removed.
--
Simon.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: emacs 26.0.50.1 - add DNS keywords and remove duplications
2017-01-10 13:48 ` Simon Leinen
@ 2017-01-11 11:12 ` Alexander Kuleshov
2017-01-11 12:54 ` [PATCH v2] " Alexander Kuleshov
0 siblings, 1 reply; 7+ messages in thread
From: Alexander Kuleshov @ 2017-01-11 11:12 UTC (permalink / raw)
To: Simon Leinen; +Cc: emacs-devel
On Tue, Jan 10, 2017 at 7:48 PM, Simon Leinen <simon.leinen@gmail.com> wrote:
>> I've attached the patch which adds TLSA (RFC 6698) and NSEC3
>> (RFC 5155) to dns-mode-types.
>
> Cool, that looks correct and useful - we use both these record types,
> though NSEC3 records are usually in machine-generated include files.
>
> My only (cosmetic) suggestion for improvement would be to delete the
> space between "NSEC3" and the closing parenthesis.
>
>> Additioanlly these RFCs were added to comments and duplication
>> of NSAP was removed.
Yes, I will send suggested fixed in v2
Thanks
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2] emacs 26.0.50.1 - add DNS keywords and remove duplications
2017-01-11 11:12 ` Alexander Kuleshov
@ 2017-01-11 12:54 ` Alexander Kuleshov
2017-01-11 18:30 ` John Wiegley
0 siblings, 1 reply; 7+ messages in thread
From: Alexander Kuleshov @ 2017-01-11 12:54 UTC (permalink / raw)
To: emacs-devel
[-- Attachment #1: Type: text/plain, Size: 321 bytes --]
Hello everyone,
I've attached the patch v2 which adds TLSA (RFC 6698) and NSEC3
(RFC 5155) to dns-mode-types.
Additioanlly these RFCs were added to comments and duplication
of NSAP was removed.
Changes since v1:
* empty space removed before and the "NSEC3" closing parenthesis
suggested by Simon Leinen
Thank you.
[-- Attachment #2: 0001-Add-DNS-keywords-and-remove-duplications.patch --]
[-- Type: text/plain, Size: 1674 bytes --]
From a1f8f976a128b2fe8f6df9e3199c2bab4beb37c5 Mon Sep 17 00:00:00 2001
From: Alexander Kuleshov <kuleshovmail@gmail.com>
Date: Fri, 23 Dec 2016 16:53:41 +0600
Subject: [PATCH] Add DNS keywords and remove duplications
* lisp/textmodes/dns-mode.el (dns-mode-types): Add two TLSA and
NSEC" DNS related keywords and remove duplication of "NSAP".
---
lisp/textmodes/dns-mode.el | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/lisp/textmodes/dns-mode.el b/lisp/textmodes/dns-mode.el
index 521b1f3..d6f0b73 100644
--- a/lisp/textmodes/dns-mode.el
+++ b/lisp/textmodes/dns-mode.el
@@ -32,6 +32,9 @@
;; RFC 1034, "DOMAIN NAMES - CONCEPTS AND FACILITIES", P. Mockapetris.
;; RFC 1035, "DOMAIN NAMES - IMPLEMENTATION AND SPECIFICATION", P. Mockapetris.
+;; RFC 5155, "DNS Security (DNSSEC) Hashed Authenticated Denial of Existence"
+;; RFC 6698, "The DNS-Based Authentication of Named Entities (DANE)
+;; Transport Layer Security (TLS) Protocol: TLSA"
;;; Release history:
@@ -50,13 +53,13 @@ dns-mode-classes
(defconst dns-mode-types '("A" "NS" "MD" "MF" "CNAME" "SOA" "MB" "MG" "MR"
"NULL" "WKS" "PTR" "HINFO" "MINFO" "MX" "TXT"
- "RP" "AFSDB" "X25" "ISDN" "RT" "NSAP" "NSAP"
+ "RP" "AFSDB" "X25" "ISDN" "RT" "NSAP"
"SIG" "KEY" "PX" "GPOS" "AAAA" "LOC" "NXT"
"EID" "NIMLOC" "SRV" "ATMA" "NAPTR" "KX" "CERT"
"A6" "DNAME" "SINK" "OPT" "APL" "DS" "SSHFP"
"RRSIG" "NSEC" "DNSKEY" "UINFO" "UID" "GID"
"UNSPEC" "TKEY" "TSIG" "IXFR" "AXFR" "MAILB"
- "MAILA")
+ "MAILA" "TLSA" "NSEC3")
"List of strings with known DNS types.")
;; Font lock.
--
2.8.0.rc3.1353.gea9bdc0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v2] emacs 26.0.50.1 - add DNS keywords and remove duplications
2017-01-11 12:54 ` [PATCH v2] " Alexander Kuleshov
@ 2017-01-11 18:30 ` John Wiegley
2017-01-11 18:53 ` Eli Zaretskii
2017-01-11 19:16 ` Andreas Schwab
0 siblings, 2 replies; 7+ messages in thread
From: John Wiegley @ 2017-01-11 18:30 UTC (permalink / raw)
To: Alexander Kuleshov; +Cc: Eli Zaretskii, emacs-devel
>>>>> "AK" == Alexander Kuleshov <kuleshovmail@gmail.com> writes:
AK> I've attached the patch v2 which adds TLSA (RFC 6698) and NSEC3
AK> (RFC 5155) to dns-mode-types.
I've installed this, but due to a Git mishap (I'm new to "worktree"), it went
to the emacs-25 branch instead of master.
Eli, please revert if it shouldn't be on that branch.
--
John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] emacs 26.0.50.1 - add DNS keywords and remove duplications
2017-01-11 18:30 ` John Wiegley
@ 2017-01-11 18:53 ` Eli Zaretskii
2017-01-11 19:16 ` Andreas Schwab
1 sibling, 0 replies; 7+ messages in thread
From: Eli Zaretskii @ 2017-01-11 18:53 UTC (permalink / raw)
To: John Wiegley; +Cc: emacs-devel, kuleshovmail
> From: John Wiegley <jwiegley@gmail.com>
> Cc: emacs-devel <emacs-devel@gnu.org>, Eli Zaretskii <eliz@gnu.org>
> Date: Wed, 11 Jan 2017 10:30:48 -0800
>
> I've installed this, but due to a Git mishap (I'm new to "worktree"), it went
> to the emacs-25 branch instead of master.
>
> Eli, please revert if it shouldn't be on that branch.
Reverted.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] emacs 26.0.50.1 - add DNS keywords and remove duplications
2017-01-11 18:30 ` John Wiegley
2017-01-11 18:53 ` Eli Zaretskii
@ 2017-01-11 19:16 ` Andreas Schwab
1 sibling, 0 replies; 7+ messages in thread
From: Andreas Schwab @ 2017-01-11 19:16 UTC (permalink / raw)
To: Alexander Kuleshov; +Cc: Eli Zaretskii, emacs-devel
On Jan 11 2017, John Wiegley <jwiegley@gmail.com> wrote:
> I've installed this, but due to a Git mishap (I'm new to "worktree"), it went
> to the emacs-25 branch instead of master.
It is always a good idea to run git status -sb before pushing.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-01-11 19:16 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-06 7:51 emacs 26.0.50.1 - add DNS keywords and remove duplications Alexander Kuleshov
2017-01-10 13:48 ` Simon Leinen
2017-01-11 11:12 ` Alexander Kuleshov
2017-01-11 12:54 ` [PATCH v2] " Alexander Kuleshov
2017-01-11 18:30 ` John Wiegley
2017-01-11 18:53 ` Eli Zaretskii
2017-01-11 19:16 ` Andreas Schwab
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).