Re: master ed2b0bd: New faces in xref (bug#23179)

[Robert Pluim <rpluim@gmail.com>]

>>>>> On Tue, 16 Apr 2019 18:07:40 +0300, Eli Zaretskii <eliz@gnu.org> said:

    >> From: Robert Pluim <rpluim@gmail.com> Cc: emacs-devel@gnu.org
    >> Date: Tue, 16 Apr 2019 16:02:36 +0200
    >> 
    >> +@cindex compilation mode faces +@cindex compilation mode
    >> appearance +@vindex compilation-error-face +@vindex
    >> compilation-error +@vindex compilation-warning-face +@vindex
    >> compilation-warning

    Eli> It is generally not useful to have several index entries
    Eli> which start with the same text and point to the same place.
    Eli> So I would leave the odd-numbered entries above and delete
    Eli> the even-numbered.

I did it slightly differently. The name of the face is
'compilation-error', and 'compilation-error-face' holds the name of
the face to use. customize-face uses the former, so I left that one.

    >> + The appearance of the @file{*compilation*} buffer can be
    >> controlled +by customizing the faces which are used to
    >> highlight parts of the +@file{*compilation*} buffer,
    >> e.g. @code{compilation-error} or

    Eli> Either "e.g.,", or "e.g.@:", so that TeX doesn't by chance
    Eli> consider this end of sentence.

The former seems vastly preferred, so I went with it.

    Eli> Otherwise LGTM, thanks.

emacs-26, I imagine.

diff --git a/doc/emacs/building.texi b/doc/emacs/building.texi
index 78d07b8d39..518d157e4e 100644
--- a/doc/emacs/building.texi
+++ b/doc/emacs/building.texi
@@ -151,6 +151,20 @@ Compilation Mode
 the error message in a separate window.  The locus is the specific
 position in a file where that error occurred.
 
+@cindex compilation mode faces
+@vindex compilation-error
+@vindex compilation-warning
+  The appearance of the @file{*compilation*} buffer can be controlled
+by customizing the faces which are used to highlight parts of the
+@file{*compilation*} buffer, e.g., @code{compilation-error} or
+@code{compilation-warning}, for error and warning messages
+respectively.  Note that since those faces inherit from the
+@code{error} and @code{warning} faces, it is also possible to
+customize the parent face directly instead.
+
+  Use @w{@kbd{M-x customize-group RET compilation}} to see the entire
+list of customization variables and faces.
+
 @findex compile-goto-error
 @vindex compilation-auto-jump-to-first-error
   If you change the variable