unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Filipp Gunbin <fgunbin@fastmail.fm>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: Roland Winkler <winkler@gnu.org>, emacs-devel@gnu.org
Subject: Re: process-file instead of call-process in proced.el?
Date: Mon, 28 Mar 2022 22:42:37 +0300	[thread overview]
Message-ID: <m2h77hdfte.fsf@fastmail.fm> (raw)
In-Reply-To: <875ynyf2vi.fsf@gmx.de> (Michael Albinus's message of "Mon, 28 Mar 2022 18:39:13 +0200")

Hi,

On 28/03/2022 18:39 +0200, Michael Albinus wrote:

> Filipp Gunbin <fgunbin@fastmail.fm> writes:
>
>> Hi,
>
> Hi Filipp,
>
>>> Would be possible. However, I fail to understand which command you have
>>> in mind instead of "kill".
>>
>> Well, at least kill builtin in shell.  I don't know, I'd just prefer it
>> be customizable.  This is highly system-dependent, so it'd be more
>> future-proof.
>
> Tramp sends already the "kill builtin in shell". Could we just leave it
> as it is, and add connection-local behavior when requested by real use
> cases? We're still in Emacs master, years from being released.

I think yes..

>> Yeah, I see, the pid will be taken from localhost, but "kill" will be
>> sent to remote.  Can we for now just raise an error if we see that the
>> remote is not simple sudo/su/whatever?  Maybe later we'll be able to
>> implement "get remote process list".
>
> For now, we support only local pids, as Roland has explained. My patch
> does this, w/o the need to raise an error in case of a pilot error.
>
> If you are concerned about the prefix argument for "C-u k" and "C-u r"
> I'm open to another mean for an indication to proced, that root
> permissions are desired.
>
> And if we decide to support also remote pids being target of a signal,
> that would be another game. Nothing to prepare now, it would be a major
> change anyway.

I was suggesting a way to get rid of proced-remote-directory, which
looks a bit obscure for me.  You noted that it's easy to get unexpected
behavior (local pid but remote signal), then I suggested a way to handle
it (raise an error).  If you think proced-remote-directory is better -
let it be, I'm perfectly fine with it.

Thanks.



  reply	other threads:[~2022-03-28 19:42 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-25  0:09 process-file instead of call-process in proced.el? Filipp Gunbin
2022-03-25  6:54 ` Eli Zaretskii
2022-03-25 10:24   ` Filipp Gunbin
2022-03-25 10:31     ` Eli Zaretskii
2022-03-25 11:46       ` Michael Albinus
2022-03-25 12:12         ` Eli Zaretskii
2022-03-25 12:29           ` Filipp Gunbin
2022-03-25 13:34             ` Roland Winkler
2022-03-25 13:58             ` Michael Albinus
2022-03-25 14:26               ` Filipp Gunbin
2022-03-25 14:29                 ` Michael Albinus
2022-03-25 15:40                   ` Filipp Gunbin
2022-03-25 15:43                     ` Michael Albinus
2022-03-26 16:49 ` Michael Albinus
2022-03-26 17:37   ` Roland Winkler
2022-03-26 18:31     ` Michael Albinus
2022-03-26 18:49       ` Roland Winkler
2022-03-27  7:28         ` Michael Albinus
2022-03-27 14:08           ` Michael Albinus
2022-03-28  2:57             ` Roland Winkler
2022-03-28  7:41               ` Michael Albinus
2022-03-28 14:34                 ` Roland Winkler
2022-03-28 14:53             ` Filipp Gunbin
2022-03-28 15:40               ` Michael Albinus
2022-03-28 16:11                 ` Filipp Gunbin
2022-03-28 16:39                   ` Michael Albinus
2022-03-28 19:42                     ` Filipp Gunbin [this message]
2022-03-30 11:20                       ` Michael Albinus
2022-03-30 15:34                         ` Filipp Gunbin
2022-03-28 17:08             ` Jim Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2h77hdfte.fsf@fastmail.fm \
    --to=fgunbin@fastmail.fm \
    --cc=emacs-devel@gnu.org \
    --cc=michael.albinus@gmx.de \
    --cc=winkler@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).