From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: Merging scratch/no-purespace to remove unexec and purespace Date: Wed, 18 Dec 2024 17:30:22 +0100 Message-ID: References: <86seqmm9dq.fsf@gnu.org> <87jzbx9du1.fsf@protonmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23338"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Andrea Corallo , Eli Zaretskii , stefankangas@gmail.com, emacs-devel@gnu.org, monnier@iro.umontreal.ca To: Pip Cet Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 18 17:31:01 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tNwwv-0005sj-3f for ged-emacs-devel@m.gmane-mx.org; Wed, 18 Dec 2024 17:31:01 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tNwwZ-0007ln-4W; Wed, 18 Dec 2024 11:30:39 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tNwwR-0007d9-4O for emacs-devel@gnu.org; Wed, 18 Dec 2024 11:30:36 -0500 Original-Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tNwwO-0002Cv-7z; Wed, 18 Dec 2024 11:30:29 -0500 Original-Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-5d3f28881d6so8828181a12.1; Wed, 18 Dec 2024 08:30:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734539424; x=1735144224; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hboO1uOSkEXc1VxAGAN/Bh5hgEafJ30z3WHNXG8ZRf8=; b=CI+oNsF8CNsPxPg1DiZoWQtRSx9B+S+XCMFVVFKmbJfAioCHfO/P+WtGa4iYJnBYa9 u52+Hcv6SKCkHAenkoIUb9YmmNmF7WtGp0IWx3RzGTlE4/HnLrcI9FZxL/mWynuxe/1Q nNM5QlNREn41ezFjWb9BZnD0VREFtQh+glppRDi7jASUdyo+iaiXy0vOiJU78oRmu7H2 Fy48YEDDyTHi09DegyAM7bbvQSJQeLOduOQNOHHk2j4fOZ2zE22O1zEXBknG9vYE0hVk My9WjcetVyqMrxnEw6iTLy7gdBJzFpfU5p1m26ZVClS9QzbDqtMhYGnEwjX3jUs+wjjC Nexw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734539424; x=1735144224; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=hboO1uOSkEXc1VxAGAN/Bh5hgEafJ30z3WHNXG8ZRf8=; b=voWSK6u6nZxY1IPvmh5yOXQMiF2izHcHLCVXC39rXMGwI7KkAwZpau0t/1433U1x/f 6munpSU+HL/mx+s+kHCOlPiLGmtoZJZHhdUJIvK+tCWHQBzT97bXuOLvsWOm3YzM0uP2 Nx6Qx0CxgbEUyQAI+ZF4Bh7hS+CIPGW8lYaMWxeEUa25AzpMpg7h6z60tBnbtD74w4Eh I0+1Ptqgll+j1MV6VNsjDj4+7VlTLQ/Kjyx4nQ5/OLVbUiYVHI89+PcsEkUqriuLpvgT BTnDMF6TTbtl3H75KtSgn0sZwnOlRiZR473KJ9ZtUq3nez478bMvXmehCabZrF9u3mxL jRiw== X-Forwarded-Encrypted: i=1; AJvYcCVztAQqQ9mPIVUE5ARwp+CVMoEMtWB8svWB3GnjMi0VMnbtI5ANXMbGwKj+8wllM+o94lPVR8EOF8rtzp8=@gnu.org, AJvYcCWsrS5SZDTpAS3lcKgWKUXTXONS1Nh5XQjbuYnR1PegZ67Zyy2PhZmMgLRab1IzIqZ7kU7X@gnu.org X-Gm-Message-State: AOJu0Ywh1wmhz9+w4s4dR015RBeVHEqz+LfSjaVRVAN5AqHXN1upMe7x yr9dCc2LNFORPpV//SU/5SLr4JtNtapu3ItMSZ9lH3kP4IVmxMwF X-Gm-Gg: ASbGncvhsP0YhIrSBLvhSdU7NLT5NAfZoUAO9r2telMFcjmBoImaIiwqmuzqoxP/S1h Qs4R/H0RJnSf2k8R6mzoMDw0vM47KMgjajeXdWy3tocehsvoE5vo8HYyJc3LYc34AljCiDBmlmG fzDqTu52ht9XWM6JFIB8G6kmfwGuTawtNCCVtAWx9bgw8d1DNQnz4di1oOYGs5ehiuvTBzB9soV cbzmX1v7FVyShsuUvvx1cS3wprk1RH+sPW0RgSIktmk+Mns6SaGujIvCqJ3fWPHS3Ubbb9hqSZZ QroSUq7/wotYlbiFgbFmY2WcUk625/uEcXTVdNyh2MPUYp21ozzpvNZ5Myk0F0RZkQ== X-Google-Smtp-Source: AGHT+IH8WZUeVmN1CJYlo1VpFG8FyMYMUoydgIpnmMGQAYNJk3UxXJiXCan7jzUH9DfqRKYLQCa4Zg== X-Received: by 2002:a05:6402:4403:b0:5d3:ba42:e9e3 with SMTP id 4fb4d7f45d1cf-5d7ee390c89mr8655525a12.13.1734539424169; Wed, 18 Dec 2024 08:30:24 -0800 (PST) Original-Received: from pro2 (p200300e0b7267000f86be09dcd4cd505.dip0.t-ipconnect.de. [2003:e0:b726:7000:f86b:e09d:cd4c:d505]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d652ad19ffsm5526228a12.24.2024.12.18.08.30.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Dec 2024 08:30:23 -0800 (PST) In-Reply-To: <87jzbx9du1.fsf@protonmail.com> (Pip Cet's message of "Wed, 18 Dec 2024 16:05:59 +0000") Received-SPF: pass client-ip=2a00:1450:4864:20::535; envelope-from=gerd.moellmann@gmail.com; helo=mail-ed1-x535.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326665 Archived-At: Pip Cet writes: > Gerd M=C3=B6llmann writes: > >> Andrea Corallo writes: >> >>> Gerd M=C3=B6llmann writes: >>> >>>> Eli Zaretskii writes: >>>> >>>>>> From: Gerd M=C3=B6llmann >>>>>> Cc: emacs-devel@gnu.org, Pip Cet , Stefan M= onnier >>>>>> >>>>>> Date: Tue, 17 Dec 2024 18:56:05 +0100 >>>>>> >>>>>> Gerd M=C3=B6llmann writes: >>>>>> >>>>>> > Gerd M=C3=B6llmann writes: >>>>>> > >>>>>> >> I think check_comp_unit_relocs should be removed in the branch. W= hat's >>>>>> >> left of it the branch, checks in master if everything has been >>>>>> >> put in purespace which should be there. IIUC correctly, of course. >>>>>> > >>>>>> > Patch attached. >>>>>> >>>>>> Pushed. Complaints to me please. >>>>> >>>>> I'd like at least Andrea to take a look and confirm. >>>> >>>> It's 81fc23b5d6a60ca4f3d269ab2c88eb9a850bac4c >>> >>> Hi Gerd, >>> >>> looking at the commit now, why do you think 'check_comp_unit_relocs' >>> should be removed? >>> >>> Even if now the situation is simpler 'check_comp_unit_relocs' is still >>> performing some sanity checks like if lambdas are all been fixed-up and >>> present in 'comp_u->lambda_gc_guard_h'. >>> >>> Andrea >> >> Hi Andrea. >> >> The check you mention checks something that I don't see how it could >> happen. (With the usual disclaimers, because it's been some time since I >> was in that code for igc.) > > I'm confused, I thought you did hit the assertion? Correct, building with --enable-checking failed. What confuses?