From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Andrew Choi Newsgroups: gmane.emacs.devel Subject: Re: Status of MAC/W32/X consolidation and some questions. Date: Mon, 10 Mar 2003 10:09:13 -0700 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <5xadg38lnj.fsf@kfs2.cua.dk> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7BIT X-Trace: main.gmane.org 1047317223 24718 80.91.224.249 (10 Mar 2003 17:27:03 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Mon, 10 Mar 2003 17:27:03 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Mon Mar 10 18:27:01 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18sR3F-0006QF-00 for ; Mon, 10 Mar 2003 18:27:01 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18sRPb-0004y8-00 for ; Mon, 10 Mar 2003 18:50:07 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18sR1m-0001r6-04 for emacs-devel@quimby.gnus.org; Mon, 10 Mar 2003 12:25:30 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18sQwh-0000mi-00 for emacs-devel@gnu.org; Mon, 10 Mar 2003 12:20:15 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18sQrZ-0007cL-00 for emacs-devel@gnu.org; Mon, 10 Mar 2003 12:14:58 -0500 Original-Received: from shawidc-mo1.cg.shawcable.net ([24.71.223.10] helo=pd6mo2so.prod.shaw.ca) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18sQnL-00060D-00 for emacs-devel@gnu.org; Mon, 10 Mar 2003 12:10:35 -0500 Original-Received: from pd5mr1so.prod.shaw.ca (pd5mr1so-qfe3.prod.shaw.ca [10.0.141.232]) by l-daemon (iPlanet Messaging Server 5.1 HotFix 0.8 (built May 12 2002)) with ESMTP id <0HBJ00E0AMBF6L@l-daemon> for emacs-devel@gnu.org; Mon, 10 Mar 2003 10:09:15 -0700 (MST) Original-Received: from pn2ml6so.prod.shaw.ca (pn2ml6so-qfe0.prod.shaw.ca [10.0.121.150]) by l-daemon (iPlanet Messaging Server 5.1 HotFix 0.8 (built May 12 2002)) with ESMTP id <0HBJ009REMBFZ5@l-daemon> for emacs-devel@gnu.org; Mon, 10 Mar 2003 10:09:15 -0700 (MST) Original-Received: from owlbear.local.shawmail (h68-144-207-94.cg.shawcable.net [68.144.207.94]) by l-daemon (iPlanet Messaging Server 5.1 HotFix 0.8 (built May 12 2002)) with ESMTP id <0HBJ00K0LMBEII@l-daemon> for emacs-devel@gnu.org; Mon, 10 Mar 2003 10:09:15 -0700 (MST) In-reply-to: <5xadg38lnj.fsf@kfs2.cua.dk> Original-To: storm@cua.dk (Kim F. Storm) User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 Original-Lines: 14 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:12242 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:12242 storm@cua.dk (Kim F. Storm) writes: > [...] > > Also on MAC, there are quite a number of TODO items, meaning that some > section of more-or-less unmodified X or W32 code is commented out with > #if 0... #endif. In the cases where the code is to be "consolidated", > I would prefer to leave a TODO note in the mac* file and simply delete > the code from the file. Then in the consolidated code file, I will > put a #ifndef MAC_OS around the consolidated code to indicate that it > is not used on MAC_OS (yet). Is that an acceptable approach? Please consider using HAVE_CARBON instead of MAC_OS: some people compile Emacs to run under X Window on Mac OS X.