From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: John Wiegley Newsgroups: gmane.emacs.devel Subject: Re: Bound index checks in cl-seq functions Date: Fri, 14 Apr 2017 15:01:01 -0700 Message-ID: References: <87efzdrjsj.fsf@calancha-pc> <87inoisd6y.fsf@calancha-pc> <87r32f7yq6.fsf_-_@calancha-pc> <83zih2lb65.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1492207294 14364 195.159.176.226 (14 Apr 2017 22:01:34 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 14 Apr 2017 22:01:34 +0000 (UTC) User-Agent: Gnus/5.130016 (Ma Gnus v0.16) Emacs/25.2 (darwin) Cc: emacs-devel@gnu.org, Tino Calancha To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 15 00:01:29 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cz9HT-0003aI-TG for ged-emacs-devel@m.gmane.org; Sat, 15 Apr 2017 00:01:28 +0200 Original-Received: from localhost ([::1]:54764 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cz9HZ-0006im-Tl for ged-emacs-devel@m.gmane.org; Fri, 14 Apr 2017 18:01:33 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46047) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cz9H0-0006ie-C4 for emacs-devel@gnu.org; Fri, 14 Apr 2017 18:00:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cz9Gz-0005Y5-Bk for emacs-devel@gnu.org; Fri, 14 Apr 2017 18:00:58 -0400 Original-Received: from mail-pf0-x22d.google.com ([2607:f8b0:400e:c00::22d]:33478) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cz9Gu-0005Sj-PN; Fri, 14 Apr 2017 18:00:52 -0400 Original-Received: by mail-pf0-x22d.google.com with SMTP id s16so44942588pfs.0; Fri, 14 Apr 2017 15:00:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:date:message-id:references :user-agent:mail-followup-to:mime-version; bh=HlJstWE+FYg8hH9I+V9Epa93xMxjXcM9NDVd7v/HOWM=; b=NwNTRpj/qxUdZO58PjiOJFs5yp02dSXcmQI+uzouRC/4qP6bqKH4Mt40PBf50eVGYK OCHCCo7Gm2eM+i1gmqc0GfY9m0RKREBtMpNgt5sYwd8rt7jJ+fCOFHIeor+sEhGe5PgW 2whbuFVZQryke3k+We4gppLqG0utaWejn8343HGiKhpdYkASoaeEVUh3HqyOL778vgEH 2eUmTUAlv39pQ7d3ehkUwa9Qzec5bTdkEbIH1+n1ttGYRJbJzIqOr7EHQtSxEdFX4qn5 cqmOYTha5rq8KfMRRsrtBbuwzuYEzpirQ4L50kwLKyb38GW69Sy7n6kgFDJKx4GDBBsY PMpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:date:message-id :references:user-agent:mail-followup-to:mime-version; bh=HlJstWE+FYg8hH9I+V9Epa93xMxjXcM9NDVd7v/HOWM=; b=siOAztKIOEZP6bz8Rn3x3hIuy8Ps2rhQxX5zSK4g/v3ce1uTzps5XF/b+2A6dx4r5Y SobstBo9YoIe5kjSapgx2cKi/fwrm+OAXnfKm6rdxL1aWcp3jIu98lUa1WVT0sRQMs9w gzuwkH80oEtOdw6JPRr0FgWbUnjQs0AXMPLJ1EnWHwklkguqw3AEaUBDQhaUJc+5mfLa xJCpSQCoJl4OPgg1uJVxPKGSRZ7zuYD3KjGXz2scVwjd97FZvdC/GZcb/wGkeE1qCFvH prZxxax2nDh7RzMuWFxfYfkyClrWDQBFlnJBOlbHj+JdN1M1OqgI8IsVDw+HKQlHIliu O/wA== X-Gm-Message-State: AN3rC/5rtrHyGtXXlbOPDkQMMbGtSmhRuem8ZCRsyfvnXLJ0dI5Sx325 qDaup4inAcneG657itY= X-Received: by 10.84.138.193 with SMTP id 59mr11458477plp.167.1492207251555; Fri, 14 Apr 2017 15:00:51 -0700 (PDT) Original-Received: from Vulcan.local (76-234-69-149.lightspeed.frokca.sbcglobal.net. [76.234.69.149]) by smtp.gmail.com with ESMTPSA id u22sm4905118pgo.67.2017.04.14.15.00.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Apr 2017 15:00:50 -0700 (PDT) X-Google-Original-From: "John Wiegley" Original-Received: by Vulcan.local (Postfix, from userid 501) id 7D5FD3A74BD9; Fri, 14 Apr 2017 15:01:04 -0700 (PDT) In-Reply-To: <83zih2lb65.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 03 Mar 2017 15:52:50 +0200") Mail-Followup-To: Eli Zaretskii , Tino Calancha , emacs-devel@gnu.org X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c00::22d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:213965 Archived-At: >>>>> Eli Zaretskii writes: >> i am curious if you have any opinion on this thread. Currently just >> `cl-subseq' performs the bounding check index. I don't see a >> clear reason why just this function do it. >> Are you in favour or against doing those checks in other functions >> handling sequences? > I don't have any firm opinions on this. I do note, however, that your > motivation for signaling an error was contested. So I wonder whether the > cause for this is strong enough to make that change. But I'm willing to > defer to people who use these features more than I do. I also don't have a strong opinion. Bounds checking is usually helpful, if it would help those who are using these functions. Otherwise, I wouldn't make the change "just to make the change", even though it sounds like a good idea. -- John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2