From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: Identifying the face between STRETCH and right fringe. Date: Tue, 27 Nov 2018 09:56:36 +0100 Message-ID: References: <83h8gbis2d.fsf@gnu.org> <83zhu0f6tt.fsf@gnu.org> <83sgzrgb1f.fsf@gnu.org> <83r2fbg5bq.fsf@gnu.org> <83lg5jfs9o.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1543308925 6349 195.159.176.226 (27 Nov 2018 08:55:25 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 27 Nov 2018 08:55:25 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 27 09:55:20 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gRZ9L-0001Y4-T1 for ged-emacs-devel@m.gmane.org; Tue, 27 Nov 2018 09:55:20 +0100 Original-Received: from localhost ([::1]:40737 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRZBR-0003hM-Tr for ged-emacs-devel@m.gmane.org; Tue, 27 Nov 2018 03:57:29 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36817) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRZAk-0003h9-8c for emacs-devel@gnu.org; Tue, 27 Nov 2018 03:56:47 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRZAf-0001OV-AU for emacs-devel@gnu.org; Tue, 27 Nov 2018 03:56:46 -0500 Original-Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]:34046) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gRZAf-0001NX-2R; Tue, 27 Nov 2018 03:56:41 -0500 Original-Received: by mail-wr1-x429.google.com with SMTP id j2so21793470wrw.1; Tue, 27 Nov 2018 00:56:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-followup-to:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=n8X60iWSYdfBuNTuV898Q1FEEz8OGuiqn1bXBoZ/31c=; b=VA7M8kxbAC1X/4hK4IVi2EJTbK0WZEYU67PHCOkpO/L4ww1/hSi7n/5AKp0qZ4IaxC DdKveJM2LbHbWsaL2hE5iWP3N9eUMKGae0JxQxJiebRZpM74BXOudkWZpeSsNjzQyNFI 4r9TuX1o5Fj3aIXYYVZ/Hj1JJiD8ONQUwfl7AFBuHXf5Qelx0g/sw6YQ2C20/Tjoq0kj DOykqsoBxkpJferkcz8NXs9pHu7nMM0b1uZs1bFzODIKzZPuzSZJiZjjP6HhkzRbypJY EUL7mOefa+6zCVuTnaZNI8u1j0OTb1T/S5cJ46wwIPh2/kD0Y2Gli7cWq6jwWPIWLh/m H+EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-followup-to :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=n8X60iWSYdfBuNTuV898Q1FEEz8OGuiqn1bXBoZ/31c=; b=NXeTsxoypDOfnjyCCgUbyyV+pUmMdQ//UVKLi6HM6t74xqGfQR5VFr+OFyYLBK0zj9 ciSWfmU5Qn84BF+//y8W29wOTxGNAf0jlqtSl89WhC30iOaCoFIiFrnse5GjFYE/1gku FRAtNPoerSHUtcbzLxNU+uOC2zrqy5w3ovbTlvfLM3CZpfNjZPK0HFCfvVMp/tKM8pOX Lm2hRJashrIX7D9FUkm1Vwx/ynqXzz1e/MYDJ7eZvX6l/evA899vxiSTGJREKgK40bAA WBVnpAXtdCGCvxtaLeRXGs53IWKIVgp1QNOT79Iu375Ht65DMy6XVIVn45NsJCkgaDmF OZNw== X-Gm-Message-State: AA+aEWYb4S9fpC67O/FkMa+yCq/tMxu3dR2XeQmfcrBU2GIQv1bY9Ok8 Mn5v8RWhj6Pknac3s6IJgrTUUuuN X-Google-Smtp-Source: AFSGD/VPJORzoJhqj0DnEeQ90O4yH3BykRhkXnVEzvLzUIsX4bQjJLnrSVlrZZs/JebfainZVuaGzw== X-Received: by 2002:a5d:5607:: with SMTP id l7mr27077927wrv.25.1543308998855; Tue, 27 Nov 2018 00:56:38 -0800 (PST) Original-Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id e19sm6059232wrc.25.2018.11.27.00.56.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 27 Nov 2018 00:56:37 -0800 (PST) Mail-Followup-To: emacs-devel@gnu.org Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: <83lg5jfs9o.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 23 Nov 2018 22:33:39 +0200") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::429 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231437 Archived-At: Eli Zaretskii writes: >> From: Robert Pluim >> Date: Fri, 23 Nov 2018 16:58:41 +0100 >> Cc: emacs-devel@gnu.org >>=20 >> > Ah, okay. Then we agree: there's some bug on NS that causes the face >> > to be extended. The expected behavior is the one we see on X and on >> > Windows (and also on TTY frames). >>=20 >> Any idea where the code that handles this is? I took a quick look at >> HAVE_NS, but nothing jumped out at me. > > I didn't see something like that, either. But it could be the other > way around: that NS needs some code to prevent that from happening. > > I think the place to look is ns_maybe_dumpglyphs_background: what is > the width of the rectangle that it clears with the background color of > the face? It=CA=BCs ns_dumpglyphs_stretch, which is doing exactly as it=CA=BCs told: drawing the background to the right edge of the frame. That=CA=BCs because in xdisp.c:display_line we have: /* Make sure that a non-default face is extended up to the right margin of the window. */ extend_face_to_end_of_line (it); which later causes set_glyph_string_background_width to set the background_width of the glyph to the full width (commenting out that call makes NS work the same as X11 for this specific case). What I don=CA=BCt understand is that under X11 Emacs takes exactly the same code path, yet somehow it doesn=CA=BCt end up setting the background up to the right edge. Robert