unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Identifying the face between STRETCH and right fringe.
Date: Tue, 27 Nov 2018 09:56:36 +0100	[thread overview]
Message-ID: <m2ftvmuce3.fsf@gmail.com> (raw)
In-Reply-To: <83lg5jfs9o.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 23 Nov 2018 22:33:39 +0200")

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Robert Pluim <rpluim@gmail.com>
>> Date: Fri, 23 Nov 2018 16:58:41 +0100
>> Cc: emacs-devel@gnu.org
>> 
>> > Ah, okay.  Then we agree: there's some bug on NS that causes the face
>> > to be extended.  The expected behavior is the one we see on X and on
>> > Windows (and also on TTY frames).
>> 
>> Any idea where the code that handles this is? I took a quick look at
>> HAVE_NS, but nothing jumped out at me.
>
> I didn't see something like that, either.  But it could be the other
> way around: that NS needs some code to prevent that from happening.
>
> I think the place to look is ns_maybe_dumpglyphs_background: what is
> the width of the rectangle that it clears with the background color of
> the face?

Itʼs ns_dumpglyphs_stretch, which is doing exactly as itʼs told:
drawing the background to the right edge of the frame. Thatʼs because
in xdisp.c:display_line we have:

		      /* Make sure that a non-default face is extended
			 up to the right margin of the window.  */
                      extend_face_to_end_of_line (it);

which later causes set_glyph_string_background_width to set the
background_width of the glyph to the full width (commenting out that
call makes NS work the same as X11 for this specific case).

What I donʼt understand is that under X11 Emacs takes exactly the same
code path, yet somehow it doesnʼt end up setting the background up to
the right edge.

Robert



  reply	other threads:[~2018-11-27  8:56 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-20 16:39 Identifying the face between STRETCH and right fringe Keith David Bershatsky
2018-11-20 17:20 ` Eli Zaretskii
2018-11-21  7:44   ` Robert Pluim
2018-11-23 10:04     ` Eli Zaretskii
2018-11-23 13:25       ` Robert Pluim
2018-11-23 13:48         ` Eli Zaretskii
2018-11-23 14:04           ` Robert Pluim
2018-11-23 15:51             ` Eli Zaretskii
2018-11-23 15:58               ` Robert Pluim
2018-11-23 20:33                 ` Eli Zaretskii
2018-11-27  8:56                   ` Robert Pluim [this message]
2018-11-27  9:34                     ` Eli Zaretskii
2018-11-27 11:02                       ` Robert Pluim
2018-11-27 11:29                         ` Eli Zaretskii
2018-11-27 13:55                           ` Robert Pluim
2018-11-27 18:55                             ` Eli Zaretskii
2018-11-27 19:14                               ` Robert Pluim
2018-11-27 19:38                                 ` Robert Pluim
2018-11-28  6:03                                   ` Eli Zaretskii
2018-11-28  9:00                                     ` Robert Pluim
2018-11-28  9:42                                       ` Eli Zaretskii
2018-11-28  9:49                                         ` Eli Zaretskii
2018-11-28 13:24                                           ` Robert Pluim
2018-11-28 16:19                                             ` Eli Zaretskii
2018-11-28  7:13                                 ` Eli Zaretskii
2018-11-28  8:36                                   ` Robert Pluim
2018-11-28  9:45                                     ` Eli Zaretskii
2018-11-28  9:56                                       ` Robert Pluim
2018-11-28 10:11                                         ` Eli Zaretskii
2018-11-28 13:21                                           ` Robert Pluim
2018-11-28 16:20                                             ` Eli Zaretskii
2018-11-29 12:51                                               ` Robert Pluim
2018-11-29 14:15                                                 ` Eli Zaretskii
2018-11-28 21:14                                   ` Alan Third
2018-11-29 12:26                                     ` Robert Pluim
2018-11-29 12:54                                       ` Eli Zaretskii
2018-11-29 13:52                                         ` Robert Pluim
2018-11-29 14:08                                           ` Eli Zaretskii
2018-11-30  7:59                                             ` Robert Pluim
2018-11-30  8:04                                             ` Robert Pluim
2018-11-30  8:22                                               ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2ftvmuce3.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).