unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: emacs-26 8f18d12: Improve documentation of decoding into a unibyte buffer
Date: Mon, 27 May 2019 15:49:50 +0200	[thread overview]
Message-ID: <m2ftp09fcx.fsf@gmail.com> (raw)
In-Reply-To: <jwva7f8owp7.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Mon, 27 May 2019 09:32:11 -0400")

>>>>> On Mon, 27 May 2019 09:32:11 -0400, Stefan Monnier <monnier@iro.umontreal.ca> said:
    >> If I take a string of say "β", and replace string-as-unibyte with
    >> (encode-coding-string 'emacs-internal), `encoded-string-description'
    >> prints "#xCE #xB2", which is the correct UTF-8 encoded
    >> value. 'raw-text works too. Iʼm certain that there are subtle
    >> differences between the two that I donʼt understand.

    Stefan> But "β" is not a "STR that is encoded by CODING-SYSTEM", so this output
    Stefan> is neither correct nor incorrect in any case.

It matches the current output of encoded-string-description, though.

    Stefan> I think the right thing to do here is one of:
    Stefan> - signal an error if `str` is multibyte.
    Stefan> - signal an error if `str` is multibyte and contains non-byte chars.
    Stefan> - if multibyte, encode `str` with `coding-system`.
    Stefan> - just don't bother looking at whether `str` is unibyte or not, just
    Stefan>   pass it as is to `mapconcat`.
    Stefan> - just don't bother looking at whether `str` is unibyte or not, just
    Stefan>   pass it as is to `mapconcat` but in the lambda, do catch the case
    Stefan>   where `x` is an "eight bit raw-byte char" and if so pass it to
    Stefan>   multibyte-char-to-unibyte.
    Stefan> - ...

Since this is the underlying code that displays the 'buffer code'
section of 'C-u C-x =', I donʼt think barfing on multibyte is the
right thing to do. Nor is passing it on as is.

    Stefan> But encoding `str` with any coding system like raw-text or
    Stefan> emacs-internal doesn't seem to make much sense.

Then what is the correct way to say 'give me the raw byte version
of this character'? (or maybe we should just let sleeping encodings
lie :-) )

Robert



  reply	other threads:[~2019-05-27 13:49 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190525191039.14136.23307@vcs0.savannah.gnu.org>
     [not found] ` <20190525191040.CCD6C207F5@vcs0.savannah.gnu.org>
2019-05-25 19:41   ` [Emacs-diffs] emacs-26 8f18d12: Improve documentation of decoding into a unibyte buffer Stefan Monnier
2019-05-25 19:59     ` Eli Zaretskii
2019-05-25 20:15       ` Eli Zaretskii
2019-05-25 21:11       ` Stefan Monnier
2019-05-25 21:27         ` Stefan Monnier
2019-05-26  2:37         ` Eli Zaretskii
2019-05-27  9:47   ` Robert Pluim
2019-05-27 12:24     ` Stefan Monnier
2019-05-27 13:02       ` Robert Pluim
2019-05-27 13:32         ` Stefan Monnier
2019-05-27 13:49           ` Robert Pluim [this message]
2019-05-27 16:53             ` Eli Zaretskii
2019-05-28  6:23               ` Robert Pluim
2019-05-28 14:57                 ` Eli Zaretskii
2019-05-28  3:08             ` Stefan Monnier
2019-05-28  4:40               ` Eli Zaretskii
2019-05-28 11:55                 ` Stefan Monnier
2019-05-28 15:18                   ` Eli Zaretskii
2019-05-28 17:43                     ` Stefan Monnier
2019-05-28 18:58                       ` Eli Zaretskii
2019-05-28 19:35                         ` Eli Zaretskii
2019-05-28 23:44                         ` Stefan Monnier
2019-05-29 14:33                           ` Eli Zaretskii
2019-05-27 16:51           ` Eli Zaretskii
2019-05-27 19:17             ` Stefan Monnier
2019-05-28  2:30               ` Eli Zaretskii
2019-05-28  2:56                 ` Stefan Monnier
2019-05-28  4:17                   ` Eli Zaretskii
2019-05-28  6:21                     ` Robert Pluim
2019-05-28 11:53                       ` Stefan Monnier
2019-05-28 11:54                     ` Stefan Monnier
2019-05-28 15:11                       ` Eli Zaretskii
2019-05-28 17:25                         ` Stefan Monnier
2019-05-28 18:51                           ` Eli Zaretskii
2019-05-28 23:39                             ` Stefan Monnier
2019-05-29  2:45                               ` Eli Zaretskii
2019-05-29 16:28                                 ` Stefan Monnier
2019-05-29 18:19                                   ` Eli Zaretskii
2019-05-29 18:58                                     ` Stefan Monnier
2019-05-29 19:09                                       ` Eli Zaretskii
2019-05-29 19:50                                         ` Stefan Monnier
2019-05-27 16:43         ` Eli Zaretskii
2019-05-27 16:42       ` Eli Zaretskii
2019-05-27 19:13         ` Stefan Monnier
2019-05-27 16:40     ` Eli Zaretskii
2019-05-27 20:17       ` Richard Stallman
2019-05-28  2:36         ` Eli Zaretskii
2019-05-28  7:06           ` Robert Pluim
2019-05-28 14:59             ` Eli Zaretskii
2019-05-28 15:11               ` Robert Pluim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2ftp09fcx.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).