Re: master 6216c7a: Allow specifying that SMTP auth should always be used

Re: master 6216c7a: Allow specifying that SMTP auth should always be used

[Robert Pluim]

>>>>> On Fri, 26 Jul 2019 06:16:59 -0400 (EDT), larsi@gnus.org (Lars Ingebrigtsen) said:

    Larsi> branch: master
    Larsi> commit 6216c7abd4cefd6245d29272d899490045cfdeff
    Larsi> Author: Lars Ingebrigtsen <larsi@gnus.org>
    Larsi> Commit: Lars Ingebrigtsen <larsi@gnus.org>

    Larsi>     Allow specifying that SMTP auth should always be used
    
    Larsi>     * doc/misc/smtpmail.texi (Authentication): Document it.
    
    Larsi>     * lisp/mail/smtpmail.el
    Larsi>     (smtpmail-servers-requiring-authorization): New variable (bug#26359).
    Larsi>     (smtpmail-via-smtp): Use it.

If the user can customize smtpmail-servers-requiring-authorization,
then they can also add an appropriate entry to .authinfo to make
smtpmail do authentication, so why is such a variable needed?

Robert

Re: master 6216c7a: Allow specifying that SMTP auth should always be used

[Lars Ingebrigtsen]

Robert Pluim <rpluim@gmail.com> writes:

> If the user can customize smtpmail-servers-requiring-authorization,
> then they can also add an appropriate entry to .authinfo to make
> smtpmail do authentication, so why is such a variable needed?

smtpmail always tries first without auth, and then starts looking around
for credentials if the SMTP servers says "give me credentials".

We could make it start sending credentials immediately if there's an
.authinfo entry, but that'd be a behaviour change, and the user may have
specified just "machine my.mail.host" for (for instance) IMAP usage, and
there's no auth on SMTP, in which case the SMTP server may deny the
connection.

And besides, the user may be typing in the credentials and not using
.authinfo.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master 6216c7a: Allow specifying that SMTP auth should always be used

[Robert Pluim]

>>>>> On Fri, 26 Jul 2019 14:07:18 +0200, Lars Ingebrigtsen <larsi@gnus.org> said:

    Larsi> Robert Pluim <rpluim@gmail.com> writes:
    >> If the user can customize smtpmail-servers-requiring-authorization,
    >> then they can also add an appropriate entry to .authinfo to make
    >> smtpmail do authentication, so why is such a variable needed?

    Larsi> smtpmail always tries first without auth, and then starts looking around
    Larsi> for credentials if the SMTP servers says "give me credentials".

I was convinced thatʼs not how it worked, but the code disagrees with
me.

    Larsi> We could make it start sending credentials immediately if there's an
    Larsi> .authinfo entry, but that'd be a behaviour change, and the user may have
    Larsi> specified just "machine my.mail.host" for (for instance) IMAP usage, and
    Larsi> there's no auth on SMTP, in which case the SMTP server may deny the
    Larsi> connection.

And again I was convinced we did port matching, but again thatʼs not
how auth-source works when the machine entry doesnʼt have a port.

    Larsi> And besides, the user may be typing in the credentials and not using
    Larsi> .authinfo.

I appear to be 0 for 3 here. Oh well.

Robert

Re: master 6216c7a: Allow specifying that SMTP auth should always be used

[Stefan Monnier]

> And besides, the user may be typing in the credentials and not using
> .authinfo.

Guilty as charged!


        Stefan