From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: master fe939b3 1/2: Fix reference to `tags-loop-continue' in doc string Date: Sun, 04 Aug 2019 14:03:24 +0200 Message-ID: References: <20190801195403.16246.49802@vcs0.savannah.gnu.org> <20190801195406.087AF20CC8@vcs0.savannah.gnu.org> <87ef23allc.fsf@mouse.gnus.org> <877e7vpgmt.fsf@mouse.gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="180140"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Aug 04 14:03:51 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1huFEt-000kn1-1N for ged-emacs-devel@m.gmane.org; Sun, 04 Aug 2019 14:03:51 +0200 Original-Received: from localhost ([::1]:44240 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1huFEs-0006Eu-3y for ged-emacs-devel@m.gmane.org; Sun, 04 Aug 2019 08:03:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40942) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1huFEa-0006Em-3E for emacs-devel@gnu.org; Sun, 04 Aug 2019 08:03:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1huFEZ-0000GO-2X for emacs-devel@gnu.org; Sun, 04 Aug 2019 08:03:32 -0400 Original-Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:35425) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1huFEY-0000Fw-Pz for emacs-devel@gnu.org; Sun, 04 Aug 2019 08:03:31 -0400 Original-Received: by mail-wr1-x436.google.com with SMTP id y4so81640705wrm.2 for ; Sun, 04 Aug 2019 05:03:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-copies-to:gmane-reply-to-list :date:in-reply-to:message-id:mime-version:content-transfer-encoding; bh=WAPEsTJw2BvFIc8l3CwIKNFdX7EvJMwkWoG96jAjgbo=; b=kwJjzLjrmo/aYTKQIhb9CuH24htm2zL38YRQl8gA9A00QkKuvYxZuUIk2jfMP7pqWX x7Lbx+uXgAiv6HZRWlBLZAsqOrkr6Cvmx2SNm2tYFZDzuBAePPnzmst39+0YUf693cUy fVvgQl8xoDgl0eBQTnaINHkrg/CtJrntKJR3dWTUHSqNR4L2WuPBANHGojyOaICykn+0 z63PIKB4ZSElGfYU6AcaOddsnW+x85hGeKULPjQEIY5CQaYYF1OQULL+wtYenwbpZWkV z8cuZuOb8OTGthlXxOvL3Cm9fOD/Ndkhzxxm+5s+U0Dztbp+y94hf1eQ/VNxiUjq2chU oWnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=WAPEsTJw2BvFIc8l3CwIKNFdX7EvJMwkWoG96jAjgbo=; b=sm9nZOtpqYrJHfOSFik+RitZqluocF5JJ8Y4I9Y+a5HVKASikEC5Yj5FNjKl1PxXb9 NkdL6fFrfMUBlzUc/JiP0co2ooZwdfpJyzGgzuzISXLfyJPs1Q9QhuqJ+vwuGeTk8oSq l4yLvQO/S1OVKr+/cwtI5Mb4iBqFV8FRmP+FiwhalGrpio6Zuks33pFQp+tKvDON9vKb XkIRLHaU6gzppDJWiptqtdVi+vPLr6tvMmF55tjPuWIbcp6H3hkgZBk1mAkqe4+40pdT E91KSw87Uw1b4EmDrQm+cd5LPc2bvQ6F/RHAwoxG/mjde4FyIhfMqTSP4rluWALrykzH OPng== X-Gm-Message-State: APjAAAVt1X8pA5mEzxxpNk+CG+5o+Diu2EEtEvenNkJa9yf/Fy4uz/XM m9da24FsIOLpuCrswA4pXeqL98c6 X-Google-Smtp-Source: APXvYqyj0/D1k9XjDTdRSLp+GpAe7PuIC8Y+/sdadHAYiMwLsMsyOAj1HcuiYjsy66cty3jEQKaoAA== X-Received: by 2002:a5d:6284:: with SMTP id k4mr21318799wru.179.1564920208661; Sun, 04 Aug 2019 05:03:28 -0700 (PDT) Original-Received: from rpluim-mac ([2a01:e34:ecfc:a860:e50b:7c59:b4ea:4a3d]) by smtp.gmail.com with ESMTPSA id z7sm78913036wrh.67.2019.08.04.05.03.26 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sun, 04 Aug 2019 05:03:27 -0700 (PDT) Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: <877e7vpgmt.fsf@mouse.gnus.org> (Lars Ingebrigtsen's message of "Fri, 02 Aug 2019 20:27:22 +0200") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::436 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239162 Archived-At: >>>>> On Fri, 02 Aug 2019 20:27:22 +0200, Lars Ingebrigtsen said: Lars> Robert Pluim writes: >> Ah, you mean like this? I hope I have the eval-when-compile stuff >> right. And if you do 'dired-do-search' followed by >> 'xref-find-definitions' it would be easy to confuse yourself. >>=20 >> We could find a new binding for fileloop-continue, which also breaks >> backwards compatibility, but then at least there=CA=BCs a default bi= nding. Lars> [...] >> +(eval-when-compile (declare-function fileloop-continue "fileloop" (= ))) Lars> I don't think this is necessary -- you can just have the Lars> `declare-function' without any `eval-when-compile'. But you shou= ld Lars> probably include the arg list? I did :-) fileloop.el: (defun fileloop-continue () >> + (if (ring-empty-p ring) >> + ;; Just in case we were in a fileloop sequence >> + (fileloop-continue) Lars> Yes, that's what I wondered would work. Are there any drawbacks = to Lars> doing something like this? Perhaps the interface becomes a bit... Lars> unpredictable? It=CA=BCs perfectly deterministic, just potentially confusing :-) It begs the question why xrefs replaced a 'do the next thing' type binding with a 'go back' type binding in the first place. I=CA=BCm tempted to say that xref-pop-marker-stack should use a different binding, and M-, should be fileloop-continue, but the xref one has existed for 5 years now. Robert