unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: Tobias Bading <tbading@web.de>
Cc: emacs-devel@gnu.org
Subject: Re: The rabbit hole that is HiDPI... (empty menus / bug#31223 et al)
Date: Wed, 27 Nov 2019 18:00:24 +0100	[thread overview]
Message-ID: <m2fti9i79z.fsf@gmail.com> (raw)
In-Reply-To: <f52f0a0c-8c54-cada-8633-a262b529a53c@web.de> (Tobias Bading's message of "Wed, 27 Nov 2019 17:41:37 +0100")

>>>>> On Wed, 27 Nov 2019 17:41:37 +0100, Tobias Bading <tbading@web.de> said:

    Tobias> On 27.11.19 16:12, Robert Pluim wrote:
    >>>>>>> On Wed, 27 Nov 2019 14:41:35 +0100, Tobias Bading
    Tobias> <tbading@web.de> said:
    >> 
    >>      Tobias> The menu bar problems are looking good so far.
    >>      Tobias> A "req.height *= xg_get_scale (f)" was missing in
    Tobias> menubar_map_cb() and
    >>      Tobias> xg_update_frame_menubar(), right after calling
    >>      Tobias> gtk_widget_get_preferred_size() for the menu bar widget.
    Tobias> Plus scale
    >>      Tobias> handling in xg_event_is_for_menubar() et voilà.
    >> 
    >> Curious that this wasn't needed before. Has something changed in GTK?

    Tobias> Nope, looks like a rather old bug. But it only affects HiDPI displays with
    Tobias> window scaling active (e.g. set in 'MATE Tweak' or similar in GNOME 2/3).
    Tobias> People using Xrandr to scale the entire display are probably not affected
    Tobias> either.

That describes my setup, although itʼs Fedora running Gnome, not
MATE. Perhaps I should boot into Ubuntu to compare.

    Tobias> I just sent a patch to https://debbugs.gnu.org/cgi/bugreport.cgi?bug=31223

Iʼll take a look.

    >>      >> Thatʼs pretty recent, so your gtk version is greater than
    Tobias> 3.22, right?
    >> 
    >>      Tobias> Yes, 3.24.12.
    >> 
    >> And I have the same version, but have no problems with menus. Even
    >> curiouser.

    Tobias> Do you use a HiDPI monitor with a window scaling factor of 2?

Yes.



      reply	other threads:[~2019-11-27 17:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-26 19:13 The rabbit hole that is HiDPI... (empty menus / bug#31223 et al) Tobias Bading
2019-11-26 19:24 ` Tobias Bading
2019-11-27 11:06 ` Tobias Bading
2019-11-27 11:30 ` Robert Pluim
2019-11-27 12:29   ` Tobias Bading
2019-11-27 13:00     ` Robert Pluim
2019-11-27 13:41       ` Tobias Bading
2019-11-27 15:12         ` Robert Pluim
2019-11-27 16:41           ` Tobias Bading
2019-11-27 17:00             ` Robert Pluim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2fti9i79z.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=tbading@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).