From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Rudolf =?utf-8?Q?Adamkovi=C4=8D?= Newsgroups: gmane.emacs.devel Subject: Re: feature/package-vc has been merged Date: Sun, 13 Nov 2022 23:11:02 +0100 Message-ID: References: <164484721900.31751.1453162457552427931@vcs2.savannah.gnu.org> <878rkxgpms.fsf@posteo.net> <87sfiyk3a2.fsf_-_@posteo.net> <87mt948pmo.fsf@posteo.net> <87fsevyxnt.fsf@posteo.net> <87zgd1f70g.fsf@posteo.net> <878rkkbj90.fsf@posteo.net> <87edua7jw5.fsf@posteo.net> <878rki7jf3.fsf@posteo.net> <871qq81u3m.fsf@posteo.net> <87sfinwd6c.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33725"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier , Richard Stallman , emacs-devel@gnu.org, 'Eli Zaretskii' To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Nov 13 23:12:06 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ouLCw-0008Sv-DM for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Nov 2022 23:12:06 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ouLC6-0004Z2-P7; Sun, 13 Nov 2022 17:11:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouLC5-0004YS-22 for emacs-devel@gnu.org; Sun, 13 Nov 2022 17:11:13 -0500 Original-Received: from mr85p00im-ztdg06021801.me.com ([17.58.23.195]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouLC2-0000UN-Dp for emacs-devel@gnu.org; Sun, 13 Nov 2022 17:11:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=1a1hai; t=1668377466; bh=Q25RIs8XJJSLAqYD+0rUxzb9v1pCkb77ljW/JNtJecw=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=HWXW86SCIdGiED7DW9tAS8adW5XdWoWklbyEA119VCfye+yE6YcmkmngzvQzombM3 yllICpSQiAVc+k6DFBoP6cAvuCzXDmgj5SmQxOlepe5rIvIQ47XAps28NhBNbsN18G fI+dPgnoFoKT5u2PE0F5plmdyKtqjM4mXvuK+NCUQWKIo4ZVkfm82Iv5ezbHgnPhWT N2dXsKO7LGJypFNPwlBoPBSQZMZyEZ4SF5hQ6y95RMAK6BlVyJ5K3gl7pb4z35gFpI KjabXhC+DMLaFZTly/+TMOYh+iLY1m9VWV+YRy312FuzSnjyLsDCAYkfR3NqlTyabE nw042lafqwkvA== Original-Received: from Rudolfs-MacBook-Air.local (mr38p00im-dlb-asmtp-mailmevip.me.com [17.57.152.18]) by mr85p00im-ztdg06021801.me.com (Postfix) with ESMTPSA id 70552D005C1; Sun, 13 Nov 2022 22:11:05 +0000 (UTC) In-Reply-To: <87sfinwd6c.fsf@posteo.net> X-Proofpoint-GUID: _IljOKEAkBiA9BL9qXQNaV5ctp9bCS5g X-Proofpoint-ORIG-GUID: _IljOKEAkBiA9BL9qXQNaV5ctp9bCS5g X-Proofpoint-Virus-Version: =?UTF-8?Q?vendor=3Dfsecure_engine=3D1.1.170-22c6f66c430a71ce266a39bfe25bc?= =?UTF-8?Q?2903e8d5c8f:6.0.425,18.0.572,17.0.605.474.0000000_definitions?= =?UTF-8?Q?=3D2022-01-14=5F01:2022-01-14=5F01,2020-02-14=5F11,2020-01-23?= =?UTF-8?Q?=5F02_signatures=3D0?= X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0 mlxscore=0 adultscore=0 clxscore=1015 suspectscore=0 spamscore=0 bulkscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2211130153 Received-SPF: pass client-ip=17.58.23.195; envelope-from=salutis@me.com; helo=mr85p00im-ztdg06021801.me.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299758 Archived-At: Philip Kaludercic writes: >> That said, When I updated my config to install from VC, I noticed >> that `elpa' in `.emacs.d' now contained two versions of the packages, >> one from `package' and one from `package-vc'. > > This seems like an issue of what perspective one takes. I don't see > package-vc as an "upgrade" over package, but as an alternative backend > for fetching source code. Not even I plan to use it for everything, > rather I'd install a source package when I am hacking on some package, > and when I have sent out the patches and am done with it, I'd remove > the source package and be left with the previous installation. I like the backend idea, but the two systems, non-VC and VC, define separate lists of selected packages. But then, what happens when the user selects the same package in both lists? Will that lead to any problems? If so, then we should not allow the user to do that, or deal with it in some way. >> As a side note, you mentioned that `package-install' works for both >> "normal" and VC packages? I guess `package-autoremove' does that too? >> I looked at the documentation for both and they mention just >> `package-selected-packages'. > > I don't think I said "package-install works for both normal and VC > packages"? package-install fetches a tarball, package-vc-install > fetches a repository? I apologize for confusion. Perhaps you said that for `package-update'? (I remain a bit confused about which commands apply to both VC and non-VC packages.) >> And speaking of `-autoremove', should we also add `-vc-autoremove'? > > I don't think so, because -autoremove is for removing non-selected > packages, while all source packages are selected (you'll find that > package-vc uses regular tarball packages if dependencies have to be > installed). Really? I thought VC `-install' works like the non-VC kind, meaning it does not select anything, just installs a package so that the user can quickly try it. But you say "all source packages are selected". >> For the only problem I have, I could not install `geiser'. I got >> "user-error: Package has no VC data", and I kept wondering what the user >> should do in this situation. I had no idea where to look. > > That sounds wrong, there seems to be a specification in > elpa-packages.eld: > > ("geiser" :url "https://gitlab.com/emacs-geiser/geiser.git" :lisp-dir > "elisp" :readme "readme.org" :doc "doc/geiser.texi") > > Maybe this is related to MELPA? They don't have package specification > lists yet, and if their package is prioritised (due to their versioning > scheme), maybe this could confused package-vc? I tried the following two experiments, starting from: (with-eval-after-load 'package (add-to-list 'package-archives '("melpa" . "https://melpa.org/packages/")) (add-to-list 'package-archives '("melpa-stable" . "https://stable.melpa.org/packages/"))) Experiment 1: Add MELPA to the end of the list. (with-eval-after-load 'package (add-to-list 'package-archives '("melpa" . "https://melpa.org/packages/") t) ; <------ `t' means the end of the list (add-to-list 'package-archives '("melpa-stable" . "https://stable.melpa.org/packages/") t)) ; <------ `t' means the end of the list This *did not* help. Experiment 2: Comment out MELPA. ;; (with-eval-after-load 'package ;; (add-to-list ;; 'package-archives ;; '("melpa" . "https://melpa.org/packages/")) ;; (add-to-list ;; 'package-archives ;; '("melpa-stable" . "https://stable.melpa.org/packages/"))) This *did* help. If the user has MELPA at the end of the list, it should just work. So, that needs fixing. But the question becomes, what should happen if the user has MELPA at the beginning of the list. VC could fail, but it could also proceed, silently or with a message. >> I will try more packages in the coming days or weeks! > > Very appreciative. But this is a good sign that after bug#59109 has > been resolved, the changes can be applied back onto master. > >> P.S. The documentation for the `package-vc-selected-packages' variable >> contains a typo "... you cal also use ...". > > Will fix, thanks! Super! Also, the documentation for the `package-vc-install' function needs some blank lines between paragraphs. :) Rudy --=20 "Strange as it may sound, the power of mathematics rests on its evasion of all unnecessary thought and on its wonderful saving of mental operations." -- Ernst Mach, 1838-1916 Rudolf Adamkovi=C4=8D [he/him] Studenohorsk=C3=A1 25 84103 Bratislava Slovakia