From: "Gerd Möllmann" <gerd.moellmann@gmail.com>
To: Helmut Eller <eller.helmut@gmail.com>
Cc: Emacs Devel <emacs-devel@gnu.org>, Eli Zaretskii <eliz@gnu.org>
Subject: Re: MPS: Forwording symbols
Date: Fri, 21 Jun 2024 17:41:18 +0200 [thread overview]
Message-ID: <m2frt62ti9.fsf@pro2.fritz.box> (raw)
In-Reply-To: <878qyy1f55.fsf@gmail.com> (Helmut Eller's message of "Fri, 21 Jun 2024 17:36:54 +0200")
Helmut Eller <eller.helmut@gmail.com> writes:
> On Sun, Jun 16 2024, Gerd Möllmann wrote:
>
>> Ok, I've looked a bit closer, and I think we can avoid dumping the
>> the forwarding structs altogether.
>>
>> There are 5 types of forwarding structs
>>
>> enum Lisp_Fwd_Type
>> {
>> Lisp_Fwd_Int, /* Fwd to a C `int' variable. */
>> Lisp_Fwd_Bool, /* Fwd to a C boolean var. */
>> Lisp_Fwd_Obj, /* Fwd to a C Lisp_Object variable. */
>> Lisp_Fwd_Buffer_Obj, /* Fwd to a Lisp_Object field of buffers. */
>> Lisp_Fwd_Kboard_Obj /* Fwd to a Lisp_Object field of kboards. */
>> };
>>
>> Four of them contain only the type and either integer offsets or
>> pointers to variables in Emacs' data segment. The only interesting one
>> is Lisp_Fwd_Buffer_Obj which looks like
>>
>> struct Lisp_Buffer_Objfwd
>> {
>> enum Lisp_Fwd_Type type; /* = Lisp_Fwd_Buffer_Obj */
>> int offset;
>> /* One of Qnil, Qintegerp, Qsymbolp, Qstringp, Qfloatp or Qnumberp. */
>> Lisp_Object predicate;
>> };
>>
>> which has an additional member for the predicate. AFAICT, the comment is
>> true, and thus predicate is also a constant because it is always from a
>> DEFSYM, i.e. it is a symbol from lispsym.
>
> Can we use similar reasoning to remove fix_fwd? If predicate is
> guaranteed to be a builtin symbol, then we don't need to do anything for
> the Lisp_Buffer_Objfwd case.
>
> Then only remains issue with DEFVAR_LISP_NOPRO. We could simply make
> DEFVAR_LISP_NOPRO an alias for the regular DEFVAR_LISP.
>
> If fix_symbol needs to call fix_fwd, then so should fix_blv. But nicer
> would be to remove fix_fwd altogether.
Sounds like a good plan to me.
Maybe we could also make predicate an enum at the same time? It need not
be a Lisp_Object, and replacing it with an enum would make that clearer.
next prev parent reply other threads:[~2024-06-21 15:41 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-16 9:43 MPS: Forwording symbols Gerd Möllmann
2024-06-16 10:15 ` Gerd Möllmann
2024-06-16 19:27 ` Helmut Eller
2024-06-16 19:39 ` Gerd Möllmann
2024-06-17 10:57 ` Eli Zaretskii
2024-06-17 12:15 ` Gerd Möllmann
2024-06-17 12:24 ` Eli Zaretskii
2024-06-17 12:58 ` Gerd Möllmann
2024-06-17 3:43 ` Gerd Möllmann
2024-06-17 11:47 ` Eli Zaretskii
2024-06-17 18:10 ` Helmut Eller
2024-06-17 18:39 ` Gerd Möllmann
2024-06-17 18:50 ` Gerd Möllmann
2024-06-17 19:05 ` Helmut Eller
2024-06-17 19:19 ` Gerd Möllmann
2024-06-17 19:25 ` Helmut Eller
2024-06-17 20:07 ` Gerd Möllmann
2024-06-18 6:32 ` Gerd Möllmann
2024-06-18 9:05 ` Helmut Eller
2024-06-18 9:24 ` Gerd Möllmann
2024-06-18 10:44 ` Gerd Möllmann
2024-06-18 11:55 ` Helmut Eller
2024-06-18 12:21 ` Gerd Möllmann
2024-06-18 19:36 ` Helmut Eller
2024-06-18 19:55 ` Gerd Möllmann
2024-06-20 14:18 ` Helmut Eller
2024-06-20 15:16 ` Gerd Möllmann
2024-06-20 16:17 ` Helmut Eller
2024-06-20 16:27 ` Gerd Möllmann
2024-06-18 12:05 ` Helmut Eller
2024-06-18 12:29 ` Gerd Möllmann
2024-06-18 13:08 ` Eli Zaretskii
2024-06-18 12:36 ` Eli Zaretskii
2024-06-18 16:20 ` Helmut Eller
2024-06-18 16:29 ` Eli Zaretskii
2024-06-18 16:43 ` Gerd Möllmann
2024-06-18 16:37 ` Helmut Eller
2024-06-18 17:33 ` Eli Zaretskii
2024-06-18 17:51 ` Helmut Eller
2024-06-18 18:18 ` Eli Zaretskii
2024-06-18 17:54 ` Eli Zaretskii
2024-06-18 18:11 ` Gerd Möllmann
2024-06-18 18:20 ` Eli Zaretskii
2024-06-18 18:23 ` Gerd Möllmann
2024-06-18 18:12 ` Helmut Eller
2024-06-18 18:22 ` Eli Zaretskii
2024-06-18 19:27 ` Helmut Eller
2024-06-18 19:33 ` Gerd Möllmann
2024-06-19 11:22 ` Eli Zaretskii
2024-06-17 19:06 ` Gerd Möllmann
2024-06-21 15:36 ` Helmut Eller
2024-06-21 15:41 ` Gerd Möllmann [this message]
2024-06-21 16:20 ` Gerd Möllmann
2024-06-22 18:02 ` Helmut Eller
2024-06-22 18:27 ` Gerd Möllmann
2024-06-22 18:53 ` Helmut Eller
2024-06-22 19:26 ` Gerd Möllmann
2024-06-23 3:28 ` Gerd Möllmann
2024-06-23 4:10 ` Gerd Möllmann
2024-06-23 19:59 ` Helmut Eller
2024-06-24 3:45 ` Gerd Möllmann
2024-06-24 15:13 ` Helmut Eller
2024-06-24 16:14 ` Gerd Möllmann
2024-06-24 16:32 ` Eli Zaretskii
2024-06-24 17:00 ` Gerd Möllmann
2024-06-23 15:59 ` Helmut Eller
2024-06-23 16:26 ` Gerd Möllmann
2024-06-21 16:15 ` Ihor Radchenko
2024-06-21 16:25 ` Gerd Möllmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2frt62ti9.fsf@pro2.fritz.box \
--to=gerd.moellmann@gmail.com \
--cc=eliz@gnu.org \
--cc=eller.helmut@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).