From: CHENG Gao <chenggao@gmail.com>
Subject: Re: Should xemacs feature test be removed from url package?
Date: Fri, 14 Oct 2005 00:07:49 +0800 [thread overview]
Message-ID: <m2ek6p2yei.fsf@eqiao.com> (raw)
In-Reply-To: E1EP7MP-00037u-Jj@fencepost.gnu.org
[-- Attachment #1: Type: text/plain, Size: 248 bytes --]
*On Mon, 10 Oct 2005 19:47:13 -0400
* "Richard M. Stallman" <rms@gnu.org> climbed out of the dark hell and
* cried out:
> Bill Perry did not respond. So let's delete those conditionals.
> Do you want to do it?
Attached please find unified diff.
[-- Attachment #2: url package diff with xemacs feature test removed --]
[-- Type: application/octet-stream, Size: 3622 bytes --]
--- url-http.el.orig 2005-10-04 19:22:22.000000000 +0800
+++ url-http.el 2005-10-13 23:50:10.000000000 +0800
@@ -840,9 +840,7 @@
(list 'start-open t
'end-open t
'chunked-encoding t
- 'face (if (featurep 'xemacs)
- 'text-cursor
- 'cursor)
+ 'face 'cursor
'invisible t))
(setq url-http-chunked-length (string-to-number (buffer-substring
(match-beginning 1)
--- url-dired.el.orig 2005-08-19 23:52:27.000000000 +0800
+++ url-dired.el 2005-10-13 23:51:45.000000000 +0800
@@ -31,9 +31,7 @@
(defvar url-dired-minor-mode-map
(let ((map (make-sparse-keymap)))
(define-key map "\C-m" 'url-dired-find-file)
- (if (featurep 'xemacs)
- (define-key map [button2] 'url-dired-find-file-mouse)
- (define-key map [mouse-2] 'url-dired-find-file-mouse))
+ (define-key map [mouse-2] 'url-dired-find-file-mouse)
map)
"Keymap used when browsing directories.")
--- url-file.el.orig 2005-08-19 23:52:27.000000000 +0800
+++ url-file.el 2005-10-13 23:53:33.000000000 +0800
@@ -230,12 +230,8 @@
(url-file-create-wrapper file-readable-p (url))
(url-file-create-wrapper file-writable-p (url))
(url-file-create-wrapper file-executable-p (url))
-(if (featurep 'xemacs)
- (progn
- (url-file-create-wrapper directory-files (url &optional full match nosort files-only))
- (url-file-create-wrapper file-truename (url &optional default)))
- (url-file-create-wrapper directory-files (url &optional full match nosort))
- (url-file-create-wrapper file-truename (url &optional counter prev-dirs)))
+(url-file-create-wrapper directory-files (url &optional full match nosort))
+(url-file-create-wrapper file-truename (url &optional counter prev-dirs))
(provide 'url-file)
--- url-handlers.el.orig 2005-08-19 23:52:27.000000000 +0800
+++ url-handlers.el 2005-10-13 23:55:16.000000000 +0800
@@ -246,19 +246,8 @@
(url-handlers-create-wrapper file-writable-p (url))
(url-handlers-create-wrapper file-directory-p (url))
(url-handlers-create-wrapper file-executable-p (url))
-
-(if (featurep 'xemacs)
- (progn
- ;; XEmacs specific prototypes
- (url-handlers-create-wrapper
- directory-files (url &optional full match nosort files-only))
- (url-handlers-create-wrapper
- file-truename (url &optional default)))
- ;; Emacs specific prototypes
- (url-handlers-create-wrapper
- directory-files (url &optional full match nosort))
- (url-handlers-create-wrapper
- file-truename (url &optional counter prev-dirs)))
+(url-handlers-create-wrapper directory-files (url &optional full match nosort))
+(url-handlers-create-wrapper file-truename (url &optional counter prev-dirs))
(add-hook 'find-file-hook 'url-handlers-set-buffer-mode)
--- url-nfs.el.orig 2005-08-19 23:52:28.000000000 +0800
+++ url-nfs.el 2005-10-13 23:56:08.000000000 +0800
@@ -87,12 +87,8 @@
(url-nfs-create-wrapper file-readable-p (url))
(url-nfs-create-wrapper file-writable-p (url))
(url-nfs-create-wrapper file-executable-p (url))
-(if (featurep 'xemacs)
- (progn
- (url-nfs-create-wrapper directory-files (url &optional full match nosort files-only))
- (url-nfs-create-wrapper file-truename (url &optional default)))
- (url-nfs-create-wrapper directory-files (url &optional full match nosort))
- (url-nfs-create-wrapper file-truename (url &optional counter prev-dirs)))
+(url-nfs-create-wrapper directory-files (url &optional full match nosort))
+(url-nfs-create-wrapper file-truename (url &optional counter prev-dirs))
(provide 'url-nfs)
[-- Attachment #3: Type: text/plain, Size: 142 bytes --]
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
next prev parent reply other threads:[~2005-10-13 16:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-25 17:54 Should xemacs feature test be removed from url package? CHENG Gao
2005-09-26 4:49 ` Richard M. Stallman
2005-09-26 5:04 ` Cheng Gao
2005-09-26 5:14 ` David Kastrup
2005-09-26 23:55 ` Richard M. Stallman
2005-09-26 23:55 ` Richard M. Stallman
2005-09-27 3:16 ` Cheng Gao
2005-09-27 6:42 ` David Kastrup
2005-09-27 15:43 ` Stefan Monnier
2005-09-27 21:58 ` Richard M. Stallman
2005-10-10 23:47 ` Richard M. Stallman
2005-10-13 16:07 ` CHENG Gao [this message]
2005-09-26 13:14 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2ek6p2yei.fsf@eqiao.com \
--to=chenggao@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).