From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.devel Subject: Re: Display performance degradation Date: Sat, 19 Dec 2009 11:00:56 +0100 Message-ID: References: <4B2A5F92.9090008@swipnet.se> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1261216884 7787 80.91.229.12 (19 Dec 2009 10:01:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 19 Dec 2009 10:01:24 +0000 (UTC) Cc: emacs-devel@gnu.org, Kenichi Handa To: YAMAMOTO Mitsuharu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 19 11:01:16 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NLw7f-0001H5-1R for ged-emacs-devel@m.gmane.org; Sat, 19 Dec 2009 11:01:15 +0100 Original-Received: from localhost ([127.0.0.1]:46340 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NLw7f-0002Hc-9i for ged-emacs-devel@m.gmane.org; Sat, 19 Dec 2009 05:01:15 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NLw7Y-0002HO-Hi for emacs-devel@gnu.org; Sat, 19 Dec 2009 05:01:08 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NLw7T-0002Gd-37 for emacs-devel@gnu.org; Sat, 19 Dec 2009 05:01:07 -0500 Original-Received: from [199.232.76.173] (port=42207 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NLw7S-0002GW-SB for emacs-devel@gnu.org; Sat, 19 Dec 2009 05:01:02 -0500 Original-Received: from mail-out.m-online.net ([212.18.0.9]:49384) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NLw7S-0001WV-Ap for emacs-devel@gnu.org; Sat, 19 Dec 2009 05:01:02 -0500 Original-Received: from mail01.m-online.net (mail.m-online.net [192.168.3.149]) by mail-out.m-online.net (Postfix) with ESMTP id 83BD41C15681; Sat, 19 Dec 2009 11:00:58 +0100 (CET) Original-Received: from localhost (dynscan2.mnet-online.de [192.168.1.215]) by mail.m-online.net (Postfix) with ESMTP id 2B74F90410; Sat, 19 Dec 2009 11:00:58 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Original-Received: from mail.mnet-online.de ([192.168.3.149]) by localhost (dynscan2.mnet-online.de [192.168.1.215]) (amavisd-new, port 10024) with ESMTP id K8pg6eq2ilYz; Sat, 19 Dec 2009 11:00:57 +0100 (CET) Original-Received: from igel.home (DSL01.83.171.167.154.ip-pool.NEFkom.net [83.171.167.154]) by mail.mnet-online.de (Postfix) with ESMTP; Sat, 19 Dec 2009 11:00:56 +0100 (CET) Original-Received: by igel.home (Postfix, from userid 501) id 89592CA28C; Sat, 19 Dec 2009 11:00:56 +0100 (CET) X-Yow: Clear the laundromat!! This whirl-o-matic just had a nuclear meltdown!! In-Reply-To: (YAMAMOTO Mitsuharu's message of "Sat, 19 Dec 2009 11:56:47 +0900") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.90 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:118738 Archived-At: YAMAMOTO Mitsuharu writes: > 4490 if (XINT (XCAR (val)) == 0) > 4491 { > 4492 font_clear_cache (f, XCAR (val), driver_list->driver); > 4493 XSETCDR (cache, XCDR (val)); > 4494 } > 4495 } > > At line 4490, XCAR (val) is expected to be of type Lisp integer. But > it is also passed to font_clear_cache at line 4492, which seems to > expect the value of `val' as of line 4488 rather than the one assigned > at line 4489. If the condition is ever true then Emacs crashes. I've checked in a fix. But then, I don't think this function is ever more than a no-op anyway, since as soon as NUM-FRAMES becomes zero the cache is cleared automatically anyway. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."