From: Andreas Schwab <schwab@linux-m68k.org>
To: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
Cc: emacs-devel@gnu.org, Kenichi Handa <handa@m17n.org>
Subject: Re: Display performance degradation
Date: Sat, 19 Dec 2009 11:00:56 +0100 [thread overview]
Message-ID: <m2eimrjnaf.fsf@igel.home> (raw)
In-Reply-To: <wlljgzwu1c.wl%mituharu@math.s.chiba-u.ac.jp> (YAMAMOTO Mitsuharu's message of "Sat, 19 Dec 2009 11:56:47 +0900")
YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> writes:
> 4490 if (XINT (XCAR (val)) == 0)
> 4491 {
> 4492 font_clear_cache (f, XCAR (val), driver_list->driver);
> 4493 XSETCDR (cache, XCDR (val));
> 4494 }
> 4495 }
>
> At line 4490, XCAR (val) is expected to be of type Lisp integer. But
> it is also passed to font_clear_cache at line 4492, which seems to
> expect the value of `val' as of line 4488 rather than the one assigned
> at line 4489.
If the condition is ever true then Emacs crashes. I've checked in a
fix. But then, I don't think this function is ever more than a no-op
anyway, since as soon as NUM-FRAMES becomes zero the cache is cleared
automatically anyway.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2009-12-19 10:00 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-17 2:49 Display performance degradation YAMAMOTO Mitsuharu
2009-12-17 7:39 ` Jan D.
2009-12-17 20:08 ` Eli Zaretskii
2009-12-18 16:47 ` Jan Djärv
2009-12-18 21:20 ` Eli Zaretskii
2010-01-02 11:05 ` Jan Djärv
2010-01-02 11:21 ` Eli Zaretskii
2010-01-02 14:31 ` Jan Djärv
2009-12-17 12:24 ` Kenichi Handa
2009-12-17 14:43 ` Chong Yidong
2009-12-18 3:53 ` Miles Bader
2009-12-17 16:42 ` Jan Djärv
2009-12-18 3:06 ` YAMAMOTO Mitsuharu
2009-12-18 5:46 ` Kenichi Handa
2009-12-19 2:56 ` YAMAMOTO Mitsuharu
2009-12-19 10:00 ` Andreas Schwab [this message]
2009-12-20 6:27 ` YAMAMOTO Mitsuharu
2009-12-21 1:17 ` Kenichi Handa
2009-12-21 2:11 ` Miles Bader
2009-12-21 2:31 ` Lennart Borgman
2009-12-21 3:05 ` Miles Bader
2009-12-21 3:08 ` Lennart Borgman
2009-12-21 3:44 ` Miles Bader
2009-12-21 3:54 ` Lennart Borgman
2009-12-21 4:16 ` Miles Bader
2009-12-21 4:18 ` Lennart Borgman
2010-01-06 19:46 ` Jan Djärv
2010-01-07 8:26 ` YAMAMOTO Mitsuharu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2eimrjnaf.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=emacs-devel@gnu.org \
--cc=handa@m17n.org \
--cc=mituharu@math.s.chiba-u.ac.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).