From: John Wiegley <jwiegley@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: "Przemysław Wojnowski" <esperanto@cumego.com>, emacs-devel@gnu.org
Subject: Re: [PATCH] CONTRIBUTE - writing tests for understanding internals
Date: Wed, 11 Nov 2015 13:36:19 -0800 [thread overview]
Message-ID: <m2egfwb4mk.fsf@Vulcan.attlocal.net> (raw)
In-Reply-To: <83egfwjki8.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 11 Nov 2015 23:26:07 +0200")
>>>>> Eli Zaretskii <eliz@gnu.org> writes:
>> It *is* very good way to learn about a project and, in many companies, is
>> used to introduce new developers. (I do that every time and after sometime
>> devs tell me that it is a good introduction, because project at the
>> beginning were to big and overwhelming to them.)
> Then I guess we will have to agree to disagree about this.
I think what works for us individually may or may not work for others. I know
some people find working on tests to be an excellent way to introduce
themselves to a code base; others don't. Sometimes writing tests while reading
about internals leads to tests that have little value, because they simply
repeat what the implementation says. Other times, the act of trying to
understand enough about the internals to write that test leads to valuable
insights.
Rather than agreeing or disagreeing, let's say that there is value here, we
just don't who it will attract and why. I'm OK with encouraging people to
write tests. Anything that invites them to participate more cannot really
hurt, can it?
John
next prev parent reply other threads:[~2015-11-11 21:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-10 22:48 [PATCH] CONTRIBUTE - writing tests for understanding internals Przemysław Wojnowski
2015-11-10 22:58 ` John Wiegley
2015-11-11 3:36 ` Eli Zaretskii
2015-11-11 7:45 ` Przemysław Wojnowski
2015-11-11 8:26 ` Andreas Röhler
2015-11-11 15:40 ` Eli Zaretskii
2015-11-11 15:40 ` Eli Zaretskii
2015-11-11 21:08 ` Przemysław Wojnowski
2015-11-11 21:26 ` Eli Zaretskii
2015-11-11 21:36 ` John Wiegley [this message]
2015-11-12 3:40 ` Eli Zaretskii
2015-11-11 21:48 ` Przemysław Wojnowski
2015-11-12 7:16 ` Andreas Röhler
2015-11-12 16:15 ` Eli Zaretskii
2015-11-12 20:03 ` Stephen Leake
2015-11-12 20:40 ` Andreas Röhler
2015-11-12 20:55 ` Eli Zaretskii
2015-11-12 21:42 ` Przemysław Wojnowski
2015-11-13 7:33 ` Eli Zaretskii
2015-11-13 8:03 ` Andreas Röhler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2egfwb4mk.fsf@Vulcan.attlocal.net \
--to=jwiegley@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=esperanto@cumego.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).