unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Keith David Bershatsky <esq@lawlist.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: C equivalent for: (face-attribute 'region :background (selected-frame) 'default)
Date: Wed, 04 Oct 2017 17:24:50 -0700	[thread overview]
Message-ID: <m2efqi1lwt.wl%esq@lawlist.com> (raw)

Thank you, Eli, for looking at this particular thread.  The first draft of crosshairs is taking me longer than I had initially anticipated, and I still have not played with implementing that functionality for Emacs flavors W32 or X11.  So, it may be awhile before I have a draft ready.  In the meantime, I ported from Lisp to C the functions `face-attribute` (except the condition-case) and `face-attribute-merged-with':

https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg00917.html

My preference is that multiple fake cursors and crosshairs be implemented entirely in C, with just a little bit of Lisp to access those tools.  I also felt that relying on Lisp might somehow slow things down a bit, and speed is really important.

If you or anyone is interested in adding `face-attribute` and `face-attribute-merged-with' to xfaces.c, the link above has my suggested implementation.

Keith

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

DATE:  [09-29-2017 06:25:38] <29 Sep 2017 16:25:38 +0300>
FROM:  Eli Zaretskii <eliz@gnu.org>
> 
>  * * *
> 
> > Date: Tue, 26 Sep 2017 11:38:03 -0700
> > From: Keith David Bershatsky <esq@lawlist.com>
> > 
> > I have begun porting the two relevant Lisp functions to C and will submit them (when finished) in conjunction with the next draft of implementing my feature requests for crosshairs (#17684) and multiple fake cursors (#22873).  . . .
> 
> Thanks, but why would we want to port them to C?  is something wrong
> with their current Lisp implementations?



             reply	other threads:[~2017-10-05  0:24 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-05  0:24 Keith David Bershatsky [this message]
2017-10-05  6:47 ` C equivalent for: (face-attribute 'region :background (selected-frame) 'default) Eli Zaretskii
2017-10-05  7:11   ` YAMAMOTO Mitsuharu
  -- strict thread matches above, loose matches on Subject: below --
2017-10-06  3:53 Keith David Bershatsky
2017-09-27  0:24 Keith David Bershatsky
2017-09-27  5:58 ` YAMAMOTO Mitsuharu
2017-09-26 22:11 Keith David Bershatsky
2017-09-29 20:33 ` Philipp Stephani
2017-09-26 22:06 Keith David Bershatsky
2017-09-26 18:38 Keith David Bershatsky
2017-09-29 13:25 ` Eli Zaretskii
2017-09-26  4:38 Keith David Bershatsky
2017-09-26 18:46 ` Philipp Stephani
2017-09-26 23:19 ` YAMAMOTO Mitsuharu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2efqi1lwt.wl%esq@lawlist.com \
    --to=esq@lawlist.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).