From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: charles@aurox.ch (Charles A. Roelli) Newsgroups: gmane.emacs.devel Subject: Re: Xwidget webkit support for macOS X Cocoa Date: Sun, 03 Dec 2017 12:32:36 +0100 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1512300694 9545 195.159.176.226 (3 Dec 2017 11:31:34 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 3 Dec 2017 11:31:34 +0000 (UTC) Cc: emacs-devel@gnu.org To: Jaesup Kwak Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Dec 03 12:31:29 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eLSUb-0002C7-2I for ged-emacs-devel@m.gmane.org; Sun, 03 Dec 2017 12:31:29 +0100 Original-Received: from localhost ([::1]:38550 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eLSUi-0006Me-D1 for ged-emacs-devel@m.gmane.org; Sun, 03 Dec 2017 06:31:36 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51974) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eLSTx-0006MO-Bh for emacs-devel@gnu.org; Sun, 03 Dec 2017 06:30:50 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eLSTt-0008Pe-DM for emacs-devel@gnu.org; Sun, 03 Dec 2017 06:30:49 -0500 Original-Received: from [2a03:2040:2:1b::1] (port=45285 helo=sinyavsky.aurox.ch) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eLSTt-0008Jk-3J for emacs-devel@gnu.org; Sun, 03 Dec 2017 06:30:45 -0500 Original-Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id 64B46225E8 for ; Sun, 3 Dec 2017 11:23:10 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= references:subject:subject:in-reply-to:to:from:from:message-id :date:date; s=dkim; t=1512300186; x=1513164187; bh=60VqKN9Gsu35e xkgIbwjjGMt42oRHLy0huG4q0Rj8o4=; b=GaTIL4Y8UI8N9HA86jEj5XoK4bCBS ome0SnvB6ps9xN0XTncJRfNENiyc6LUJAeR+TJEgvSdOAZ4x7eoIrWjyfM90LPp8 z9nnnNNAAI/QYrTveRboL9ViGnLCoVro0HGizs9syfk0CO6k8zfhUGWJSpn3AdkP OPZGv0yldbMSA4= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Original-Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id t9x1LvAOe9tr for ; Sun, 3 Dec 2017 11:23:06 +0000 (UTC) Original-Received: from gray (125.85.192.178.dynamic.wline.res.cust.swisscom.ch [178.192.85.125]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id 5419A225D1; Sun, 3 Dec 2017 11:23:06 +0000 (UTC) In-reply-to: (message from Jaesup Kwak on Tue, 28 Nov 2017 16:13:45 +0900) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a03:2040:2:1b::1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:220647 Archived-At: > From: Jaesup Kwak > Date: Tue, 28 Nov 2017 16:13:45 +0900 > > Hi all! > > I made a work supporting Emacs xwidget webkit for macOS X, which works with Cocoa and Safari webkit frameworks without need of > GTK and X window. You can t ry it on master branch of https://github.com/veshboo/emacs > > I want to contribute the work to GNU Emacs and hope someone help me how to contribute. > > Thank you. Thanks a lot for implementing xwidget on macOS. Could you please rebase your branch against the latest master, and post a patch to bug-gnu-emacs@gnu.org? The ChangeLog will also have to be in the format as specified here: https://www.gnu.org/prep/standards/html_node/Change-Logs.html (It's best to use `C-x 4 a' and then the standard VC bindings to make commits, so that the right style is used. The ChangeLog messages will be automatically copied into the commit message when you commit files with `C-x v v'.) Generally Emacs tries to keep support for macOS 10.6 and above, even for new development. I saw that you used the WKWebView as a parent class for the XwWebView, which was made available in version 10.10. I made some small changes locally to adapt your branch to build with the older "WebView" class, and it works on 10.6 (but it is missing some of the bells and whistles). I will work on it some more this week, and we can hopefully include it along with your xwidget implementation. Thanks again.