From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Rudolf =?utf-8?Q?Adamkovi=C4=8D?= Newsgroups: gmane.emacs.devel Subject: Re: feature/package-vc has been merged Date: Sun, 06 Nov 2022 01:23:05 +0100 Message-ID: References: <164484721900.31751.1453162457552427931@vcs2.savannah.gnu.org> <87zgdivc3f.fsf@posteo.net> <874jvqv2u3.fsf@posteo.net> <875yg6qtbl.fsf@posteo.net> <87ilk33lqk.fsf@posteo.net> <87mt9epqlk.fsf@posteo.net> <87ilk1bgvd.fsf@posteo.net> <87edupbdp0.fsf@posteo.net> <875yg1bc02.fsf@posteo.net> <878rkxgpms.fsf@posteo.net> <87sfiyk3a2.fsf_-_@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2773"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Richard Stallman , emacs-devel@gnu.org To: Philip Kaludercic , Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Nov 06 01:23:52 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1orTS4-0000XN-Ip for ged-emacs-devel@m.gmane-mx.org; Sun, 06 Nov 2022 01:23:52 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1orTRU-0000xW-Iy; Sat, 05 Nov 2022 20:23:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1orTRS-0000w7-A8 for emacs-devel@gnu.org; Sat, 05 Nov 2022 20:23:14 -0400 Original-Received: from mr85p00im-ztdg06021101.me.com ([17.58.23.180]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1orTRQ-0005IC-K2 for emacs-devel@gnu.org; Sat, 05 Nov 2022 20:23:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=1a1hai; t=1667694190; bh=gp/NyrZ+eLPKaGR6zWFJTj/2kHh6HdPv8VEOHhV1xo4=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=A3lAjtc0OkkCGERlzAmLtTan4UXH2FJgaQxBHm/9XYjDZUPYmHcZjyaDFIUSOXDvP xayQnsBeZxU1/FuEe0Yrh4l8O/NMd2PZI+75cA3Avy+8Q4SubUdPzK6OtVIpQaAXYY YR9oQYDXKiULxIDawZzp/iAZZ4ZFq+fQf0fqlJlJqEyf5PKqxSW6Q73dusZPatHyLh 17r8CRstiDeUUcGwm9M4FFMezrBe0Iv8H6X6qxvqYTTfHCpph9oVjPJ0yx60G9mlS9 7y28Um7cKWqVWaM24QY+8zhFQFIzA1a9TAM0BX5VLpf7Z1CUMpBCL4SoyMFpYCVLrt ZLE1j1Au7i/7A== Original-Received: from Rudolfs-MacBook-Air.local (mr38p00im-dlb-asmtp-mailmevip.me.com [17.57.152.18]) by mr85p00im-ztdg06021101.me.com (Postfix) with ESMTPSA id 3CE5B806BD; Sun, 6 Nov 2022 00:23:09 +0000 (UTC) In-Reply-To: X-Proofpoint-ORIG-GUID: K4s6GZVYM_nTnGbtCLuQdTga8zqwhQRU X-Proofpoint-GUID: K4s6GZVYM_nTnGbtCLuQdTga8zqwhQRU X-Proofpoint-Virus-Version: =?UTF-8?Q?vendor=3Dfsecure_engine=3D1.1.170-22c6f66c430a71ce266a39bfe25bc?= =?UTF-8?Q?2903e8d5c8f:6.0.138,18.0.572,17.0.605.474.0000000_definitions?= =?UTF-8?Q?=3D2020-02-14=5F11:2020-02-14=5F02,2020-02-14=5F11,2020-01-23?= =?UTF-8?Q?=5F02_signatures=3D0?= X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 adultscore=0 bulkscore=0 mlxscore=0 spamscore=0 mlxlogscore=877 clxscore=1015 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2211060002 Received-SPF: pass client-ip=17.58.23.180; envelope-from=salutis@me.com; helo=mr85p00im-ztdg06021101.me.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299232 Archived-At: Rudolf Adamkovi=C4=8D writes: > OMG, the time has come! Thank you. I would like to share first-time user experience with you. Perhaps you will find it interesting. Here it goes: I found `package-vc-selected-packages' in seconds thanks to its familiar name, nicely matching `package-selected-packages'. Well done! It surprised me, though, that the variable does not accept bare package names, such as `modus-themes' instead of `(modus-themes . nil)'. Then I looked for `package-vc-install-selected-packages`, and troubles started. I found no such function, so I decided to consult the documentation for `package-vc-selected-packages' which says: You can also use the function =E2=80=98package-vc-selected-packages=E2=80= =99 to apply the changes. Confused, I could not find any such function. I also tried `M-x package-vc TAB' but that did not help either. So, I read the source code, I found `package-vc-ensure-packages', and that worked. Phew! I then added `package-vc-ensure-packages' to my Emacs init file, but Emacs did not launch cleanly, for it could not find the function. So, I added an explicit `require' for `package-vc'. Finally, it all worked. I installed Modus Themes! Next, I looked for `package-vc-update', but found nothing. I then found `package-vc-refresh' but that sounded like `package-refresh-contents' which does not update packages. Confusing! Still, I ran the `package-vc-refresh' function, and it prompted me with "Refresh package:". I hit RET, just to try something, and it failed with funcall-interactively: Wrong number of arguments: #, 0 So, I tried again with "modus-themes", which I installed with `package-vc-ensure-packages', and got execute-extended-command: Wrong type argument: listp, #s(package-desc mod= us-themes (3 0 0) "Elegant, highly legible and customizable themes" ((emacs= (27 1))) vc nil "/Users/salutis/.emacs.d/elpa/modus-themes" ((:url . "http= s://git.sr.ht/~protesilaos/modus-themes") (:keywords "faces" "theme" "acces= sibility") (:maintainer "Modus-Themes Development" . "~protesilaos/modus-th= emes@lists.sr.ht") (:authors ("Protesilaos Stavrou" . "info@protesilaos.com= ")) (:commit . "f1149c18005d31638b3701f9a89819b133b4360e")) nil) Ignoring the refresh woes, I suggest the following design changes: - allow strings in `-selected-packages' if possible - make `-ensure-packages' interactive for `M-x' - rename `-ensure-' to `-install-selected-' for consistency - auto-load `-install-selected-packages' for common use - rename `-refresh' to `-update' for consistency - add `-update-all' for consistency - fix the nonexistent function reference in the documentation Then, the existing users of `package.el' will know how to use a large part of `package-vc.el' without needing to learn that "ensure" means "install-selected", "refresh" means "update", and so on. Rudy --=20 "Chop your own wood and it will warm you twice." -- Henry Ford; Francis Kinloch, 1819; Henry David Thoreau, 1854 Rudolf Adamkovi=C4=8D [he/him] Studenohorsk=C3=A1 25 84103 Bratislava Slovakia