From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: I created a faster JSON parser Date: Fri, 15 Mar 2024 15:56:00 +0100 Message-ID: References: <87a5n96mb5.fsf@gmail.com> <20240309203725.x456m7c6soxtgj6q@nullprogram.com> <86jzmawqbm.fsf@gnu.org> <87ttldydf2.fsf@posteo.net> <867ci8vqvl.fsf@gnu.org> <5396AC95-1D8F-4A89-B4A8-647B717A1E3C@gmail.com> <87r0ggdcki.fsf@gmail.com> <437D901F-CEC6-45E0-8ABE-B036A7B0AAF5@gmail.com> <87cyrv8vka.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32893"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= , Eli Zaretskii , Philip Kaludercic , wellons@nullprogram.com, emacs-devel@gnu.org To: =?utf-8?Q?Herman=2C_G=C3=A9za?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 15 15:57:21 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rl8zp-0008KQ-CD for ged-emacs-devel@m.gmane-mx.org; Fri, 15 Mar 2024 15:57:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rl8yl-0005kX-Q9; Fri, 15 Mar 2024 10:56:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rl8ye-0005k3-M3 for emacs-devel@gnu.org; Fri, 15 Mar 2024 10:56:08 -0400 Original-Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rl8yd-0005Cc-11; Fri, 15 Mar 2024 10:56:08 -0400 Original-Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-33d90dfe73cso1341396f8f.0; Fri, 15 Mar 2024 07:56:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710514562; x=1711119362; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZRPvPFnaqgw08OjkeyiO2lFAeZYvn+nyyzZN8NQtedY=; b=NXrlzz2HyTYu816YOy7NeZrza0k6kSf5enX2RUvwSFGviC7UmC1YopS5oXl3cdS1DL nrrEcVzl8YgdDsSX1C8KT4ahmn5Inze5NIkh+9YwqCvrLAqq8NHDgV9k21FOQZf9V+mP nlbz1fYv0O9Um2Mh4c/zPHJKbxpNmK6TmKgzp0Z7/7A65Z/naoY93CDVst5u4MUe834G +MRMrRvdGZGOXkasnq4c4NTM9SnoIFqniroM2JVfqvBInhOqG7+tGgbhPo1wgYFxTrhr dLcJPEaGkA0I8S8XTa7Q+Mp8cPGWxCAkdI2GgVo38dd4p3Q0wZgydfWP8oVkkQvseyDz ehZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710514562; x=1711119362; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ZRPvPFnaqgw08OjkeyiO2lFAeZYvn+nyyzZN8NQtedY=; b=Hl+PztJOkpqV3oLKgHW1MUMWrC5DKJf+BmXmZFyVrzcSPP3Dc1rrEeermZmN2dnwP2 dFld0WvpgL1L/FDUfFD++lcic02zn56TBpJLyU8SdOn0YSp8jw4018Rm+8XS1nz+GVO4 I7eAF62zEjVcXttDZBfudBY85+Hbmh1eQPw1YRpg8VtvpQkAuQzV8M4YEONoYuErBHNm Qb/M7E8EkA4Dc4l1hwz0Ryknz0rios60SRU2S+FFAlvjwz/Qm0ydEWzbDon3hSj7vpjk k5ly0bmHIUG4fhtEGu9aY4vqm567mexxk+XayrV7VufvYT3QI1UGQWCxzJGwD5sxee9p vTmw== X-Forwarded-Encrypted: i=1; AJvYcCWTLaIWbWea+9yCM8JkQs7XCWvoRndP4N1Tz1lnGHd5XImoViR5FbSQh94BbxT6tjYGu6TgrRnNhtezJJf429/IeffdijT3p9fjOIuA2RXtMwc= X-Gm-Message-State: AOJu0YxNOo9gGD4bVknI77shblaBY1nkkFB9WAvfKKs5PDTLuBWvsC0c x4HVGp2+ZP1ePVscAToH+cdSyLufO2wuDY58QVOHca7Zg9tQ2LDvBO6wUGc1lx0= X-Google-Smtp-Source: AGHT+IG1fseRXkqLNgbDLnYOgnEvU7L7y//B2XrNb5GbDRSgcsS+DOlLYA1Uqczxf4Bfm4EIKWV0+A== X-Received: by 2002:adf:a395:0:b0:33e:83a1:227e with SMTP id l21-20020adfa395000000b0033e83a1227emr6222300wrb.7.1710514562391; Fri, 15 Mar 2024 07:56:02 -0700 (PDT) Original-Received: from Pro.fritz.box (pd9e36beb.dip0.t-ipconnect.de. [217.227.107.235]) by smtp.gmail.com with ESMTPSA id i7-20020a5d5587000000b0033ec68dd3c3sm3346818wrv.96.2024.03.15.07.56.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Mar 2024 07:56:02 -0700 (PDT) In-Reply-To: <87cyrv8vka.fsf@gmail.com> ("Herman, =?utf-8?Q?G=C3=A9za=22's?= message of "Fri, 15 Mar 2024 14:35:10 +0100") Received-SPF: pass client-ip=2a00:1450:4864:20::432; envelope-from=gerd.moellmann@gmail.com; helo=mail-wr1-x432.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317073 Archived-At: "Herman, G=C3=A9za" writes: >> What do I propose: If you can, please make objects reachable from the >> control stack. For instance, create a context object on the stack >> that has a Lisp vector member. That will prevent GC'ing the vector >> and by that its contents, of course. You could pass a pointer to the >> context around to get access to the vector in subroutines, replace it >> with a larger vector if necessary, and so on. > > I implemented this idea, here is the latest version (now, > object_workspace is a Lisp_Object): > > https://github.com/geza-herman/emacs/commit/12decaddc9b8260745be4d5782fea= 21f4578eab2.patch > > Is there anything that need to be done? Thanks, that looks very good, I'm happy :-). By putting a struct json_parser on the stack as a local variable, its .object_workspace itself and everything rechable from it are safe from GC.