Re: master 9253910a5a5: Restore a default before macOS 14 API change (bug#72440)

Re: master 9253910a5a5: Restore a default before macOS 14 API change (bug#72440)

[Po Lu]

Gerd Moellmann <gerd@gnu.org> writes:

> branch: master
> commit 9253910a5a5ec89fe6e676e53f355f3b0bdc176e
> Author: Gerd Möllmann <gerd@gnu.org>
> Commit: Gerd Möllmann <gerd@gnu.org>
>
>     Restore a default before macOS 14 API change (bug#72440)
>     
>     * src/nsterm.m ([EmacsView initFrameFromEmacs:]): Set clipsToBounds to
>     YES.
> ---
>  src/nsterm.m | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/src/nsterm.m b/src/nsterm.m
> index b883e605a5b..296e58c1697 100644
> --- a/src/nsterm.m
> +++ b/src/nsterm.m
> @@ -8073,6 +8073,9 @@ ns_in_echo_area (void)
>  #ifdef NS_IMPL_COCOA
>    old_title = 0;
>    maximizing_resize = NO;
> +  /* Restore to default before macOS 14 (bug#72440).  */
> +  if (NSAppKitVersionNumber >= NSAppKitVersionNumber14_0)
> +    [self setClipsToBounds: YES];
>  #endif

Is `NSAppKitVersionNumber14_0' defined on older releases of Mac OS?
Emacs is supposed to compile on 10.6 at the earliest.

Re: master 9253910a5a5: Restore a default before macOS 14 API change (bug#72440)

[Gerd Möllmann]

Po Lu <luangruo@yahoo.com> writes:

> Is `NSAppKitVersionNumber14_0' defined on older releases of Mac OS?
> Emacs is supposed to compile on 10.6 at the earliest.

Good point, I think I'll simply drop the version check.

BTW, maybe also interesting: The versions in NSApplication.h are no
longer defines.

  typedef double NSAppKitVersion NS_TYPED_EXTENSIBLE_ENUM;
  /* The version of the AppKit framework */
  APPKIT_EXTERN const NSAppKitVersion NSAppKitVersionNumber;
  static const NSAppKitVersion NSAppKitVersionNumber10_0 = 577;
  ...

And I wonder who the heck is running Appkit 10.6, or even 11. But
whatever, it's a bloody mess on macOS anyway :-/.