unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Gerd Möllmann" <gerd.moellmann@gmail.com>
To: Andrea Corallo <acorallo@gnu.org>
Cc: emacs-devel@gnu.org, "Gerd Möllmann" <gerd@gnu.org>
Subject: Re: master f92520d009e 1/2: Don't pause display for pending input
Date: Thu, 19 Dec 2024 13:24:41 +0100	[thread overview]
Message-ID: <m2ed237tdi.fsf@gmail.com> (raw)
In-Reply-To: <yp15xnfangp.fsf@fencepost.gnu.org> (Andrea Corallo's message of "Thu, 19 Dec 2024 07:04:06 -0500")

Andrea Corallo <acorallo@gnu.org> writes:

> On a61b968ccfe8fa7e2f1fcf7667781a1c0527389a I see now with
> --with-native-compilation=no --with-x-toolkit=no
>
> =====
> dispnew.c: In function ‘update_menu_bar’:
> dispnew.c:3760:5: error: too many arguments to function ‘update_window’
>  3760 |     update_window (XWINDOW (f->menu_bar_window), true);
>       |     ^~~~~~~~~~~~~
> dispnew.c:97:13: note: declared here
>    97 | static void update_window (struct window *);
>       |             ^~~~~~~~~~~~~
> =======

Thanks. That one should be fixed now. The joy of having n!
configurations.

>
> And with --enable-checking=all --enable-check-lisp-object-type --with-native-compilation=yes
>
> =======
> In file included from dispnew.c:27:
> In function ‘PSEUDOVECTORP’,
>     inlined from ‘FRAMEP’ at lisp.h:3343:10,
>     inlined from ‘FRAME_PARENT_FRAME’ at frame.h:1236:42,
>     inlined from ‘root_frame’ at dispnew.c:3340:10,
>     inlined from ‘is_in_matrix’ at dispnew.c:3877:24,
>     inlined from ‘is_cursor_obscured’ at dispnew.c:3898:8,
>     inlined from ‘terminal_cursor_magic’ at dispnew.c:3917:7,
>     inlined from ‘combine_updates_for_frame’ at dispnew.c:3970:5:
> lisp.h:1096:68: warning: null pointer dereference [-Wnull-dereference]
>  1096 |           && ((XUNTAG (a, Lisp_Vectorlike, union vectorlike_header)->size
>       |                                                                    ^
> =======
>
This one I don't see here, with clang 19. And I must admit I don't
understand it what it is complaining about. The function root_frame
is pretty simple:

  struct frame *
  root_frame (struct frame *f)
  {
    while (FRAME_PARENT_FRAME (f))
      f = FRAME_PARENT_FRAME (f);
    return f;
  }

and FRAME_PARENT_FFAME is

  INLINE struct frame *
  FRAME_PARENT_FRAME (struct frame *f)
  {
    return NILP (f->parent_frame) ? NULL : XFRAME (f->parent_frame);
  }

Any idea?



  reply	other threads:[~2024-12-19 12:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <173460276132.331083.7195719813421951970@vcs3.savannah.gnu.org>
     [not found] ` <20241219100603.94BA7C031EB@vcs3.savannah.gnu.org>
2024-12-19 10:52   ` master f92520d009e 1/2: Don't pause display for pending input Andrea Corallo
2024-12-19 11:17     ` Gerd Möllmann
2024-12-19 12:04       ` Andrea Corallo
2024-12-19 12:24         ` Gerd Möllmann [this message]
2024-12-19 12:44           ` Eli Zaretskii
2024-12-19 13:06             ` Gerd Möllmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2ed237tdi.fsf@gmail.com \
    --to=gerd.moellmann@gmail.com \
    --cc=acorallo@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=gerd@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).