From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: harfbuzz 2f72162: Fix crash in the Cairo build Date: Fri, 08 Feb 2019 15:38:52 +0100 Message-ID: References: <20181214085417.15440.18845@vcs0.savannah.gnu.org> <20181214085418.6616820538@vcs0.savannah.gnu.org> <831s6kgrtj.fsf@gnu.org> <83pnu4f45d.fsf@gnu.org> <837eg8dpd6.fsf@gnu.org> <83zhr6pqmr.fsf@gnu.org> <83womapgll.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="238409"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 08 15:39:36 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gs7JX-000zq5-UV for ged-emacs-devel@m.gmane.org; Fri, 08 Feb 2019 15:39:36 +0100 Original-Received: from localhost ([127.0.0.1]:57486 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gs7JW-0008Fw-V1 for ged-emacs-devel@m.gmane.org; Fri, 08 Feb 2019 09:39:34 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:39865) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gs7Iv-0008Dp-8t for emacs-devel@gnu.org; Fri, 08 Feb 2019 09:38:58 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gs7Iu-0006aL-F8 for emacs-devel@gnu.org; Fri, 08 Feb 2019 09:38:57 -0500 Original-Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]:44189) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gs7Iu-0006a2-9L; Fri, 08 Feb 2019 09:38:56 -0500 Original-Received: by mail-wr1-x42c.google.com with SMTP id v16so3776518wrn.11; Fri, 08 Feb 2019 06:38:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=5IX43yxCb9KLir8khiwVGah/EVjHOU1dab1ca/4p1qM=; b=LYQO5Za2ssI61cj8aNAFePJObyrq55MOSMwoi16uRulsgnJPPIgDT/6kZHei9IShLe kMjJKWBaiIeK1bfWS7ssRMHfmOKt9r1i/SxojqeHAbo9PBetOmFAf4GG1tJO6M9X7Cl2 D+tecHuCghompImYAnnUH6dofBz+BFo2/FNDa6hT5mHWSUJ+QKRjYrTSgxqxMXclg2NY xn0DIHKuocPG2w6Fjsv8YO7fLGcbwqLb035w2q8ynkxIQnG+RaVRLjFLD7xTpN55kBys nqjXiVj5zppEf8xDXHfm8OGkCxFmDY+vNxU4/Gw3HkLZcLv1jA0GAM2Da/Etjl8kn4RB BDhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=5IX43yxCb9KLir8khiwVGah/EVjHOU1dab1ca/4p1qM=; b=ZaV1kW0wZoDJx9Ebwhyeg74/nWGSkMrQQkqDD5X9/rPx7IShPszuiMIOJEmpmnKQcN 3RRsJluiXFMR79dkbVSZRs2bDZfAob7t3F/umYq/3hGIuKnizS07Y0UXXxv5Z7nGgJNr ZVV5+ynT0+tnnrccZYB/VUcs41k23xiUcYQDd9046pYUWw+bB6wSwVQx5gAyMHDG1m32 AwiUjpGad5iSgR5FBGHpogTU1rlcPvcRyrZAmGmffpYuZOe9kb8z1Qjo088hxM75I868 jgqAXYJsWcJx8KQle7QYdwX5W7T/DfqOekxHJS8fRkw366N5R+d7ADRjyrX7kLxyvDF4 r36Q== X-Gm-Message-State: AHQUAubKsuhkr3KbkrUU4DAy0B8k88LgU0crwba3iUvv9tFsy9B7+cJa weWXsaZkXA3Xx0c9gfxs1aoSEUh84Kc= X-Google-Smtp-Source: AHgI3IbFdKmC2nZyhHV8RgMTbttF5XRU76cEiuS65DtTnvYf3GELh2mRhOly5xOgmrWRRtnADeRxdg== X-Received: by 2002:adf:fcc8:: with SMTP id f8mr15860372wrs.192.1549636734579; Fri, 08 Feb 2019 06:38:54 -0800 (PST) Original-Received: from rpluim-mac ([2a01:e34:ecfc:a860:508e:f5c1:5162:8e85]) by smtp.gmail.com with ESMTPSA id y14sm1135809wro.92.2019.02.08.06.38.53 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 08 Feb 2019 06:38:53 -0800 (PST) In-Reply-To: <83womapgll.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 08 Feb 2019 15:14:30 +0200") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::42c X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233127 Archived-At: Eli Zaretskii writes: >> From: Robert Pluim >> Cc: emacs-devel@gnu.org >> Date: Fri, 08 Feb 2019 12:46:32 +0100 >>=20 >> >> ./configure # This builds xfont.o ftfont.o xftfont.o f= txfont.o >> > >> > I wonder why we build both xftfont.o and ftxfont.o, when we only use >> > one of them, if my reading of the code is correct. >> > >>=20 >> I did suggest removing ftxfont.o, but you said we had to deprecate it >> first. It=CA=BCs easy enough to not build in the HAVE_XFT config. > > That's orthogonal. Regardless of whether we want to drop ftxfont.c, I > don't understand why build with both xftfont.c and ftxfont.c. They > seem to be mutually exclusive, from the end-user POV. > Removing ftxfont.c from the HAVE_XFT build is the same as dropping it: configure.ac: ## We used to allow building with FreeType and without Xft. ## However, the ftx font backend driver is not in good shape. if test "$HAVE_XFT" !=3D "yes"; then dnl For the "Does Emacs use" message at the end. HAVE_XFT=3Dno HAVE_FREETYPE=3Dno else =20=20=20=20 elif test "$HAVE_XFT" =3D "yes"; then FONT_OBJ=3D"$FONT_OBJ ftfont.o xftfont.o ftxfont.o" elif test "$HAVE_FREETYPE" =3D "yes"; then FONT_OBJ=3D"$FONT_OBJ ftfont.o ftxfont.o" fi I don=CA=BCt mind either way: as you rightly point out, nobody can possibly be using it :-) >> >> I can cherry-pick this to the harfbuzz branch if you want. >> > >> > Thanks, please do. >>=20 >> Will do. > > TIA Done as 015a6e1df2 Robert