Re: harfbuzz 2f72162: Fix crash in the Cairo build

[Robert Pluim <rpluim@gmail.com>]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Robert Pluim <rpluim@gmail.com>
>> Cc: emacs-devel@gnu.org
>> Date: Fri, 08 Feb 2019 12:46:32 +0100
>> 
>> >> ./configure                # This builds xfont.o ftfont.o xftfont.o ftxfont.o
>> >
>> > I wonder why we build both xftfont.o and ftxfont.o, when we only use
>> > one of them, if my reading of the code is correct.
>> >
>> 
>> I did suggest removing ftxfont.o, but you said we had to deprecate it
>> first. Itʼs easy enough to not build in the HAVE_XFT config.
>
> That's orthogonal.  Regardless of whether we want to drop ftxfont.c, I
> don't understand why build with both xftfont.c and ftxfont.c.  They
> seem to be mutually exclusive, from the end-user POV.
>

Removing ftxfont.c from the HAVE_XFT build is the same as dropping it:

configure.ac:

    ## We used to allow building with FreeType and without Xft.
    ## However, the ftx font backend driver is not in good shape.
    if test "$HAVE_XFT" != "yes"; then
       dnl For the "Does Emacs use" message at the end.
       HAVE_XFT=no
       HAVE_FREETYPE=no
    else
    
  elif test "$HAVE_XFT" = "yes"; then
    FONT_OBJ="$FONT_OBJ ftfont.o xftfont.o ftxfont.o"
  elif test "$HAVE_FREETYPE" = "yes"; then
    FONT_OBJ="$FONT_OBJ ftfont.o ftxfont.o"
  fi

I donʼt mind either way: as you rightly point out, nobody can possibly
be using it :-)

>> >> I can cherry-pick this to the harfbuzz branch if you want.
>> >
>> > Thanks, please do.
>> 
>> Will do.
>
> TIA

Done as 015a6e1df2

Robert