From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: bug#40248: 27.0.90; Failure open .authinfo.gpg from Gnus Date: Tue, 31 Mar 2020 18:13:10 +0200 Message-ID: References: <86bloi1zrj.fsf@csic.es> <83lfnm8b30.fsf@gnu.org> <83ftdt9b1d.fsf@gnu.org> <86sght3h1s.fsf@csic.es> <834ku89anf.fsf@gnu.org> <87a740ub2r.fsf@gnus.org> <83tv287s9j.fsf@gnu.org> <874ku7txho.fsf@gnus.org> <83imin5l0w.fsf@gnu.org> <87blocrgtb.fsf@igel.home> <877dz0rf2v.fsf@igel.home> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="90542"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , Lars Ingebrigtsen , emacs-devel@gnu.org To: Andreas Schwab Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 31 18:14:12 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jJJWm-000NH3-73 for ged-emacs-devel@m.gmane-mx.org; Tue, 31 Mar 2020 18:14:12 +0200 Original-Received: from localhost ([::1]:41320 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJJWa-0006rw-78 for ged-emacs-devel@m.gmane-mx.org; Tue, 31 Mar 2020 12:14:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41206) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJJVr-00060L-GU for emacs-devel@gnu.org; Tue, 31 Mar 2020 12:13:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jJJVq-0004Gn-7a for emacs-devel@gnu.org; Tue, 31 Mar 2020 12:13:15 -0400 Original-Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]:32864) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jJJVq-0004GG-1Y; Tue, 31 Mar 2020 12:13:14 -0400 Original-Received: by mail-wr1-x430.google.com with SMTP id a25so26782917wrd.0; Tue, 31 Mar 2020 09:13:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=ly8mfNRcxpGaqc2t6XLaUWzbYsus/lamFV2AaK1x0qE=; b=V4OsiLghjQtuBlh+FNH2dhaFi5wSjHnTfm/uhIpRWsESUr3h5mlBoI5FG9ii1cKCbC ifWTfE/BD6269hUzF63S9wGZ2ZTDBvZTjYgnK3vacIW+FezSlZ9+TzXU5O9+lHBlYgv2 z7ZUxI6cjgq8W5Dnsj0T2AEFIxovppUrNIBDgAnyx25Q5JLfz+GPGwZmmM9DYzvbOGpb ZiBy+U7h9Uz/1tyTF1Vi3abrHGk7+Gxp0JbGpql9PXalR7bAGv6n5obv604CN4sdbFwv 9+TpFqer6G6OXGlvg14c1M5jHWsxh/c2oDEyCV7fUc5+A/b+2P9ZfWHtBmSkByDAWKI+ 5X3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=ly8mfNRcxpGaqc2t6XLaUWzbYsus/lamFV2AaK1x0qE=; b=huG4F5eKQjWeFaOcaS2xVtCSQku2KPBaeJftD08WJd9fctmFUCqYAAmyfLbWqqtrvS voeTeGbXG0V21n9CbVkylKlkDEw4n+kiFPJGOw8mCpNCcuXt7JVea5lPvQBNZhzBRYjb t6xiSPEXQbOEMexgW5HrEkHh9bHhWnlqiSTp6MU1MC7SZ6TQEqU46/55Kcx7joQyTOjT WI3y4EnzOc+ms9F5B4w59sHJI6tCp1KRXr+loPmN3OybGyVxJX1V7X6ofrzeySxACkJS wdN3xKPqu2Mpte5QcK7I3z/zeojzimwl1MlrF0DtY6t3q6YG7kORmxaJceXWI4nufM3R q4vw== X-Gm-Message-State: ANhLgQ3OoxIoOjTZF/3eCCT8IlZLiyTbqsxMz7WKOcUqy0SpAFgeTcsI CJUw5keQ0jx9PHz3wYHtPX32xuG8 X-Google-Smtp-Source: ADFU+vtf69W18bqarByBkArRzLcJaif5xM99W2IElzr48eHstv5WAZmD8HfOYcV1r4TnfzE7c2DfSg== X-Received: by 2002:a5d:468c:: with SMTP id u12mr22667881wrq.394.1585671191789; Tue, 31 Mar 2020 09:13:11 -0700 (PDT) Original-Received: from rpluim-mac ([2a01:e34:ecfc:a860:65f2:9a92:2c96:9204]) by smtp.gmail.com with ESMTPSA id f12sm23815212wrm.94.2020.03.31.09.13.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2020 09:13:11 -0700 (PDT) In-Reply-To: (Robert Pluim's message of "Tue, 31 Mar 2020 13:09:14 +0200") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::430 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:246118 Archived-At: >>>>> On Tue, 31 Mar 2020 13:09:14 +0200, Robert Pluim s= aid: >>>>> On Tue, 31 Mar 2020 12:31:04 +0200, Andreas Schwab said: Andreas> On M=C3=A4r 31 2020, Robert Pluim wrote: >>> My reading of set_network_socket_coding_system is that having a pli= st >>> in make-network-process with :coding nil overrides a non-nil >>> coding-system-for-{read-write}, which I don=CA=BCt think we want. Andreas> You are right, make-network-process and make-serial-process ha= ndle that Andreas> differently than make-process and make-pipe-process. I think = this is a Andreas> bug, they should all handle :coding nil the same (same as abse= nce). Robert> I think I agree with that. Basically this, initially (and the s= ame for Robert> make-serial-process) Now that I=CA=BCve actually tested it, the change looks like this, making make-network-process and make-serial process behave the same as make-process and make-pipe-process. I=CA=BCve looked at all uses of those two functions in Emacs' sources, and none of them depend on the change in semantics, in fact only a couple of them actually pass a :coding keyword. Having said all that, this does go back a looooong way (2002 at least), so maybe we want to let sleeping dogs lie. diff --git a/src/process.c b/src/process.c index e18a5aa538..2db45b18b2 100644 --- a/src/process.c +++ b/src/process.c @@ -3205,14 +3206,12 @@ DEFUN ("make-serial-process", Fmake_serial_process,= Smake_serial_process, BUF_ZV_BYTE (XBUFFER (buffer))); } =20 - tem =3D Fplist_member (contact, QCcoding); - if (!NILP (tem) && (!CONSP (tem) || !CONSP (XCDR (tem)))) - tem =3D Qnil; + tem =3D Fplist_get (contact, QCcoding); =20 val =3D Qnil; if (!NILP (tem)) { - val =3D XCAR (XCDR (tem)); + val =3D tem; if (CONSP (val)) val =3D XCAR (val); } @@ -3226,7 +3225,7 @@ DEFUN ("make-serial-process", Fmake_serial_process, S= make_serial_process, val =3D Qnil; if (!NILP (tem)) { - val =3D XCAR (XCDR (tem)); + val =3D tem; if (CONSP (val)) val =3D XCDR (val); } @@ -3261,16 +3260,14 @@ set_network_socket_coding_system (Lisp_Object proc,= Lisp_Object host, Lisp_Object coding_systems =3D Qt; Lisp_Object val; =20 - tem =3D Fplist_member (contact, QCcoding); - if (!NILP (tem) && (!CONSP (tem) || !CONSP (XCDR (tem)))) - tem =3D Qnil; /* No error message (too late!). */ + tem =3D Fplist_get (contact, QCcoding); =20 /* Setup coding systems for communicating with the network stream. */ /* Qt denotes we have not yet called Ffind_operation_coding_system. */ =20 if (!NILP (tem)) { - val =3D XCAR (XCDR (tem)); + val =3D tem; if (CONSP (val)) val =3D XCAR (val); } @@ -3304,7 +3301,7 @@ set_network_socket_coding_system (Lisp_Object proc, L= isp_Object host, =20 if (!NILP (tem)) { - val =3D XCAR (XCDR (tem)); + val =3D tem; if (CONSP (val)) val =3D XCDR (val); }