From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrii Kolomoiets Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Support "\n" in icomplete-separator Date: Sun, 08 Nov 2020 22:14:07 +0200 Message-ID: References: <20201105235735.oxouuek66ehu5o45@Ergus> <20201106151541.dpgep7borlja25su@Ergus> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12451"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) Cc: eliz@gnu.org, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Nov 08 21:14:56 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kbr5U-00039G-9x for ged-emacs-devel@m.gmane-mx.org; Sun, 08 Nov 2020 21:14:56 +0100 Original-Received: from localhost ([::1]:37714 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kbr5T-0002PF-B2 for ged-emacs-devel@m.gmane-mx.org; Sun, 08 Nov 2020 15:14:55 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48488) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kbr4p-0001yu-G2 for emacs-devel@gnu.org; Sun, 08 Nov 2020 15:14:15 -0500 Original-Received: from mail-lj1-x233.google.com ([2a00:1450:4864:20::233]:40515) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kbr4n-00055T-5s; Sun, 08 Nov 2020 15:14:15 -0500 Original-Received: by mail-lj1-x233.google.com with SMTP id 23so7612196ljv.7; Sun, 08 Nov 2020 12:14:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=EVRKht8eUgi4i+5gx8RCap9swev2uwYt00dpHTa+4d0=; b=L2xBOzUyf13USb0J6vRcW1f8nxQvg6tjd6RQoL+7pZhbHUUbFGO6lrxurIqWhYAUp6 BLDSQX1IGMdt0dpwIJrH9UwJevk3YNWKdSAxrZTRE2DToSNv12Q9bldhz1bR+OTzyfd1 ObPlwe03Wu1k/rxP7f/4yO5vYk4fTFrFvh0cWFdfZXd0mpNyyvt0IenMFTHSUhbT7np6 rebJvfN5peaObjN5dKDEy01qYnR/TUmRfULZ2sACBMkt0NbAn4y2ZFUKLRJalfGonXPW ETYVVB8ZCSQPl7tExzzpOkuHfAqg+nqGMB2C9ZasGwdqml38Rhrz0TI5JYS9qbZCybie jOAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=EVRKht8eUgi4i+5gx8RCap9swev2uwYt00dpHTa+4d0=; b=mE+FVNsA2Z5jriDtWF6PyjuZA8rpTCaoqjFLV3npI7T/YxirBYMn86RIzDWcp5XCQR gcvACpMcLjzVMhDYKTPWzSww5lTrDnqZDljn39wqWj52UpsvZ/vLSJsIBpoUg0lB0Vb8 7RQTHPISa0WSWFTaMDDXrkGJkn1NNMM6KlV1id71fd4qxfnJmg08tdkpvILQEr6DthJF Y48cRYCb8fRh+m8t45dICiu3MZu3vJoLabJV1apLShM3zBlkNO4augWC/Pj16Di0k96y G1ajZNCuHV7Mrf0gNl+/EIs4BNENFKofHYBnshvyIJ1zOj9tiv1HPLPlIIT49MzAJFru rIxQ== X-Gm-Message-State: AOAM531t93IDeMKsg3AOQ7i6f4o32Qkh/HzZPMniYuWjqU1pXdzOE+Iy DrDjWhvrPBsfhhLJRnGj/8uZwOQknnP1fw== X-Google-Smtp-Source: ABdhPJwzOlpW+TLcs+J81bs/YJG7pAALHLumJyReYa5iJxHRGGCA8ghHFZs1ZIOcBVI5Dkh2ZyXyTQ== X-Received: by 2002:a05:651c:1b7:: with SMTP id c23mr1321256ljn.112.1604866450008; Sun, 08 Nov 2020 12:14:10 -0800 (PST) Original-Received: from muffinmac ([91.206.110.192]) by smtp.gmail.com with ESMTPSA id t20sm242614lff.153.2020.11.08.12.14.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Nov 2020 12:14:09 -0800 (PST) In-Reply-To: <20201106151541.dpgep7borlja25su@Ergus> (Ergus's message of "Fri, 6 Nov 2020 16:15:41 +0100") Received-SPF: pass client-ip=2a00:1450:4864:20::233; envelope-from=andreyk.mad@gmail.com; helo=mail-lj1-x233.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258924 Archived-At: Ergus writes: I've checked your receipts on nearly recent master with the patch applied on GTK3 build under Gnome and on NS build. >> I propose use the 'icomplete-prospects-height' value as the count of >> completions that must be shown. >> > Yes, I understand that; actually the height calculation was made because > of this: > > (defface vmacs-minibuffer-font > `((t :inherit default :height 1.3)) > > Up to some months ago the pixel calculation was required because showing > more candidates than fit in the minibuffer hided the prompt. There were > long discussions related with that. With changed minibuffer font size the prompt is visible. >>> multiple \n in the separator > This of course is supposed to work. But try with more candidates like 10 Prompt is still visible. >>> display the completions in window-only frames like in mapple >> >> Thats actually why the patch was implemented. See, >> maple-minibuffer-mode uses fixed frame height so the branch is show some >> completions that fits based on frame-pixel-height. But mini-frame-mode, >> which I use, uses resizeable minibuffer-only frame to show the >> minibuffer content and the branch doesn't show any completions. >> I mention this issue earlier: >> https://lists.gnu.org/archive/html/emacs-devel/2020-11/msg00124.html >> >> In this usecase the patch behave better. >> > I can't reproduce the issue, that's why I didn't reply; sorry. What build/OS you are using? I can reproduce it at least on NS and GTK3 builds. Doesn't minibuffer-only frame became the minimal width and height for you right after evaluating '(setq resize-mini-frames t)'? > In your use case I suppose it works "better" because the patch totally > ignores the window height to fit; which, as I mention before, I am not > sure is something we can do in the general case due to the prompt > issue. > > If the prompt issue is totally away, we could; but I will need some > confirmation from Eli or Stefan; but last time I tried it was still > there. I didn't saw the prompt issue. Stefan and Eli, can you please confirm that the prompt issue is totally gone? Thanks.