From: Filipp Gunbin <fgunbin@fastmail.fm>
To: emacs-devel@gnu.org
Subject: Don't move to eol in end-of-defun?
Date: Wed, 27 Jul 2022 15:40:57 +0300 [thread overview]
Message-ID: <m2czdqybhi.fsf@fastmail.fm> (raw)
In Java, it's a common style to have hanging parentheses:
class C <1>{<2>
void foo() {
}<3>
}<4>
If we're at position <1> and press C-M-e, then it's logical to move to
<4>, and that's what I implement in javaimp package, by defining my own
beginning-of-defun-function / end-of-defun-function. But end-of-defun
first calls (end-of-line 1), before doing everything else, and so my
function finds itself at <2>! And moves to <3>.
OTOH, end-of-defun is documented to move to "next end of defun", and one
could say that moving from <1> to <3> is just that. I can agree, but
then I get strange behavior of narrow-to-defun, mark-defun and others,
because they rely on beginning / end of defun.
I can suggest this patch, but I don't very much like it.
Thoughts?
TIA
Filipp
diff --git a/lisp/emacs-lisp/lisp.el b/lisp/emacs-lisp/lisp.el
index 4b85414943..cc8185e453 100644
--- a/lisp/emacs-lisp/lisp.el
+++ b/lisp/emacs-lisp/lisp.el
@@ -507,6 +507,13 @@ end-of-defun-function
So the function can assume that point is at the beginning of the defun body.
It should move point to the first position after the defun.")
+(defvar end-of-defun-moves-to-eol t
+ "Defines whether `end-of-defun' moves to eol before doing
+everything else.
+
+Set this to nil in major mode if this movement affects mode's
+decisions about context in an unwanted way.")
+
(defun buffer-end (arg)
"Return the \"far end\" position of the buffer, in direction ARG.
If ARG is positive, that's the end of the buffer.
@@ -538,7 +545,9 @@ end-of-defun
(push-mark))
(if (or (null arg) (= arg 0)) (setq arg 1))
(let ((pos (point))
- (beg (progn (end-of-line 1) (beginning-of-defun-raw 1) (point)))
+ (beg (progn (when end-of-defun-moves-to-eol
+ (end-of-line 1))
+ (beginning-of-defun-raw 1) (point)))
(skip (lambda ()
;; When comparing point against pos, we want to consider that
;; if point was right after the end of the function, it's
next reply other threads:[~2022-07-27 12:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-27 12:40 Filipp Gunbin [this message]
2022-07-30 23:40 ` Don't move to eol in end-of-defun? Daniel Martín
2022-07-31 22:31 ` Filipp Gunbin
2022-08-01 17:50 ` Alan Mackenzie
2022-08-01 20:49 ` Filipp Gunbin
2022-08-01 22:01 ` Filipp Gunbin
2022-08-03 3:46 ` Richard Stallman
2022-08-03 12:37 ` Filipp Gunbin
2022-08-04 4:04 ` Richard Stallman
2022-08-04 14:58 ` Filipp Gunbin
2022-08-06 3:41 ` Richard Stallman
2022-08-06 9:33 ` Alan Mackenzie
2022-08-07 4:24 ` Richard Stallman
2022-08-08 14:29 ` Filipp Gunbin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2czdqybhi.fsf@fastmail.fm \
--to=fgunbin@fastmail.fm \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).