From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrew Hyatt Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: triples Date: Thu, 27 Oct 2022 01:15:10 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9748"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, Tom Gillespie To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Oct 27 07:17:41 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1onvGv-0002O3-6o for ged-emacs-devel@m.gmane-mx.org; Thu, 27 Oct 2022 07:17:41 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1onvEa-0007zr-M5; Thu, 27 Oct 2022 01:15:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1onvEZ-0007kf-1I for emacs-devel@gnu.org; Thu, 27 Oct 2022 01:15:15 -0400 Original-Received: from mail-qv1-xf32.google.com ([2607:f8b0:4864:20::f32]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1onvEX-0006zB-Gs for emacs-devel@gnu.org; Thu, 27 Oct 2022 01:15:14 -0400 Original-Received: by mail-qv1-xf32.google.com with SMTP id i12so369375qvs.2 for ; Wed, 26 Oct 2022 22:15:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=f4SmlAxiRSuygq9ZndOokTBCws6yxeVi2wYW8CflRTs=; b=R//3BkidC6HT9lsXuiPDM2yNyAkkftEC9HZ5SIvJr+ImuNtWZB+3hL1YwdYM38JWcd Y9ToWHtDXKPIFBjPBLm9sBG/G3QoMqg5QthiLiX0Nj7CC+IcSXyFptJV+l0ppKl3a/i4 2h4rHOEPKM7X93UDSr21GtjPK5hcdAuRFsEyCjUbhcysqHDR5xB4J1pihW5bQUrt//38 OlCUkMm3SY7m2mDs1d9cwkjmMhWono2sEnpDTP1JJIjJHMyerUQaP83XW2vBBVUPzaFS vmevo9RKp1xU4B7Bknp9AvmK3gcCzRHwS4IcE8Fp7zHaiHmswKkuItq9JpUCKd+Qkr6R qw7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=f4SmlAxiRSuygq9ZndOokTBCws6yxeVi2wYW8CflRTs=; b=2E/vicCVMITDJIk/Sfnn+eoeudqgeX751/c0ZfFPonwNyScdGizkAE/CUgwNrKoLiQ RtzTKA+SkUnBSErwHSWQFCq/pS+XAqy4FWnDwwEZ808/K7e5T74PY1xUymjllSCgM5z9 rbUHiIRsqix6g/i0lrsWi6CYyzAK+mUn3CkWI1imn07Xr8s07zIUYMPzgAJMIzOX8QIk 0HDSubkAIoPovOxMrQ+Uj2D6D5E5G2q1GLFSKYRnB9Wx2QZy2YAWOxklaCE/9tnGXqjZ 64tlfJr8gv/Kmk++gusRJnVlmZcRq/hejOqjlWIOY/FnRjq+epmqt8eF8HjhB3xovlRd okmw== X-Gm-Message-State: ACrzQf3RLDEPpalRf2sTctXv9puMbdxdoMLIZFZL7eGS1wkfFksrsM3i 2mmKeWz9zaJP5LdJzGDC+Zw= X-Google-Smtp-Source: AMsMyM6HIfmZiG+BTOo4ew38L1AejnRlI7jeRQPBxOga7aXPaXRRCeYTdg/KAzvmnocOe4vlKqTiwg== X-Received: by 2002:ad4:594b:0:b0:4bb:6e7d:6c63 with SMTP id eo11-20020ad4594b000000b004bb6e7d6c63mr16768628qvb.86.1666847711911; Wed, 26 Oct 2022 22:15:11 -0700 (PDT) Original-Received: from andrews-mbp.lan (pool-71-183-193-81.nycmny.fios.verizon.net. [71.183.193.81]) by smtp.gmail.com with ESMTPSA id j4-20020a05620a410400b006cfc01b4461sm347236qko.118.2022.10.26.22.15.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Oct 2022 22:15:11 -0700 (PDT) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::f32; envelope-from=ahyatt@gmail.com; helo=mail-qv1-xf32.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:298600 Archived-At: On Wed, Oct 26, 2022 at 09:29 AM Stefan Monnier wrote: >> Yes, it's possible for me to rework it. However, it then would >> be available just to those on Emacs 29, which seems >> restrictive. Would it make sense to try to be compatible with >> both by wrapping the calls and just using whichever sqlite >> package is available? > > That's what I was hoping for, yes. But either way is fine by me > :-) > I've started looking into this. Interesting consideration is that emacsql and sqlite have a bit different representations: in sqlite everything is a string, but emacsql will store symbols, numbers differently than strings, which are wrapped in the database with extra quotes to mark them as strings. I'll try to keep compatibility between these versions, which really I think means that our use of sqlite has to support emacsql's way of doing things. About the possibility of using one or the other, whichever is available, how would that work in terms of package dependencies? I don't think it's possible to have an OR dependency specified in the package-dependencies line in the source, but really only one of emacsql or emacs29 would be required. If you have any insight into this, it'd be useful. >> Anyway, it doesn't hurt for me to make a branch and just >> completely switch to the Emacs 29 sqlite to see if anything >> interesting comes up, so I'll do that soon. > > It's probably a good first step in any case, before deciding if > and how to merge the two cases. Great, that is what I'm doing. When it passes tests, I'll let you know. > > > Stefan