Re: [Emacs-diffs] emacs-25 8ff888a: Improve fix for regex reentrancy abort

Re: [Emacs-diffs] emacs-25 8ff888a: Improve fix for regex reentrancy abort

[Ken Brown]

On 11/16/2015 4:10 PM, Paul Eggert wrote:
> branch: emacs-25
> commit 8ff888a07d0500f1274723086469191aade0a33e
> Author: Paul Eggert <eggert@cs.ucla.edu>
> Commit: Paul Eggert <eggert@cs.ucla.edu>
>
>      Improve fix for regex reentrancy abort
>
>      Suggested by Stefan Monnier (Bug#21688).
>      * src/syntax.c (update_syntax_table_forward):
>      Remove recently-added PROPERTIZE arg, and assume it is true.
>      All callers changed.
>      * src/syntax.h (UPDATE_SYNTAX_TABLE_FORWARD_FAST):
>      Invoke update_syntax_table directly.

The message-mode-propertize test fails after this commit.

$ make -C test/automated/ message-mode-tests

Test message-mode-propertize backtrace:
   #[0 "\303\304!r\211q\210\305\306\307\310\311!\312\"\313$\216\314\21
   ert--run-test-internal([cl-struct-ert--test-execution-info [cl-struc
   ert-run-test([cl-struct-ert-test message-mode-propertize nil #[0 "\3
   ert-run-or-rerun-test([cl-struct-ert--stats t [[cl-struct-ert-test m
   ert-run-tests(t #[385 "\306\307\"\203G\211\211G\310U\203\211@\20
   ert-run-tests-batch(nil)
   ert-run-tests-batch-and-exit()
   command-line-1(("-L" ":../../../emacs-25/test/automated" "-l" "ert"
   command-line()
   normal-top-level()
Test message-mode-propertize condition:
     (ert-test-failed
      ((should
        (string= "here's an opener "
                 (buffer-substring-no-properties ... ...)))
       :form
       (string= "here's an opener " "here's a sad face :-")
       :value nil))
    FAILED  1/1  message-mode-propertize

Ken

Re: [Emacs-diffs] emacs-25 8ff888a: Improve fix for regex reentrancy abort

[John Wiegley]

>>>>> Ken Brown <kbrown@cornell.edu> writes:

>> branch: emacs-25
>> commit 8ff888a07d0500f1274723086469191aade0a33e
> The message-mode-propertize test fails after this commit.

Let's make sure all tests are run prior to any commits on the emacs-25 branch.
This may be a case where it doesn't break on the committer's machine; but I'll
let Paul speak to that.

John

Re: [Emacs-diffs] emacs-25 8ff888a: Improve fix for regex reentrancy abort

[Paul Eggert]

John Wiegley wrote:
> This may be a case where it doesn't break on the committer's machine; but I'll
> let Paul speak to that.

Here, the bug fix (fixing a core dump when searching) was more important than 
the test case (whether a smiley face is properly parsed :-). I haven't had time 
yet to investigate the test case, but I'll try to get around to it eventually. 
The smiley-face problem is lower priority than some of the other problems I have 
right now (e.g., Emacs doesn't build for me with the recent dynamic module 
additions).