Re: [NonGNU ELPA] new package: clangd-inactive-regions

["Gerd Möllmann" <gerd.moellmann@gmail.com>]

Filippo Argiolas <filippo.argiolas@gmail.com> writes:

> I'm not exactly an elisp expert, so feedback is very welcome!

Works fine for me on macOS 15.1/tty with clangd 19.1 from Homebrew.
Thanks, that's a nice feature!

You said you are interested in feedback, so here's my wishlist :-).

- I'd preferred a global minor mode to turn this on and off.
  Which would replace the manual adding to the Eglot hook.

- I think something is to be up with the faces? If I remove

  (clangd-inactive-regions-set-method "darken-foreground")
  (clangd-inactive-regions-set-opacity 0.55))

  from the use-package in my init file, which is

  (use-package clangd-inactive-regions
    :straight (:host github
                     :repo "fargiolas/clangd-inactive-regions.el"
                     :branch "master"
                     :files ("*.el"))
    :init
    (add-hook 'eglot-managed-mode-hook #'clangd-inactive-regions-mode)
    :config
    (clangd-inactive-regions-set-method "darken-foreground")
    (clangd-inactive-regions-set-opacity 0.55))

  the inactive regions are not shown, I think. If I put them in, they
  are.

- Maybe some of the defvar could be defcustoms?