unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* trivial patch to comint.el
@ 2007-07-06  4:39 Sean O'Rourke
  2007-07-06 15:26 ` Sean O'Rourke
  2007-07-12  4:15 ` Stefan Monnier
  0 siblings, 2 replies; 3+ messages in thread
From: Sean O'Rourke @ 2007-07-06  4:39 UTC (permalink / raw)
  To: emacs-devel

comint-dynamic-complete-as-filename should probably use
read-file-name-completion-ignore-case instead of a test on
system-type.

/s

Index: comint.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/comint.el,v
retrieving revision 1.361
diff -u -r1.361 comint.el
--- comint.el	2 Apr 2007 14:01:02 -0000	1.361
+++ comint.el	6 Jul 2007 04:38:25 -0000
@@ -2805,7 +2804,7 @@
 (defun comint-dynamic-complete-as-filename ()
   "Dynamically complete at point as a filename.
 See `comint-dynamic-complete-filename'.  Returns t if successful."
-  (let* ((completion-ignore-case (memq system-type '(ms-dos windows-nt cygwin)))
+  (let* ((completion-ignore-case read-file-name-completion-ignore-case)
 	 (completion-ignored-extensions comint-completion-fignore)
 	 ;; If we bind this, it breaks remote directory tracking in rlogin.el.
 	 ;; I think it was originally bound to solve file completion problems,

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: trivial patch to comint.el
  2007-07-06  4:39 trivial patch to comint.el Sean O'Rourke
@ 2007-07-06 15:26 ` Sean O'Rourke
  2007-07-12  4:15 ` Stefan Monnier
  1 sibling, 0 replies; 3+ messages in thread
From: Sean O'Rourke @ 2007-07-06 15:26 UTC (permalink / raw)
  To: emacs-devel

2007-07-06  Sean O'Rourke  <sorourke@cs.ucsd.edu> (tiny change)

	* comint.el (comint-dynamic-complete-as-filename): bind
	  completion-ignore-case to read-file-name-completion-ignore-case.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: trivial patch to comint.el
  2007-07-06  4:39 trivial patch to comint.el Sean O'Rourke
  2007-07-06 15:26 ` Sean O'Rourke
@ 2007-07-12  4:15 ` Stefan Monnier
  1 sibling, 0 replies; 3+ messages in thread
From: Stefan Monnier @ 2007-07-12  4:15 UTC (permalink / raw)
  To: Sean O'Rourke; +Cc: emacs-devel

> comint-dynamic-complete-as-filename should probably use
> read-file-name-completion-ignore-case instead of a test on
> system-type.

Installed, together with the pcomplete.el patch.


        Stefan

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-07-12  4:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-06  4:39 trivial patch to comint.el Sean O'Rourke
2007-07-06 15:26 ` Sean O'Rourke
2007-07-12  4:15 ` Stefan Monnier

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).