unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: John Wiegley <jwiegley@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: joakim@verona.se, Emacs developers <emacs-devel@gnu.org>
Subject: Re: merging the xwidget_mvp branch
Date: Fri, 06 Nov 2015 16:21:56 -0500	[thread overview]
Message-ID: <m2a8qq6cy3.fsf@newartisans.com> (raw)
In-Reply-To: <jwvmvutlw1b.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Wed, 04 Nov 2015 08:52:25 -0500")

>>>>> Stefan Monnier <monnier@iro.umontreal.ca> writes:

> We've already been through several rounds of reviewing, so I'm sure he'd be
> very disappointed if it doesn't get the code merged after all those efforts.

> And IIRC the technical debt seemed quite OK: the interaction between
> xwidget's own code (the part that deals with the xwidget API) and Emacs's
> own code is very similar to the interaction between Emacs and the various
> image libraries.

Since this review was done under your tenure, Stefan, I'll defer to your
judgment on this one. I generally have an aversion to large new features
without a driving use case, but you deserve at least one "midnight
appointment". :)

John



  reply	other threads:[~2015-11-06 21:21 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-03 21:18 merging the xwidget_mvp branch joakim
2015-11-03 21:23 ` John Wiegley
2015-11-03 21:37   ` joakim
2015-11-03 21:51     ` John Wiegley
2015-11-04 11:01       ` Nicolas Petton
2015-11-04 16:37         ` raman
2015-11-04 17:22           ` Michael Abrahams
2015-11-04 13:52       ` Stefan Monnier
2015-11-06 21:21         ` John Wiegley [this message]
2015-11-08 16:34           ` joakim
2015-11-08 17:13             ` Eli Zaretskii
2015-11-09 19:53               ` Join us on emacs-tangents! (was: merging the xwidget_mvp branch) John Wiegley
2015-11-09 20:08                 ` Join us on emacs-tangents! Rasmus
2015-11-09 21:31                   ` John Wiegley
2015-11-09 20:17                 ` Dmitry Gutov
2015-11-09 21:30                   ` John Wiegley
2015-11-09 23:58                 ` Join us on emacs-tangents! (was: merging the xwidget_mvp branch) Aaron Ecay
2015-11-10 10:47                   ` Join us on emacs-tangents! Jose E. Marchesi
2015-11-11 10:33           ` merging the xwidget_mvp branch joakim
2015-11-11 16:32             ` John Wiegley
2015-11-04 15:29       ` Eli Zaretskii
2015-11-05 12:13 ` Nicolas Petton
2015-11-05 12:19   ` joakim
2015-11-08 16:32   ` joakim
2015-11-09  9:17     ` Nicolas Petton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2a8qq6cy3.fsf@newartisans.com \
    --to=jwiegley@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=joakim@verona.se \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).