From: "Sean O'Rourke" <sorourke@cs.ucsd.edu>
To: emacs-devel@gnu.org
Subject: remove dabbrev--scanning-message?
Date: Sun, 22 Jul 2007 22:16:36 -0700 [thread overview]
Message-ID: <m28x97aedn.fsf@cs.ucsd.edu> (raw)
[-- Attachment #1: Type: text/plain, Size: 497 bytes --]
When `dabbrev-expand' is invoked with many buffers and it fails
to find an expansion, there is an annoying forced pause while it
scans every buffer and emits uninteresting progress messages. If
these messages are removed, a failed expansion is nearly
instantaneous, so I don't see any benefit to having progress
messages. Patch attached.
/s
2007-07-22 Sean O'Rourke <sorourke@cs.ucsd.edu>
* dabbrev.el (dabbrev--scanning-message): removed.
(dabbrev--find-expansion): remove calls.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1408 bytes --]
Index: dabbrev.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/dabbrev.el,v
retrieving revision 1.85
diff -u -r1.85 dabbrev.el
--- dabbrev.el 16 May 2007 13:13:20 -0000 1.85
+++ dabbrev.el 23 Jul 2007 05:07:50 -0000
@@ -711,10 +711,6 @@
(setq all-expansions (cons expansion all-expansions))))
all-expansions))
-(defun dabbrev--scanning-message ()
- (unless (window-minibuffer-p (selected-window))
- (message "Scanning `%s'" (buffer-name (current-buffer)))))
-
(defun dabbrev--ignore-buffer-p (buffer)
"Return non-nil if BUFFER should be ignored by dabbrev."
(let ((bn (buffer-name buffer)))
@@ -740,8 +736,7 @@
;; If we were scanning something other than the current buffer,
;; continue scanning there.
(when dabbrev--last-buffer
- (set-buffer dabbrev--last-buffer)
- (dabbrev--scanning-message))
+ (set-buffer dabbrev--last-buffer))
(or
;; ------------------------------------------
;; Look backward in current buffer.
@@ -781,7 +776,6 @@
(while (and (not expansion) dabbrev--friend-buffer-list)
(setq dabbrev--last-buffer (pop dabbrev--friend-buffer-list))
(set-buffer dabbrev--last-buffer)
- (dabbrev--scanning-message)
(setq dabbrev--last-expansion-location (point-min))
(setq expansion (dabbrev--try-find abbrev nil 1 ignore-case)))
expansion)))))
[-- Attachment #3: Type: text/plain, Size: 142 bytes --]
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
next reply other threads:[~2007-07-23 5:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-23 5:16 Sean O'Rourke [this message]
2007-07-23 8:37 ` remove dabbrev--scanning-message? Thien-Thi Nguyen
2007-07-23 13:40 ` Sean O'Rourke
2007-07-23 19:19 ` Eli Zaretskii
2007-07-23 19:18 ` Eli Zaretskii
2007-07-24 16:46 ` Richard Stallman
2007-07-24 17:16 ` Sean O'Rourke
2007-07-23 22:30 ` Richard Stallman
2007-07-23 22:58 ` Sean O'Rourke
2007-07-23 23:18 ` Thien-Thi Nguyen
2007-07-24 0:40 ` Sean O'Rourke
2007-07-24 22:16 ` Richard Stallman
2007-08-22 1:35 ` Thien-Thi Nguyen
2007-08-22 1:49 ` Sean O'Rourke
2007-08-22 21:27 ` Richard Stallman
2007-08-23 9:38 ` Thien-Thi Nguyen
2007-08-22 19:49 ` Thien-Thi Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m28x97aedn.fsf@cs.ucsd.edu \
--to=sorourke@cs.ucsd.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).