From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: charles@aurox.ch (Charles A. Roelli) Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master abd1825: Ensure that we can find definitions when buffer is narrowed Date: Tue, 12 Dec 2017 20:25:46 +0100 Message-ID: References: <20171210145422.30001.90205@vcs0.savannah.gnu.org> <20171210145424.0E878211A6@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1513106624 21939 195.159.176.226 (12 Dec 2017 19:23:44 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 12 Dec 2017 19:23:44 +0000 (UTC) Cc: me@wilfred.me.uk, emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 12 20:23:35 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOq9O-0005GK-8I for ged-emacs-devel@m.gmane.org; Tue, 12 Dec 2017 20:23:34 +0100 Original-Received: from localhost ([::1]:60127 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eOq9V-0005uQ-Dg for ged-emacs-devel@m.gmane.org; Tue, 12 Dec 2017 14:23:41 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54888) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eOq8t-0005u9-J3 for emacs-devel@gnu.org; Tue, 12 Dec 2017 14:23:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eOq8q-00021H-9e for emacs-devel@gnu.org; Tue, 12 Dec 2017 14:23:03 -0500 Original-Received: from [2a03:2040:2:1b::1] (port=49542 helo=sinyavsky.aurox.ch) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eOq8q-00020G-2C for emacs-devel@gnu.org; Tue, 12 Dec 2017 14:23:00 -0500 Original-Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id CF6B8225F8 for ; Tue, 12 Dec 2017 19:15:21 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= content-transfer-encoding:content-type:content-type:mime-version :references:subject:subject:in-reply-to:to:from:from:message-id :date:date; s=dkim; t=1513106120; x=1513970121; bh=MMtuRLJqMjEMb 70RSHxRjKCyn2rxlcvjailKfLpqKtw=; b=dbX8sBfnI2MczcXueGmPfFmzcydYD iyK/aQjXfTsaDF7evlh94B3Jkva6bOh1buB+8fCzp++xGFY9WvuNcevSc7DUdVv1 uRwSUrpbmqG0IpzgD2CoAjOks6qVOUEYAVUejjPavB2zOW409d1VX8sXJLmZWqJr GdHO+mpbrnIVeo= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Original-Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id kxZB6T4i-mnR for ; Tue, 12 Dec 2017 19:15:20 +0000 (UTC) Original-Received: from gray (125.85.192.178.dynamic.wline.res.cust.swisscom.ch [178.192.85.125]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id 94458225ED; Tue, 12 Dec 2017 19:15:19 +0000 (UTC) In-reply-to: (message from Dmitry Gutov on Tue, 12 Dec 2017 17:11:29 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a03:2040:2:1b::1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:220942 Archived-At: > From: Dmitry Gutov > Date: Tue, 12 Dec 2017 17:11:29 +0200 >=20 > On 12/11/17 10:23 PM, Charles A. Roelli wrote: >=20 > > Thanks for fixing this. If I may suggest it, it might also be useful > > for these functions to respect `widen-automatically': >=20 > Probably not find-function-search-for-symbol though? Yes, you are right. > > widen-automatically is a variable defined in =E2=80=98simple.el=E2= =80=99. > > Its value is t > >=20 > > Documentation: > > Non-nil means it is ok for commands to call =E2=80=98widen=E2=80=99= when they want to. > > Some commands will do this in order to go to positions outside > > the current accessible part of the buffer. > >=20 > > If =E2=80=98widen-automatically=E2=80=99 is nil, these commands wi= ll do something else > > as a fallback, and won=E2=80=99t change the buffer bounds. >=20 > I wonder if we're using this variable in all the places we should. Not sure. Maybe the first step would be to document it and make it customizable, so that people can find it. Then we can add support for it in places that lack it.