From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Paul W. Rankin" Newsgroups: gmane.emacs.devel Subject: Re: Adding olivetti to GNU ELPA Date: Wed, 08 May 2019 14:07:24 +1000 Message-ID: References: <83tvemzcn2.fsf@gnu.org> <9bb5fc63-61ae-44dc-a8d5-b67803eab1e5@www.fastmail.com> <83h8amz24g.fsf@gnu.org> <24cca761-36ea-4c16-bce1-e3651aad52c8@www.fastmail.com> <83ftq6yx5o.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="97065"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: mu4e 1.2.0; emacs 26.2 Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 08 06:08:07 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hODsE-000P8B-I6 for ged-emacs-devel@m.gmane.org; Wed, 08 May 2019 06:08:07 +0200 Original-Received: from localhost ([127.0.0.1]:58512 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hODsD-0004dm-IZ for ged-emacs-devel@m.gmane.org; Wed, 08 May 2019 00:08:05 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43792) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hODrj-0004QG-N0 for emacs-devel@gnu.org; Wed, 08 May 2019 00:07:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hODri-00024O-Ky for emacs-devel@gnu.org; Wed, 08 May 2019 00:07:35 -0400 Original-Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:53699) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hODrg-0001xp-Uh; Wed, 08 May 2019 00:07:33 -0400 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 21DC04AC; Wed, 8 May 2019 00:07:30 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 08 May 2019 00:07:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paulwrankin.com; h=references:from:to:cc:subject:in-reply-to:date:message-id :mime-version:content-type; s=fm3; bh=jtqjaFfaizu1PjG5snZAH5gfNL 8e7HcE5pH6s4KSVyI=; b=k82Pxbu24pA1fXyhh+wuNYs2U8mac2z9YEKUZuhcYQ xlEKU9gagxORH6mH9qGdN3ohxXk7KIsCHj2+FeFE3v5CuwTvLKA6L8bOBq/9ZTAB 3zpEF7+eAfqBwwGDHxBMz5VXb6Pnjbh+QgTFst7R4+u3YMWsrrfjncrzfkrM2Dpx ohUrMHzOoeRRv8casJX5hcVPJaaqjBTEfQ3ouzVQKVzArDrq2phwgS7yV91RerJj OTzPipsQKxWjY+ATCD/2sypWLeAQ6F788h4qJWBFdXaDaAdgbAxLwNlm5KgvJ6oj UK+PelYgPEwG/VZw8MXZWbmxr/G6AGvWquRo0SfEn2dA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=jtqjaF faizu1PjG5snZAH5gfNL8e7HcE5pH6s4KSVyI=; b=jdtwVfAAu8iqmzY4Xvg3G1 lWpLlrSkt0TTxItNPLOV+b/AbO6L1sqBcbHuQ6/Un5dZigyirhZD4vmstt4xTXZb HnB1ON7yNAMuMP9WjDtaMkcFvB3Y8UOWsFStXFtLP1SMPyniboBurQ7w9RA80dWO LKt+wGLetC5LypySgkmLBkelU9CxDN2+mnzCzmfSjwTvs3eg+eRNdJFMTwgrwLNb bbf/gdoQaKIG15PbKtYGRKuV3nOy7gnKc0LAvnrAcL/2U9+JCFKMfQFPuNKqLLmm 1Ua/mAwlFWCdvDQVqu0gPrULEH2D175A+ADfIhJ4GaUJDl5o+x/9BAI6K33Y0Oeg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrkedugdejlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpehffgfhvffujgffkfggtgesthdtredttdertdenucfhrhhomhepfdfrrghulhcu hgdrucftrghnkhhinhdfuceohhgvlhhlohesphgruhhlfihrrghnkhhinhdrtghomheqne cuffhomhgrihhnpehprghulhifrhgrnhhkihhnrdgtohhmnecukfhppedugeegrddufedt rdduheeirdduvdelnecurfgrrhgrmhepmhgrihhlfhhrohhmpehhvghllhhosehprghulh ifrhgrnhhkihhnrdgtohhmnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Original-Received: from localhost (unknown [144.130.156.129]) by mail.messagingengine.com (Postfix) with ESMTPA id 941AB103D1; Wed, 8 May 2019 00:07:28 -0400 (EDT) In-reply-to: <83ftq6yx5o.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 64.147.123.25 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236269 Archived-At: I've pushed some changes provided by Stefan for compatibility with Emacs 27.x. I'm sorry to say but this goes a bit over my head... From Emacs 24 - 27 there seem to be three hooks that have shifting/overlapping capabilities. The hooks are: - window-configuration-change-hook - post-command-hook - window-size-change-functions When I first created the minor mode, window-configuration-change-hook was enough for all situations I encountered. With the introduction of display-line-numbers-mode, Eli suggested I change this to post-command-hook. This seemed not to cover a few window resize events, so I added window-configuration-change-hook back, but I've since received complaints from people experiencing laggy input, but then also errors with Emacs 27.x. At this point I've become too confused to find an adequate solution between the Three Hooks so I (and I'm sure those who use the minor mode) would love if someone more familiar with the changing nature of the Three Hooks could provide a solution... I *think* what is needed is a way to apply the hooks contingent on emacs-major-version <= 24 and <= 25 or 26(?) and <= 27. Much appreciation :) -- https://www.paulwrankin.com