From: Robert Pluim <rpluim@gmail.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Eli Zaretskii <eliz@gnu.org>, Lars Ingebrigtsen <larsi@gnus.org>,
emacs-devel@gnu.org
Subject: Re: bug#40248: 27.0.90; Failure open .authinfo.gpg from Gnus
Date: Tue, 31 Mar 2020 12:16:18 +0200 [thread overview]
Message-ID: <m28sjg4yod.fsf@gmail.com> (raw)
In-Reply-To: <87blocrgtb.fsf@igel.home> (Andreas Schwab's message of "Tue, 31 Mar 2020 11:53:36 +0200")
>>>>> On Tue, 31 Mar 2020 11:53:36 +0200, Andreas Schwab <schwab@linux-m68k.org> said:
Andreas> On Mär 31 2020, Robert Pluim wrote:
>> @@ -245,11 +252,15 @@ 'open-protocol-stream
>> "26.1")
>>
>> (defun network-stream-open-plain (name buffer host service parameters)
>> - (let ((start (with-current-buffer buffer (point)))
>> - (stream (make-network-process :name name :buffer buffer
>> - :host (puny-encode-domain host)
>> - :service service
>> - :nowait (plist-get parameters :nowait))))
>> + (let* ((start (with-current-buffer buffer (point)))
>> + (coding-p (plist-member parameters :coding))
>> + (coding-val (plist-get parameters :coding))
>> + (args (append (list :name name :buffer buffer
>> + :host (puny-encode-domain host)
>> + :service service
>> + :nowait (plist-get parameters :nowait))
>> + (when coding-p (list :coding coding-val))))
>> + (stream (apply #'make-network-process args)))
Andreas> You don't need to use apply. Since :coding nil is the same as the
Andreas> default, you can just pass `:coding (plist-get parameters :coding)'
Andreas> unconditionally.
My reading of set_network_socket_coding_system is that having a plist
in make-network-process with :coding nil overrides a non-nil
coding-system-for-{read-write}, which I donʼt think we want.
Robert
next prev parent reply other threads:[~2020-03-31 10:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <86bloi1zrj.fsf@csic.es>
[not found] ` <83lfnm8b30.fsf@gnu.org>
[not found] ` <83ftdt9b1d.fsf@gnu.org>
[not found] ` <86sght3h1s.fsf@csic.es>
[not found] ` <834ku89anf.fsf@gnu.org>
[not found] ` <87a740ub2r.fsf@gnus.org>
[not found] ` <83tv287s9j.fsf@gnu.org>
[not found] ` <874ku7txho.fsf@gnus.org>
[not found] ` <83imin5l0w.fsf@gnu.org>
2020-03-31 9:20 ` bug#40248: 27.0.90; Failure open .authinfo.gpg from Gnus Robert Pluim
2020-03-31 9:53 ` Andreas Schwab
2020-03-31 10:16 ` Robert Pluim [this message]
2020-03-31 10:31 ` Andreas Schwab
2020-03-31 11:09 ` Robert Pluim
2020-03-31 16:13 ` Robert Pluim
2020-03-31 17:59 ` Eli Zaretskii
2020-03-31 19:53 ` Robert Pluim
2020-04-02 11:10 ` Lars Ingebrigtsen
2020-04-02 12:48 ` Robert Pluim
2020-04-03 11:52 ` Lars Ingebrigtsen
2020-04-03 12:50 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m28sjg4yod.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).