From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Rudolf =?utf-8?Q?Adamkovi=C4=8D?= Newsgroups: gmane.emacs.devel Subject: Re: feature/package-vc has been merged Date: Sat, 12 Nov 2022 01:32:09 +0100 Message-ID: References: <164484721900.31751.1453162457552427931@vcs2.savannah.gnu.org> <87edupbdp0.fsf@posteo.net> <875yg1bc02.fsf@posteo.net> <878rkxgpms.fsf@posteo.net> <87sfiyk3a2.fsf_-_@posteo.net> <87mt948pmo.fsf@posteo.net> <87fsevyxnt.fsf@posteo.net> <87zgd1f70g.fsf@posteo.net> <878rkkbj90.fsf@posteo.net> <87edua7jw5.fsf@posteo.net> <878rki7jf3.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28479"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier , Richard Stallman , emacs-devel@gnu.org, 'Eli Zaretskii' To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 12 01:33:03 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oteSF-0007CE-Fb for ged-emacs-devel@m.gmane-mx.org; Sat, 12 Nov 2022 01:33:03 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oteRY-0002iE-TV; Fri, 11 Nov 2022 19:32:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oteRX-0002hV-Jj for emacs-devel@gnu.org; Fri, 11 Nov 2022 19:32:19 -0500 Original-Received: from mr85p00im-ztdg06021101.me.com ([17.58.23.180]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oteRU-0006Wv-3V for emacs-devel@gnu.org; Fri, 11 Nov 2022 19:32:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=1a1hai; t=1668213133; bh=/82/UGfRuE+gCS+sVRionm2ep590Vyj+OrVcQWFfcnI=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=SVaiIN0qL/YXuo9j2JcfJTcbLTxKcWw2XWx1U4YfuRGZAA2IO3UB7/rUUYv0y9mSA ZhnEm0ilJf8j+baHECp+WAMwAv7MUEO8v/41EdWPhN3Xm9TsOhq3JT7uNjASGeP4xn kvAxvJO5OLtom9C5JNq3EjEcsAvrZpL3+mYih1xhNT3g3AxLTRXzmgWs2xLxFe9wUA phaG031pktD5oZ9339Q2H8t6Andk0rznpJaWeto2xf7+SxEMHvNm1e33e6YpHFuUZK XRHpFxQRqSZZwUXEWufJ31QB03LkCVgiB76WAwbR/j020mkFyi7vPsV80PHTMahI7I IL66i7BHyr3aw== Original-Received: from Rudolfs-MacBook-Air.local (mr38p00im-dlb-asmtp-mailmevip.me.com [17.57.152.18]) by mr85p00im-ztdg06021101.me.com (Postfix) with ESMTPSA id DA2C380562; Sat, 12 Nov 2022 00:32:11 +0000 (UTC) In-Reply-To: <878rki7jf3.fsf@posteo.net> X-Proofpoint-ORIG-GUID: XdV_fjyXslMpPCcV2pqfQMKcEqBtQIUa X-Proofpoint-GUID: XdV_fjyXslMpPCcV2pqfQMKcEqBtQIUa X-Proofpoint-Virus-Version: =?UTF-8?Q?vendor=3Dfsecure_engine=3D1.1.170-22c6f66c430a71ce266a39bfe25bc?= =?UTF-8?Q?2903e8d5c8f:6.0.138,18.0.572,17.0.605.474.0000000_definitions?= =?UTF-8?Q?=3D2020-02-14=5F11:2020-02-14=5F02,2020-02-14=5F11,2020-01-23?= =?UTF-8?Q?=5F02_signatures=3D0?= X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 spamscore=0 adultscore=0 mlxscore=0 clxscore=1015 phishscore=0 suspectscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2211120001 Received-SPF: pass client-ip=17.58.23.180; envelope-from=salutis@me.com; helo=mr85p00im-ztdg06021101.me.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299591 Archived-At: Philip Kaludercic writes: > (sorry, this message got sent out too early. Continuing my reply > here) Gotcha! Replying to both messages here. >> M-x package-vc-refresh > > As we seem to use package.el in different ways, can you clarify what > your intention is when invoking `package-vc-refresh'? I wanted to see what it does with empty `package-vc-selected-packages'. Yeah, I know. A strange "first thing one does". :) > The documentation string tries to clarify what is does, but perhaps > the name is confusing: > > "Refresh the installation for package given by PKG-DESC. > Refreshing an installation means scraping for new autoload > cookies, re-compiling Emacs Lisp files, building and installing > any documentation, downloading any missing dependencies. This > command does not fetch new revisions from a remote server. That > is the responsibility of `package-vc-update'. Interactively, > prompt for the name of the package to refresh." > > Reload? Regenerate? Redo? So good! The documentation before said that it refreshes the given package. Hence, I kept scratching my head. Now, it all makes sense. As for the name, how about rebuild? All those steps normally happen during a build process. I think "refresh" sounds much too close to "update". >> Oh, the list! Change the configuration again: >> >> (with-eval-after-load 'package-vc >> (add-to-list 'package-vc-selected-packages '(modus-themes))) >> >> Restart Emacs. > > Two ways to resolve this: Either throw an error earlier, which might > be annoying but the right thing=E2=84=A2, or dwim and accept that the val= ue > might not be readable in ECI. Early or late, we need to show at least the traditional Emacs type predicate error. I say that because it took me ten minutes to find the problem. :) > This issue should be resolved with the above patch, but the question > still remains what went wrong in the above installation. Can you > check/post the -pkg.el and -autoloads.el file? Oops, I since then restored everything back. No worries though, I will do more testing going forward! > package-vc.el (just like package.el) doesn't treat MELPA packages as > special or different. If you give `package-vc-install' a URL, it will > try to guess what has to be done -- this doesn't always work, but the > guessing can still be improved. > > What you can do with `package-vc-selected-packages' is give your own > ELPA-esque specification. That should work most of the time if a > package is not available on GNU ELPA or NonGNU ELPA. I see. Smart! > Did the above [`package-vc-refresh'] docstring clarify that point? Definitely! >> I could not find `package-vc-update-all' akin `package-update-all'. >> Not that I needed it, but I looked for it in the case I manage to >> install more packages. > > It doesn't exist. My idea was that package-update-all would handle > that, but there might be a value in a command that only updates source > packages? I think that would make sense. >> The `package-vc-selected-packages' documentation [...] > > As mentioned above there are a few commits I haven't been able to push > because emacs.git is preventing me from force pushing. I'll try to > get them up there some other way, and then rewrite the history before > rebasing the changes onto master. So much for "scratch" branches. :-/ Rudy --=20 "Be especially critical of any statement following the word 'obviously.'" -- Anna Pell Wheeler, 1883-1966 Rudolf Adamkovi=C4=8D [he/him] Studenohorsk=C3=A1 25 84103 Bratislava Slovakia