From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: scratch/igc 3f46110b878: Fix an eassert Date: Wed, 11 Dec 2024 16:36:02 +0100 Message-ID: References: <173392893159.259533.15506246926795870751@vcs3.savannah.gnu.org> <20241211145532.114DD65A960@vcs3.savannah.gnu.org> <8734iul0j5.fsf@protonmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2670"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org, Gerd =?utf-8?Q?M=EF=BF=BDllmann?= To: Pip Cet Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 11 16:36:35 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tLOlP-0000WG-09 for ged-emacs-devel@m.gmane-mx.org; Wed, 11 Dec 2024 16:36:35 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tLOl3-00077j-UC; Wed, 11 Dec 2024 10:36:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tLOky-00077G-Bt for emacs-devel@gnu.org; Wed, 11 Dec 2024 10:36:08 -0500 Original-Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tLOkw-0001BI-KZ; Wed, 11 Dec 2024 10:36:08 -0500 Original-Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-385dece873cso3341763f8f.0; Wed, 11 Dec 2024 07:36:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733931364; x=1734536164; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FJe2IvBS/DsCZ3dA7fGj8ROBhkYsFwZr7QYp0VN4ENc=; b=F8tx7iC46F6zwSt2SR8pouxrGjI+y6wkHBIxnnQQ3dlY6ZW38aYncXSndVORGXmwOw NZnW9AZo8rB2SffnRhHWXycPHkiJD8IQdObwIyUcpd/YF0X0bNO464gQmG1LZslyFnjU 7HR+hn68/O18p4JJWohteYMCR7qqEBxEGSckIMLKZa6QyCxJedrpc5YG5tYruG7X3Er7 9ayg2It1Y2xOdz3HycaQgu959UFVbMHEI3SdfF5gWdVBx69/qzGnGuZspVBn4YS/Zy1R ZTe6gNi1c2vDYX6LDvU9KZSviCXq0hcaCL8EQT2ZMxNBiU5D0VjNzhSdyv1hIiRLGdgL jszA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733931364; x=1734536164; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=FJe2IvBS/DsCZ3dA7fGj8ROBhkYsFwZr7QYp0VN4ENc=; b=Qb8hArMpu+3ZEhDny5r4EpZlRY4bNzF1Kn4S8DE+l9cBtnftAdrQVg/U2c6FFbKEMl zjm3H2YiCz3cC3IaaOD/4qyAYuQaTgj0SOOEOvrjfBbcYvBNiIPph10MP9iirn2ZFM2H voAvEfSuNM84PbricViuZIa3Ets+alJUUiVSQdNexBywO/DjWX2r2Nbs8o8VN3uzZy9y rpl8v5PT5rJTfKETJVjFMI7eaEVb3y6Uf4/DYxYWyfek9sr13wDZsa5DR3eHsKZIso2O ImPafUUlid75glQ5bKlJ2M4A/+iGpc4GU+2NW1Qg6P89c78Ga2borc9/HIlrDV0d9MR4 488g== X-Forwarded-Encrypted: i=1; AJvYcCWmwN/ejR/FKSynTmPqzgYTJHZc7HJ8W+hh2sIG2Q9ZIyWFuKTUqUAnNwYoK+y/QOy6/TYU@gnu.org X-Gm-Message-State: AOJu0Yx40Lyd1pFmcVP8dgnPaAmdbbDiJ/CWrB1MnMsrAHnqpAgyHFMn bO/NwH4q8w/QHWMeXLg584w315HwRqFziaaqPPq7vylfmAc0exCwWq5qIg== X-Gm-Gg: ASbGnctaSO8Dp1xc13/m0LRQdPRqo0DRTpGvNZhyBbpcIdEnq+fWLc0ySdvOG6LXBmA 5ulAGRyBl5bChgaIckYOHOeEoasNowKaFDwO4/4/N1BEAHtLGpqjlW1Ui4G0MH2Al1wRytev9IT SgFqgZw34EEaQdBvlzb+FEMbUv4nSvghVwkjZK/avvol3HsnbX8+WZdlYW9nYyQgawldIWTLS57 xfP4ndwzpe8TMZYtYso5Dg3DvMJW2JLEy8HjyTgm4rgnXo3Jgq+bO9XD6VOCt5k3RT5zxALeddy HbbfC6QTNI0+oUMvCO9nAmuO5f31vXOvsxMFomRSXe91+7Y/1TWLbN694bIZVr8= X-Google-Smtp-Source: AGHT+IHMCrviKbTUYXd62jQzbLTsnt9xlwMZZP3GwYLIE8X+IZTenRHVv2B9G/XML6NXn1BGSAP8Lg== X-Received: by 2002:a5d:6486:0:b0:386:4a60:6650 with SMTP id ffacd0b85a97d-3864cec5bd0mr3042535f8f.42.1733931363476; Wed, 11 Dec 2024 07:36:03 -0800 (PST) Original-Received: from pro2 (p200300e0b709ba00c5d5596d9959c8a7.dip0.t-ipconnect.de. [2003:e0:b709:ba00:c5d5:596d:9959:c8a7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3878248f734sm1560160f8f.5.2024.12.11.07.36.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Dec 2024 07:36:03 -0800 (PST) In-Reply-To: <8734iul0j5.fsf@protonmail.com> (Pip Cet's message of "Wed, 11 Dec 2024 15:09:47 +0000") Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=gerd.moellmann@gmail.com; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326356 Archived-At: Pip Cet writes: > "Gerd Moellmann" writes: > >> branch: scratch/igc >> commit 3f46110b878ef0940ad7c0a9eacd6ef441baad7d >> Author: Gerd M=C3=B6llmann >> Commit: Gerd M=C3=B6llmann >> >> Fix an eassert >> --- >> src/igc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/igc.c b/src/igc.c >> index b1ef6939b5f..2ce508e055e 100644 >> --- a/src/igc.c >> +++ b/src/igc.c >> @@ -2223,7 +2223,7 @@ fix_weak_hash_table_weak_part (mps_ss_t ss, struct= Lisp_Weak_Hash_Table_Weak_Par >> for (ssize_t i =3D 0; i < limit; i++) >> { >> if (w->entries[i].intptr & 1) >> - eassert ((mps_word_t)w->entries[i].intptr ^ w->entries[i].intptr= =3D=3D 0); >> + eassert ((mps_word_t)w->entries[i].intptr ^ (w->entries[i].intpt= r =3D=3D 0)); >> bool was_nil =3D (w->entries[i].intptr) =3D=3D 0; >> intptr_t off =3D 0; >> #ifdef WORDS_BIGENDIAN > > I'm guessing I'm failing a basic C knowledge test here, but can you > explain? Did you run into an assertion error with the old code, or a > compiler warning? It was a warning from clang. So the right thing would be (x ^ y) =3D=3D 0?