unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Some MacOSX build related questions
@ 2011-10-19 11:29 CHENG Gao
  2011-10-19 15:45 ` Adrian Robert
  2011-10-19 15:50 ` Jan Djärv
  0 siblings, 2 replies; 4+ messages in thread
From: CHENG Gao @ 2011-10-19 11:29 UTC (permalink / raw)
  To: emacs-devel


1) In nextstep/README, it states MacOSX supported are 10.4 and up.
I suppose this is official. (It must be)

2) Considering 1), some code that checks MAC_OS_X_VERSION > 1030 or <
1040  or even < 1020 seems not necessary anymore. 

3) For same reason, is MAC_OS_X_VERSION_MAX_ALLOWED >=
MAC_OS_X_VERSION_10_4 check necessary anymore?

4) MAC_OS_X_VERSION_10_x (3, 4, 5, 6 at present) are defined in nsterm.h
and some other files. Is it necessary? Is it enough as nsgui.h does? (as below)

,----
| #ifdef NS_IMPL_COCOA
| #include <AvailabilityMacros.h>
| #endif /* NS_IMPL_COCOA */
`----

5) In nsimage.m, it has 'onTiger' check (defined in nsterm.h). If
official support version is 10.4 (Tiger) and up, this seems not
necessary anymore.




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Some MacOSX build related questions
  2011-10-19 11:29 Some MacOSX build related questions CHENG Gao
@ 2011-10-19 15:45 ` Adrian Robert
  2011-10-19 15:50 ` Jan Djärv
  1 sibling, 0 replies; 4+ messages in thread
From: Adrian Robert @ 2011-10-19 15:45 UTC (permalink / raw)
  To: emacs-devel



Hi Gao,


> 1) In nextstep/README, it states MacOSX supported are 10.4 and up.
> I suppose this is official. (It must be)

Yes.


> 2) Considering 1), some code that checks MAC_OS_X_VERSION > 1030 or <
> 1040  or even < 1020 seems not necessary anymore. 
>
> 3) For same reason, is MAC_OS_X_VERSION_MAX_ALLOWED >=
> MAC_OS_X_VERSION_10_4 check necessary anymore?

You are probably right here.  The decision to terminate Panther support
was made officially, but the code was never updated to clean out that
support.  In addition to the macros you point out, I believe there are
some code blocks that can be removed.


> 4) MAC_OS_X_VERSION_10_x (3, 4, 5, 6 at present) are defined in nsterm.h
> and some other files. Is it necessary? Is it enough as nsgui.h does? (as below)

I am not sure on this one.


> 5) In nsimage.m, it has 'onTiger' check (defined in nsterm.h). If
> official support version is 10.4 (Tiger) and up, this seems not
> necessary anymore.

Yes, see above.


thanks,
Adrian





^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Some MacOSX build related questions
  2011-10-19 11:29 Some MacOSX build related questions CHENG Gao
  2011-10-19 15:45 ` Adrian Robert
@ 2011-10-19 15:50 ` Jan Djärv
  2011-10-19 16:05   ` CHENG Gao
  1 sibling, 1 reply; 4+ messages in thread
From: Jan Djärv @ 2011-10-19 15:50 UTC (permalink / raw)
  To: CHENG Gao; +Cc: emacs-devel


19 okt 2011 kl. 13:29 skrev CHENG Gao:

> 
> 1) In nextstep/README, it states MacOSX supported are 10.4 and up.
> I suppose this is official. (It must be)
> 

I guess so.

> 2) Considering 1), some code that checks MAC_OS_X_VERSION > 1030 or <
> 1040  or even < 1020 seems not necessary anymore. 
> 

No, but nobody has taken the time to clean it up.

> 3) For same reason, is MAC_OS_X_VERSION_MAX_ALLOWED >=
> MAC_OS_X_VERSION_10_4 check necessary anymore?
> 

Same answer as above.

> 4) MAC_OS_X_VERSION_10_x (3, 4, 5, 6 at present) are defined in nsterm.h
> and some other files. Is it necessary? Is it enough as nsgui.h does? (as below)
> 
> ,----
> | #ifdef NS_IMPL_COCOA
> | #include <AvailabilityMacros.h>
> | #endif /* NS_IMPL_COCOA */
> `----

No, this is not enough.  For example, MAC_OS_X_VERSION_10_6 is not defined on OSX 10.4, but we use it in the source, so we must define it if not defined.
The define for MAC_OS_X_VERSION_10_6 in nsterm.m is redundant though.

> 
> 5) In nsimage.m, it has 'onTiger' check (defined in nsterm.h). If
> official support version is 10.4 (Tiger) and up, this seems not
> necessary anymore.
> 

I guess it is not, if indeed that function is available in Tiger and onwards.  But it might also mean that it is only available in Tiger and not in later versions.  I haven't checked.

	Jan D.




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Some MacOSX build related questions
  2011-10-19 15:50 ` Jan Djärv
@ 2011-10-19 16:05   ` CHENG Gao
  0 siblings, 0 replies; 4+ messages in thread
From: CHENG Gao @ 2011-10-19 16:05 UTC (permalink / raw)
  To: emacs-devel

*On Wed, 19 Oct 2011 17:50:26 +0200
* Also sprach Jan Djärv <jan.h.d@swipnet.se>:

>> 4) MAC_OS_X_VERSION_10_x (3, 4, 5, 6 at present) are defined in
>> nsterm.h and some other files. Is it necessary? Is it enough as
>> nsgui.h does? (as below)
>> 
>> ,----
>> | #ifdef NS_IMPL_COCOA #include <AvailabilityMacros.h> #endif /*
>> | NS_IMPL_COCOA */
>> `----
>
> No, this is not enough. For example, MAC_OS_X_VERSION_10_6 is not
> defined on OSX 10.4, but we use it in the source, so we must define it
> if not defined. The define for MAC_OS_X_VERSION_10_6 in nsterm.m is
> redundant though.

Thanks for explanation. Now I understand.




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2011-10-19 16:05 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-19 11:29 Some MacOSX build related questions CHENG Gao
2011-10-19 15:45 ` Adrian Robert
2011-10-19 15:50 ` Jan Djärv
2011-10-19 16:05   ` CHENG Gao

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).